[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR (M)
From:       Chris Plummer <chris.plummer () oracle ! com>
Date:       2019-04-29 17:37:44
Message-ID: 3a534b3a-fe5a-6574-61f3-d16b4167132b () oracle ! com
[Download RAW message or body]

<html>
  <head>
    <meta http-equiv="Content-Type" content="text/html; charset=utf-8">
  </head>
  <body text="#000000" bgcolor="#FFFFFF">
    <div class="moz-cite-prefix">Hi JC,<br>
      <br>
      In em01t002.cpp, is this correct?<br>
      <br>
         73         loadedClass = (jclass)
      jni_env-&gt;CallObjectMethod(loader, methodID, TRACE_JNI_CALL,
      className);<br>
      <br>
      Shouldn't the TRACE_JNI_CALL arg be last? If so, can you look into
      why this test didn't fail as a result.<br>
      <br>
      Other than that the changes look good.<br>
      <br>
      thanks,<br>
      <br>
      Chris<br>
      <br>
      On 4/26/19 4:19 PM, Jean Christophe Beyler wrote:<br>
    </div>
    <blockquote type="cite"
cite="mid:CAF9BGBy3WUmeNE_A5ZMSxyNAxjgOR1Cp7_2eNBCL8ZHWztGtvA@mail.gmail.com">
      <meta http-equiv="content-type" content="text/html; charset=utf-8">
      <div dir="ltr">
        <div dir="ltr">
          <div dir="ltr">
            <div dir="ltr">Hi all,
              <div><br>
              </div>
              <div>Since  JDK-8213501 finally merged (sorry it took so
                long), I am able to continue this work. Here is the work
                that puts back the messages for any calls that were
                moved around due to  JDK-8212884.<br clear="all">
                <div><br>
                </div>
                <div>Webrev: <a
                    href="http://cr.openjdk.java.net/%7Ejcbeyler/8223044/webrev.00/"
                    moz-do-not-send="true">http://cr.openjdk.java.net/~jcbeyler/8223044/webrev.00/</a></div>
  <div>Bug:  <a
                    href="https://bugs.openjdk.java.net/browse/JDK-8223044"
                    moz-do-not-send="true">https://bugs.openjdk.java.net/browse/JDK-8223044</a></div>
  <div><br>
                </div>
                <div>All modified tests pass on my local dev machine.</div>
                <div><br>
                </div>
                <div dir="ltr" class="gmail_signature">
                  <div dir="ltr">Thanks,
                    <div>Jc</div>
                  </div>
                </div>
              </div>
            </div>
          </div>
        </div>
      </div>
    </blockquote>
    <p><br>
    </p>
  </body>
</html>


[prev in list] [next in list] [prev in thread] [next in thread]

Configure | About | News | Add a list | Sponsored by KoreLogic