[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-serviceability-dev
Subject: Re: 8222749: vmTestbase/nsk/jdi/ThreadStartRequest/addThreadFilter/addthreadfilter001/TestDescriptio
From: Daniil Titov <daniil.x.titov () oracle ! com>
Date: 2019-04-26 17:06:46
Message-ID: F7080911-FD4A-4EA4-A642-185B1B6E7EB7 () oracle ! com
[Download RAW message or body]
Thank you, Serguei and JC, for reviewing this change!
Best regards,
Daniil
From: Jean Christophe Beyler <jcbeyler@google.com>
Date: Thursday, April 25, 2019 at 5:32 PM
To: Serguei Spitsyn <serguei.spitsyn@oracle.com>
Cc: Daniil Titov <daniil.x.titov@oracle.com>, OpenJDK Serviceability \
<serviceability-dev@openjdk.java.net>
Subject: Re: RFR: 8222749: \
vmTestbase/nsk/jdi/ThreadStartRequest/addThreadFilter/addthreadfilter001/TestDescription.java \
failed with "eventSet1.size() != 3 :: 2"
Hi Daniil,
It looks good to me too :)
Jc
On Thu, Apr 25, 2019 at 5:21 PM <serguei.spitsyn@oracle.com> wrote:
Hi Daniil,
Looks good.
Thanks,
Serguei
On 4/25/19 4:34 PM, Daniil Titov wrote:
> Please review the change that fixes this test when it is run with Graal on.
>
> The test starts the debugee, creates multiple thread start requests, tells the \
> debuggee to start a new thread, and listens for the thread start events received. \
> If the number of the received thread start events doesn't match the number of \
> created thread start requests the test fails. The problem here is that with Graal \
> on, sometimes, the test receives events caused by the start of \
> "HotSpotGraalManagement Bean Registration" thread.
> The fix ensures that a thread filter is added for all created thread start requests \
> to ignore events caused by the threads not related to the test.
> Webrev: http://cr.openjdk.java.net/~dtitov/8222749/webrev.01/
> Bug: https://bugs.openjdk.java.net/browse/JDK-8222749
>
> Thanks,
> Daniil
>
>
--
Thanks,
Jc
[Attachment #3 (text/html)]
<html xmlns:o="urn:schemas-microsoft-com:office:office" \
xmlns:w="urn:schemas-microsoft-com:office:word" \
xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" \
xmlns="http://www.w3.org/TR/REC-html40"><head><meta http-equiv=Content-Type \
content="text/html; charset=utf-8"><meta name=Generator content="Microsoft Word 15 \
(filtered medium)"><style><!-- /* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
p.msonormal0, li.msonormal0, div.msonormal0
{mso-style-name:msonormal;
mso-margin-top-alt:auto;
margin-right:0in;
mso-margin-bottom-alt:auto;
margin-left:0in;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
span.EmailStyle18
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style></head><body lang=EN-US link=blue vlink=purple><div class=WordSection1><p \
class=MsoNormal>Thank you, Serguei and JC, for reviewing this \
change!<o:p></o:p></p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal>Best \
regards,<o:p></o:p></p><p class=MsoNormal>Daniil<o:p></o:p></p><p \
class=MsoNormal><o:p> </o:p></p><div style='border:none;border-top:solid #B5C4DF \
1.0pt;padding:3.0pt 0in 0in 0in'><p class=MsoNormal><b><span \
style='font-size:12.0pt;color:black'>From: </span></b><span \
style='font-size:12.0pt;color:black'>Jean Christophe Beyler \
<jcbeyler@google.com><br><b>Date: </b>Thursday, April 25, 2019 at 5:32 \
PM<br><b>To: </b>Serguei Spitsyn <serguei.spitsyn@oracle.com><br><b>Cc: \
</b>Daniil Titov <daniil.x.titov@oracle.com>, OpenJDK Serviceability \
<serviceability-dev@openjdk.java.net><br><b>Subject: </b>Re: RFR: 8222749: \
vmTestbase/nsk/jdi/ThreadStartRequest/addThreadFilter/addthreadfilter001/TestDescription.java \
failed with "eventSet1.size() != 3 :: 2"<o:p></o:p></span></p></div><div><p \
class=MsoNormal><o:p> </o:p></p></div><div><p class=MsoNormal>Hi \
Daniil,<o:p></o:p></p><div><p class=MsoNormal><o:p> </o:p></p></div><div><p \
class=MsoNormal>It looks good to me too :)<o:p></o:p></p></div><div><p \
class=MsoNormal>Jc<o:p></o:p></p></div></div><p \
class=MsoNormal><o:p> </o:p></p><div><div><p class=MsoNormal>On Thu, Apr 25, \
2019 at 5:21 PM <<a \
href="mailto:serguei.spitsyn@oracle.com">serguei.spitsyn@oracle.com</a>> \
wrote:<o:p></o:p></p></div><blockquote style='border:none;border-left:solid #CCCCCC \
1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-right:0in'><p \
class=MsoNormal style='margin-bottom:12.0pt'>Hi Daniil,<br><br>Looks \
good.<br><br>Thanks,<br>Serguei<br><br>On 4/25/19 4:34 PM, Daniil Titov \
wrote:<br>> Please review the change that fixes this test when it is run with \
Graal on.<br>><br>> The test starts the debugee, creates multiple thread start \
requests, tells the debuggee to start a new thread, and listens for the thread start \
events received. If the number of the received thread start events doesn't match the \
number of created thread start requests the test fails. The problem here is that with \
Graal on, sometimes, the test receives events caused by the start of \
"HotSpotGraalManagement Bean Registration" thread.<br>><br>> The fix \
ensures that a thread filter is added for all created thread start requests to ignore \
events caused by the threads not related to the test.<br>><br>> Webrev: <a \
href="http://cr.openjdk.java.net/~dtitov/8222749/webrev.01/" \
target="_blank">http://cr.openjdk.java.net/~dtitov/8222749/webrev.01/</a><br>> \
Bug: <a href="https://bugs.openjdk.java.net/browse/JDK-8222749" \
target="_blank">https://bugs.openjdk.java.net/browse/JDK-8222749</a><br>><br>> \
Thanks,<br>> Daniil<br>><br>><o:p></o:p></p></blockquote></div><p \
class=MsoNormal><br clear=all><o:p></o:p></p><div><p \
class=MsoNormal><o:p> </o:p></p></div><p class=MsoNormal>-- \
<o:p></o:p></p><div><div><div><p class=MsoNormal><o:p> </o:p></p></div><p \
class=MsoNormal>Thanks,<o:p></o:p></p><div><p \
class=MsoNormal>Jc<o:p></o:p></p></div></div></div></div></body></html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic