[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR: 8222749: vmTestbase/nsk/jdi/ThreadStartRequest/addThreadFilter/addthreadfilter001/TestDescr
From:       Jean Christophe Beyler <jcbeyler () google ! com>
Date:       2019-04-26 0:32:16
Message-ID: CAF9BGBxS3dXVjNyk5QHGCxtmXRJZPU0oq7F9AY_wcbaMP8R2XA () mail ! gmail ! com
[Download RAW message or body]

Hi Daniil,

It looks good to me too :)
Jc

On Thu, Apr 25, 2019 at 5:21 PM <serguei.spitsyn@oracle.com> wrote:

> Hi Daniil,
>
> Looks good.
>
> Thanks,
> Serguei
>
> On 4/25/19 4:34 PM, Daniil Titov wrote:
> > Please review the change that fixes this test when it is run with Graal
> on.
> >
> > The test starts the debugee, creates multiple thread start requests,
> tells the debuggee to start a new thread, and listens for the thread start
> events received. If the number of the received thread start events doesn't
> match the number of created thread start requests the test fails. The
> problem here is that with Graal on, sometimes,  the test receives events
> caused by the start of "HotSpotGraalManagement Bean Registration" thread.
> >
> > The fix ensures that a thread filter is added for all created thread
> start requests to ignore events caused by the threads not related to the
> test.
> >
> > Webrev: http://cr.openjdk.java.net/~dtitov/8222749/webrev.01/
> > Bug: https://bugs.openjdk.java.net/browse/JDK-8222749
> >
> > Thanks,
> > Daniil
> >
> >
>
>

-- 

Thanks,
Jc

[Attachment #3 (text/html)]

<div dir="ltr">Hi Daniil,<br><div><br></div><div>It looks good to me too \
:)</div><div>Jc</div></div><br><div class="gmail_quote"><div dir="ltr" \
class="gmail_attr">On Thu, Apr 25, 2019 at 5:21 PM &lt;<a \
href="mailto:serguei.spitsyn@oracle.com">serguei.spitsyn@oracle.com</a>&gt; \
wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Hi Daniil,<br> <br>
Looks good.<br>
<br>
Thanks,<br>
Serguei<br>
<br>
On 4/25/19 4:34 PM, Daniil Titov wrote:<br>
&gt; Please review the change that fixes this test when it is run with Graal on.<br>
&gt;<br>
&gt; The test starts the debugee, creates multiple thread start requests, tells the \
debuggee to start a new thread, and listens for the thread start events received. If \
the number of the received thread start events doesn&#39;t match the number of \
created thread start requests the test fails. The problem here is that with Graal on, \
sometimes,   the test receives events caused by the start of \
&quot;HotSpotGraalManagement Bean Registration&quot; thread.<br> &gt;<br>
&gt; The fix ensures that a thread filter is added for all created thread start \
requests to ignore events caused by the threads not related to the test.<br> &gt;<br>
&gt; Webrev: <a href="http://cr.openjdk.java.net/~dtitov/8222749/webrev.01/" \
rel="noreferrer" target="_blank">http://cr.openjdk.java.net/~dtitov/8222749/webrev.01/</a><br>
 &gt; Bug: <a href="https://bugs.openjdk.java.net/browse/JDK-8222749" \
rel="noreferrer" target="_blank">https://bugs.openjdk.java.net/browse/JDK-8222749</a><br>
 &gt;<br>
&gt; Thanks,<br>
&gt; Daniil<br>
&gt;<br>
&gt;<br>
<br>
</blockquote></div><br clear="all"><div><br></div>-- <br><div dir="ltr" \
class="gmail_signature"><div \
dir="ltr"><div><br></div>Thanks,<div>Jc</div></div></div>



[prev in list] [next in list] [prev in thread] [next in thread]