[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: 8222224: vmTestbase/nsk/jvmti/SingleStep/singlestep001/TestDescription.java fails
From:       Daniil Titov <daniil.x.titov () oracle ! com>
Date:       2019-04-10 21:19:46
Message-ID: F8B3E8E0-19DD-4134-A394-CC73F11E89CA () oracle ! com
[Download RAW message or body]

Thank you, Serguei, JC, and Alex, for reviewing this change.

Best regards,
Daniil

On 4/10/19, 9:58 AM, "serviceability-dev on behalf of Alex Menkov" \
<serviceability-dev-bounces@openjdk.java.net on behalf of alexey.menkov@oracle.com> \
wrote:

    +1
    
    --alex
    
    On 04/09/2019 19:38, Jean Christophe Beyler wrote:
    > Hi Daniil,
    > 
    > Looks good to me too :-)
    > Jc
    > 
    > On Tue, Apr 9, 2019 at 7:01 PM <serguei.spitsyn@oracle.com 
    > <mailto:serguei.spitsyn@oracle.com>> wrote:
    > 
    >     Hi Daniil,
    > 
    >     It looks good.
    > 
    >     Thanks,
    >     Serguei
    > 
    > 
    >     On 4/9/19 4:37 PM, Daniil Titov wrote:
    >      > Please review the change that fixes intermittent failure of the
    >     test when running with Graal on.
    >      >
    >      > The problem here is the similar to the one fixed in JDK-8218401,
    >     the callbacks this test enables keep processing events and perform
    >     JVMTI calls after VM is terminated. The fix ensures that the test
    >     does a quick return from the callbacks after VMDeath event is received.
    >      >
    >      > Webrev: http://cr.openjdk.java.net/~dtitov/8222224/webrev.01/
    >      > Bug: https://bugs.openjdk.java.net/browse/JDK-8222224
    >      >
    >      > Thanks!
    >      > --Daniil
    >      >
    >      >
    > 
    > 
    > 
    > -- 
    > 
    > Thanks,
    > Jc
    
    


[prev in list] [next in list] [prev in thread] [next in thread]