[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR: JDK-8203364: Some serviceability/sa/ tests intermittently fail with java.io.IOException: Li
From:       serguei.spitsyn () oracle ! com
Date:       2019-04-09 22:19:47
Message-ID: 46aec1c2-1cbd-0966-84f0-4a4c0fd8f2af () oracle ! com
[Download RAW message or body]

Hi Gary,

It looks Okay in general.
On minor suggestion.
Could you, introduce symbolic constants and use them for exit codes?
They will be self-describing that way.

Thanks,
Serguei

On 4/4/19 5:02 AM, Gary Adams wrote:
> I need a second reviewer for this minor update.
>
> On 4/2/19, 2:18 PM, Chris Plummer wrote:
>> On 4/2/19 11:11 AM, Gary Adams wrote:
>>> The test exits with 3 for the general Exception.
>>> I added 4 just to distinguish the return.
>>> I see 7 used earlier when the lockfile is not initialized.
>>>
>>> I could add a message, if you think it is useful.
>> Yes, I think it would be.
>>>
>>> The exit code is printed in stopApp(). line 377.
>> Ok. I was just wondering if specific error codes were being checked 
>> for. It looks like that's not the case.
>>
>> thanks,
>>
>> Chris
>>>
>>> On 4/2/19, 1:58 PM, Chris Plummer wrote:
>>>> Hi Gary,
>>>>
>>>> I see various System.exit() calls with varying exit status. Is 
>>>> there some place that documents them? What is 4?
>>>>
>>>> Any reason not to print the exception before doing the System.exit(4)?
>>>>
>>>> thanks,
>>>>
>>>> Chris
>>>>
>>>> On 4/2/19 4:50 AM, Gary Adams wrote:
>>>>> This proposed change allows a wider range of IOExceptions to be 
>>>>> observed
>>>>> when a LingeredApp is being shutdown. It may not be just a 
>>>>> NoSuchFileException.
>>>>> Botton line - if the lock file doesn't exist at the time the 
>>>>> IOException
>>>>> is observed then the main application is terminating the test 
>>>>> sequence
>>>>> and LingeredApp should end normally.
>>>>>
>>>>>    Webrev: http://cr.openjdk.java.net/~gadams/8203364/webrev/
>>>>>    Issue: https://bugs.openjdk.java.net/browse/JDK-8203364
>>>>
>>>>
>>>>
>>>
>>
>>
>

[prev in list] [next in list] [prev in thread] [next in thread]