[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR: JDK-8221694: jstatLineCounts1 needs to be NaN resilient
From:       Jean Christophe Beyler <jcbeyler () google ! com>
Date:       2019-03-29 18:48:51
Message-ID: CAF9BGByfoqrruhYkiL7GpkP-veNxh-pRk-VCWruQvP0qR63sfA () mail ! gmail ! com
[Download RAW message or body]

Hi Gary,

Looks good to me :)
Jc

On Fri, Mar 29, 2019 at 11:14 AM Gary Adams <gary.adams@oracle.com> wrote:

> With additional testing of jdk/sun/tools The problem seen previously with
> lineCounts3 and lineCounts4 has begun to appear in lineCounts1. To complete
> the set this changset will also invlude the same fix for lineCounts2.
> e.g. allow floating point or NaN dash ("-") in the metaspace column
>       ([0-9]+\.[0-9]+|-)
>
>    Issue: https://bugs.openjdk.java.net/browse/JDK-8221694
>
>
>
> diff --git a/test/jdk/sun/tools/jstat/lineCounts1.awk
> b/test/jdk/sun/tools/jstat/lineCounts1.awk
> --- a/test/jdk/sun/tools/jstat/lineCounts1.awk
> +++ b/test/jdk/sun/tools/jstat/lineCounts1.awk
> @@ -18,7 +18,7 @@
>           headerlines++;
>       }
>
> -/^[ ]*[0-9]+\.[0-9]+[ ]*[0-9]+\.[0-9]+[ ]*[0-9]+\.[0-9]+[
> ]*[0-9]+\.[0-9]+[ ]*[0-9]+\.[0-9]+[ ]*([0-9]+\.[0-9]+)|-[ ]*[0-9]+[
> ]*[0-9]+\.[0-9]+[ ]*[0-9]+[ ]*[0-9]+\.[0-9]+[ ]*[0-9]+[
> ]*[0-9]+\.[0-9]+[ ]*[0-9]+\.[0-9]+$/    {
> +/^[ ]*[0-9]+\.[0-9]+[ ]*[0-9]+\.[0-9]+[ ]*[0-9]+\.[0-9]+[
> ]*[0-9]+\.[0-9]+[ ]*([0-9]+\.[0-9]+|-)[ ]*([0-9]+\.[0-9]+|-)[ ]*[0-9]+[
> ]*[0-9]+\.[0-9]+[ ]*[0-9]+[ ]*[0-9]+\.[0-9]+[ ]*[0-9]+[
> ]*[0-9]+\.[0-9]+[ ]*[0-9]+\.[0-9]+$/    {
>           datalines++;
>       }
>
> diff --git a/test/jdk/sun/tools/jstat/lineCounts2.awk
> b/test/jdk/sun/tools/jstat/lineCounts2.awk
> --- a/test/jdk/sun/tools/jstat/lineCounts2.awk
> +++ b/test/jdk/sun/tools/jstat/lineCounts2.awk
> @@ -14,7 +14,7 @@
>           headerlines++;
>       }
>
> -/^[ ]*[0-9]+\.[0-9]+[ ]*[0-9]+\.[0-9]+[ ]*[0-9]+\.[0-9]+[
> ]*[0-9]+\.[0-9]+[ ]*[0-9]+\.[0-9]+[ ]*([0-9]+\.[0-9]+)|-[ ]*[0-9]+[
> ]*[0-9]+\.[0-9]+[ ]*[0-9]+[ ]*[0-9]+\.[0-9]+[ ]*[0-9]+[
> ]*[0-9]+\.[0-9]+[ ]*[0-9]+\.[0-9]+$/    {
> +/^[ ]*[0-9]+\.[0-9]+[ ]*[0-9]+\.[0-9]+[ ]*[0-9]+\.[0-9]+[
> ]*[0-9]+\.[0-9]+[ ]*([0-9]+\.[0-9]+|-)[ ]*([0-9]+\.[0-9]+|-)[ ]*[0-9]+[
> ]*[0-9]+\.[0-9]+[ ]*[0-9]+[ ]*[0-9]+\.[0-9]+[ ]*[0-9]+[
> ]*[0-9]+\.[0-9]+[ ]*[0-9]+\.[0-9]+$/    {
>           datalines++;
>       }
>


-- 

Thanks,
Jc

[Attachment #3 (text/html)]

<div dir="ltr">Hi Gary,<div><br></div><div>Looks good to me \
:)</div><div>Jc</div></div><br><div class="gmail_quote"><div dir="ltr" \
class="gmail_attr">On Fri, Mar 29, 2019 at 11:14 AM Gary Adams &lt;<a \
href="mailto:gary.adams@oracle.com">gary.adams@oracle.com</a>&gt; \
wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">With additional \
testing of jdk/sun/tools The problem seen previously with<br> lineCounts3 and \
lineCounts4 has begun to appear in lineCounts1. To complete<br> the set this changset \
will also invlude the same fix for lineCounts2.<br> e.g. allow floating point or NaN \
dash (&quot;-&quot;) in the metaspace column<br>  ([0-9]+\.[0-9]+|-)<br>
<br>
     Issue: <a href="https://bugs.openjdk.java.net/browse/JDK-8221694" \
rel="noreferrer" target="_blank">https://bugs.openjdk.java.net/browse/JDK-8221694</a><br>
 <br>
<br>
<br>
diff --git a/test/jdk/sun/tools/jstat/lineCounts1.awk <br>
b/test/jdk/sun/tools/jstat/lineCounts1.awk<br>
--- a/test/jdk/sun/tools/jstat/lineCounts1.awk<br>
+++ b/test/jdk/sun/tools/jstat/lineCounts1.awk<br>
@@ -18,7 +18,7 @@<br>
               headerlines++;<br>
         }<br>
<br>
-/^[ ]*[0-9]+\.[0-9]+[ ]*[0-9]+\.[0-9]+[ ]*[0-9]+\.[0-9]+[ <br>
]*[0-9]+\.[0-9]+[ ]*[0-9]+\.[0-9]+[ ]*([0-9]+\.[0-9]+)|-[ ]*[0-9]+[ <br>
]*[0-9]+\.[0-9]+[ ]*[0-9]+[ ]*[0-9]+\.[0-9]+[ ]*[0-9]+[ <br>
]*[0-9]+\.[0-9]+[ ]*[0-9]+\.[0-9]+$/      {<br>
+/^[ ]*[0-9]+\.[0-9]+[ ]*[0-9]+\.[0-9]+[ ]*[0-9]+\.[0-9]+[ <br>
]*[0-9]+\.[0-9]+[ ]*([0-9]+\.[0-9]+|-)[ ]*([0-9]+\.[0-9]+|-)[ ]*[0-9]+[ <br>
]*[0-9]+\.[0-9]+[ ]*[0-9]+[ ]*[0-9]+\.[0-9]+[ ]*[0-9]+[ <br>
]*[0-9]+\.[0-9]+[ ]*[0-9]+\.[0-9]+$/      {<br>
               datalines++;<br>
         }<br>
<br>
diff --git a/test/jdk/sun/tools/jstat/lineCounts2.awk <br>
b/test/jdk/sun/tools/jstat/lineCounts2.awk<br>
--- a/test/jdk/sun/tools/jstat/lineCounts2.awk<br>
+++ b/test/jdk/sun/tools/jstat/lineCounts2.awk<br>
@@ -14,7 +14,7 @@<br>
               headerlines++;<br>
         }<br>
<br>
-/^[ ]*[0-9]+\.[0-9]+[ ]*[0-9]+\.[0-9]+[ ]*[0-9]+\.[0-9]+[ <br>
]*[0-9]+\.[0-9]+[ ]*[0-9]+\.[0-9]+[ ]*([0-9]+\.[0-9]+)|-[ ]*[0-9]+[ <br>
]*[0-9]+\.[0-9]+[ ]*[0-9]+[ ]*[0-9]+\.[0-9]+[ ]*[0-9]+[ <br>
]*[0-9]+\.[0-9]+[ ]*[0-9]+\.[0-9]+$/      {<br>
+/^[ ]*[0-9]+\.[0-9]+[ ]*[0-9]+\.[0-9]+[ ]*[0-9]+\.[0-9]+[ <br>
]*[0-9]+\.[0-9]+[ ]*([0-9]+\.[0-9]+|-)[ ]*([0-9]+\.[0-9]+|-)[ ]*[0-9]+[ <br>
]*[0-9]+\.[0-9]+[ ]*[0-9]+[ ]*[0-9]+\.[0-9]+[ ]*[0-9]+[ <br>
]*[0-9]+\.[0-9]+[ ]*[0-9]+\.[0-9]+$/      {<br>
               datalines++;<br>
         }<br>
</blockquote></div><br clear="all"><div><br></div>-- <br><div dir="ltr" \
class="gmail_signature"><div \
dir="ltr"><div><br></div>Thanks,<div>Jc</div></div></div>



[prev in list] [next in list] [prev in thread] [next in thread]