[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    RE: RFR(XS): 8220707: [TESTBUG] serviceability/sa/TestHeapDumpForLargeArray.java fails with jtreg
From:       "Langer, Christoph" <christoph.langer () sap ! com>
Date:       2019-03-29 9:10:29
Message-ID: HE1PR0201MB22668A0763247A238F8D73298A5A0 () HE1PR0201MB2266 ! eurprd02 ! prod ! outlook ! com
[Download RAW message or body]

Hi Nick,

this is great, thank you for fixing this, +1😊

We ran into the same problem when we were trying to set different default Xmx options \
in our test infrastructure for small machines where the default heaps would be too \
small by default. My colleague Arno had the very same patch on his ToDo list already.

Best regards
Christoph

> -----Original Message-----
> From: serviceability-dev <serviceability-dev-bounces@openjdk.java.net> On
> Behalf Of Nick Gasson
> Sent: Mittwoch, 27. März 2019 04:20
> To: Sharath Ballal <sharath.ballal@oracle.com>; serviceability-
> dev@openjdk.java.net
> Subject: Re: RFR(XS): 8220707: [TESTBUG]
> serviceability/sa/TestHeapDumpForLargeArray.java fails with jtreg -
> vmoption:-Xmx < 8g
> 
> Hi,
> 
> Could I get another reviewer to look at this please?
> 
> Thanks!
> Nick
> 
> 
> On 18/03/2019 18:04, Nick Gasson wrote:
> > Hi Sharath,
> > 
> > On 15/03/2019 23:32, Sharath Ballal wrote:
> > > 
> > > Fix looks good.   How have you tested it ?
> > 
> > I ran the test using the "make test" target with and without
> > JTREG="MAX_MEM=512m" on AArch64 and x86. Previously it would fail
> with
> > that argument.
> > 
> > Thanks,
> > Nick


[prev in list] [next in list] [prev in thread] [next in thread]