[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-serviceability-dev
Subject: Re: RFR: 8146986: JDI: Signature lookups for unprepared classes can take a long time
From: "serguei.spitsyn () oracle ! com" <serguei ! spitsyn () oracle ! com>
Date: 2019-03-26 2:21:51
Message-ID: b8c9488d-05bc-e38d-6eda-cc10882f7d14 () oracle ! com
[Download RAW message or body]
<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<div class="moz-cite-prefix">Hi Egor,<br>
<br>
Pushed.<br>
<br>
Thanks,<br>
Serguei<br>
<br>
<br>
On 3/23/19 22:41, Egor Ushakov wrote:<br>
</div>
<blockquote type="cite"
cite="mid:5d435195-a2f2-3ebf-4ff9-7ae971384770@jetbrains.com">
<p>Yes, the latest fix passed these test.</p>
<p>Serguei, can you please sponsor the fix?<br>
</p>
<div class="moz-cite-prefix">On 22-Mar-19 23:25, <a
class="moz-txt-link-abbreviated"
href="mailto:serguei.spitsyn@oracle.com"
moz-do-not-send="true">serguei.spitsyn@oracle.com</a> wrote:<br>
</div>
<blockquote type="cite"
cite="mid:2b701c72-5380-b110-bf49-53f851051f08@oracle.com">
<div class="moz-cite-prefix">Hi Egor,<br>
<br>
It looks Okay to me.<br>
<br>
Just want to make sure all important JDI tests are run.<br>
There are two major JDI test suites:<br>
jdk/com/sun/jdi and hotspot/jtreg/vmTestbase/nsk/jdi<br>
<br>
Thanks,<br>
Serguei<br>
<br>
<br>
On 3/22/19 11:51, Egor Ushakov wrote:<br>
</div>
<blockquote type="cite"
cite="mid:77f28581-16fa-38ec-ed8d-fd37c8b6f1ce@jetbrains.com">
<p>Thanks for your comments,</p>
some jdi test were really failing :(<br>
As we switched from TreeSet to HashSet we have to explicitly
set signature now. <br>
<p>Please review the updated fix: <a
href="http://cr.openjdk.java.net/~eushakov/8146986/webrev.01/"
moz-do-not-send="true">http://cr.openjdk.java.net/~eushakov/8146986/webrev.01/</a></p>
<div class="moz-cite-prefix">On 21-Mar-19 22:39, Jean
Christophe Beyler wrote:<br>
</div>
<blockquote type="cite"
cite="mid:CAF9BGBwq4GryqeMvhgiRGbaN3-X9ap9DM4CQMj2pDBj4fuqJkA@mail.gmail.com">
<div dir="ltr">Hi Egor,
<div><br>
</div>
<div>Looks good to me as well, nit would be that the rest
of the file does not add a new-line for a else if:</div>
<div><br>
</div>
<div>if () {</div>
<div>} else if () {</div>
<div>}</div>
<div><br>
</div>
<div>instead of what you added:</div>
<div>
<div><br class="gmail-Apple-interchange-newline">
if () {</div>
<div>}</div>
<div>else if () {</div>
<div>}</div>
</div>
<div><br>
</div>
<div>(Not a Reviewer)</div>
<div><br>
</div>
<div>Thanks,</div>
<div>Jc</div>
<div><br>
</div>
</div>
<br>
<div class="gmail_quote">
<div dir="ltr" class="gmail_attr">On Thu, Mar 21, 2019 at
11:31 AM <a href="mailto:serguei.spitsyn@oracle.com"
moz-do-not-send="true">serguei.spitsyn@oracle.com</a>
<<a href="mailto:serguei.spitsyn@oracle.com"
moz-do-not-send="true">serguei.spitsyn@oracle.com</a>>
wrote:<br>
</div>
<blockquote class="gmail_quote">Hi Egor,<br>
<br>
The fix looks good to me.<br>
<br>
Thank you for taking care about it!<br>
I've targeted this enhancement to 13.<br>
<br>
How do you test it?<br>
It would be safe to run all JDI tests to make sure no
new timeouts are <br>
observed.<br>
<br>
Thanks,<br>
Serguei<br>
<br>
<br>
On 3/21/19 10:19, Egor Ushakov wrote:<br>
> Hi all, please review the fix<br>
><br>
> it disables caching for types when signature is not
provided as <br>
> described in the bug (this is one of the proposed
solutions in the bug).<br>
><br>
> <a
href="https://bugs.openjdk.java.net/browse/JDK-8146986"
rel="noreferrer" target="_blank"
moz-do-not-send="true">https://bugs.openjdk.java.net/browse/JDK-8146986</a><br>
> <a
href="http://cr.openjdk.java.net/~eushakov/8146986/webrev.00/"
rel="noreferrer" target="_blank"
moz-do-not-send="true">http://cr.openjdk.java.net/~eushakov/8146986/webrev.00/</a><br>
><br>
> Thanks!<br>
><br>
<br>
</blockquote>
</div>
<br>
<div><br>
</div>
-- <br>
<div dir="ltr" class="gmail_signature">
<div dir="ltr">
<div><br>
</div>
Thanks,
<div>Jc</div>
</div>
</div>
</blockquote>
<pre class="moz-signature" cols="72">--
Egor Ushakov
Software Developer
JetBrains
<a class="moz-txt-link-freetext" href="http://www.jetbrains.com" \
moz-do-not-send="true">http://www.jetbrains.com</a> The Drive to Develop</pre>
</blockquote>
<br>
</blockquote>
<pre class="moz-signature" cols="72">--
Egor Ushakov
Software Developer
JetBrains
<a class="moz-txt-link-freetext" href="http://www.jetbrains.com" \
moz-do-not-send="true">http://www.jetbrains.com</a> The Drive to Develop</pre>
</blockquote>
<br>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic