[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-serviceability-dev
Subject: Re: JDK-8221164: jstatLineCounts tests need to be more resilient for NaN outputs
From: "Hohensee, Paul" <hohensee () amazon ! com>
Date: 2019-03-23 17:08:04
Message-ID: 0BE3409B-A61B-478C-9D52-863579DAE453 () amazon ! com
[Download RAW message or body]
[Attachment #2 (text/plain)]
+1.
Paul
From: serviceability-dev <serviceability-dev-bounces@openjdk.java.net> on behalf of \
Chris Plummer <chris.plummer@oracle.com>
Date: Friday, March 22, 2019 at 7:38 PM
To: "gary.adams@oracle.com" <gary.adams@oracle.com>, OpenJDK Serviceability \
<serviceability-dev@openjdk.java.net>
Subject: Re: RFR: JDK-8221164: jstatLineCounts tests need to be more resilient for \
NaN outputs
Ok. The fix looks good to me.
thanks,
Chris
On 3/22/19 4:01 PM, gary.adams@oracle.com<mailto:gary.adams@oracle.com> wrote:
Yes. I just made it clearer.
On 3/22/19 3:29 PM, Chris Plummer wrote:
Hi Gary,
It looks like there was already "-" support for the CCS column. Was it not working, \
or did you add the parens just to make it clearer to the reader what it is matching \
on?
thanks,
Chris
On 3/22/19 1:18 AM, gary.adams@oracle.com<mailto:gary.adams@oracle.com> wrote:
The M and CCS columns from jstat output can present a dash("-")
for NaN values, such as :
----------System.out:(13/1261)----------
S0 S1 E O M CCS YGC YGCT FGC FGCT CGC CGCT \
GCT
0.00 0.00 0.00 0.00 - - 0 0.000 0 0.000 0 \
0.000 0.000
0.00 0.00 0.00 0.00 - - 0 0.000 0 0.000 0 \
0.000 0.000
0.00 0.00 0.00 0.00 - - 0 0.000 0 0.000 0 \
0.000 0.000
0.00 0.00 0.00 0.00 - - 0 0.000 0 0.000 0 \
0.000 0.000
0.00 0.00 0.00 0.00 - - 0 0.000 0 0.000 0 \
0.000 0.000
0.00 0.00 0.00 0.00 - - 0 0.000 0 0.000 0 \
0.000 0.000
0.00 0.00 0.00 0.00 - 28.19 1 0.571 0 0.000 0 \
0.000 0.571
0.00 100.00 0.00 14.85 31.29 28.19 1 0.571 0 0.000 0 \
0.000 0.571
0.00 100.00 0.00 14.85 31.29 28.19 1 0.571 0 0.000 0 \
0.000 0.571
0.00 100.00 0.00 14.85 31.29 28.19 1 0.571 0 0.000 0 \
0.000 0.571
This proposed fix updates the awk scripts which are checking output lines.
For the M and CCS columns, allow either a floating point value or a dash.
e.g. "([0-9]+\.[0-9]+|-)"
Webrev: http://cr.openjdk.java.net/~gadams/8221164/webrev/<http://cr.openjdk.java.net/%7Egadams/8221164/webrev/>
Issue: https://bugs.openjdk.java.net/browse/JDK-8221164
[Attachment #3 (text/html)]
<html xmlns:o="urn:schemas-microsoft-com:office:office" \
xmlns:w="urn:schemas-microsoft-com:office:word" \
xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" \
xmlns="http://www.w3.org/TR/REC-html40"> <head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Consolas;
panose-1:2 11 6 9 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
pre
{mso-style-priority:99;
mso-style-link:"HTML Preformatted Char";
margin:0in;
margin-bottom:.0001pt;
font-size:10.0pt;
font-family:"Courier New";}
p.msonormal0, li.msonormal0, div.msonormal0
{mso-style-name:msonormal;
mso-margin-top-alt:auto;
margin-right:0in;
mso-margin-bottom-alt:auto;
margin-left:0in;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
span.HTMLPreformattedChar
{mso-style-name:"HTML Preformatted Char";
mso-style-priority:99;
mso-style-link:"HTML Preformatted";
font-family:"Consolas",serif;}
span.EmailStyle21
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style>
</head>
<body lang="EN-US" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal">+1.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Paul<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span style="font-size:12.0pt;color:black">From: \
</span></b><span style="font-size:12.0pt;color:black">serviceability-dev \
<serviceability-dev-bounces@openjdk.java.net> on behalf of Chris Plummer \
<chris.plummer@oracle.com><br> <b>Date: </b>Friday, March 22, 2019 at 7:38 \
PM<br> <b>To: </b>"gary.adams@oracle.com" <gary.adams@oracle.com>, \
OpenJDK Serviceability <serviceability-dev@openjdk.java.net><br> <b>Subject: \
</b>Re: RFR: JDK-8221164: jstatLineCounts tests need to be more resilient for NaN \
outputs<o:p></o:p></span></p> </div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">Ok. The fix looks good to me.<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">thanks,<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">Chris<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">On 3/22/19 4:01 PM, <a \
href="mailto:gary.adams@oracle.com">gary.adams@oracle.com</a> wrote:<o:p></o:p></p> \
</div> <blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<div>
<p class="MsoNormal">Yes. I just made it clearer.<br>
<br>
On 3/22/19 3:29 PM, Chris Plummer wrote:<o:p></o:p></p>
</div>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<div>
<p class="MsoNormal">Hi Gary,<br>
<br>
It looks like there was already "-" support for the CCS column. Was it not \
working, or did you add the parens just to make it clearer to the reader what it is \
matching on?<br> <br>
thanks,<br>
<br>
Chris<br>
<br>
On 3/22/19 1:18 AM, <a href="mailto:gary.adams@oracle.com">gary.adams@oracle.com</a> \
wrote:<o:p></o:p></p> </div>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<p class="MsoNormal" style="margin-bottom:12.0pt">The M and CCS columns from jstat \
output can present a dash("-")<br> for NaN values, such as :<o:p></o:p></p>
<pre>----------System.out:(13/1261)----------<o:p></o:p></pre>
<pre> S0 S1 \
E O \
M CCS YGC \
YGCT FGC FGCT \
CGC CGCT GCT <o:p></o:p></pre> \
<pre> 0.00 0.00 0.00 \
0.00 - \
- 0 0.000 \
0 0.000 0 \
0.000 0.000<o:p></o:p></pre> <pre> 0.00 \
0.00 0.00 0.00 \
- - 0 \
0.000 0 \
0.000 0 0.000 \
0.000<o:p></o:p></pre> <pre> 0.00 0.00 0.00 \
0.00 - \
- 0 0.000 \
0 0.000 0 \
0.000 0.000<o:p></o:p></pre> <pre> 0.00 \
0.00 0.00 0.00 \
- - 0 \
0.000 0 0.000 \
0 0.000 0.000<o:p></o:p></pre> <pre> \
0.00 0.00 0.00 0.00 \
- - 0 \
0.000 0 0.000 \
0 0.000 0.000<o:p></o:p></pre> <pre> \
0.00 0.00 0.00 0.00 \
- - 0 \
0.000 0 0.000 \
0 0.000 0.000<o:p></o:p></pre> <pre> \
0.00 0.00 0.00 0.00 \
- 28.19 1 \
0.571 0 0.000 \
0 0.000 0.571<o:p></o:p></pre> <pre> 0.00 \
100.00 0.00 14.85 31.29 \
28.19 1 0.571 \
0 0.000 0 \
0.000 0.571<o:p></o:p></pre> <pre> 0.00 100.00 \
0.00 14.85 31.29 28.19 \
1 0.571 0 \
0.000 0 0.000 \
0.571<o:p></o:p></pre> <pre> 0.00 100.00 0.00 14.85 \
31.29 28.19 1 \
0.571 0 0.000 \
0 0.000 0.571<o:p></o:p></pre> <p \
class="MsoNormal"><br> This proposed fix updates the awk scripts which are checking \
output lines.<br> For the M and CCS columns, allow either a floating point value or a \
dash.<br> e.g. "([0-9]+\.[0-9]+|-)" <br>
<br>
Webrev: <a href="http://cr.openjdk.java.net/%7Egadams/8221164/webrev/">http://cr.openjdk.java.net/~gadams/8221164/webrev/</a><br>
Issue: <a \
href="https://bugs.openjdk.java.net/browse/JDK-8221164">https://bugs.openjdk.java.net/browse/JDK-8221164</a><o:p></o:p></p>
</blockquote>
<p><o:p> </o:p></p>
</blockquote>
<p class="MsoNormal"><o:p> </o:p></p>
</blockquote>
<p><o:p> </o:p></p>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic