[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-serviceability-dev
Subject: Re: RFR: JDK-8221164: jstatLineCounts tests need to be more resilient for NaN outputs
From: Chris Plummer <chris.plummer () oracle ! com>
Date: 2019-03-23 2:37:29
Message-ID: 20e329d7-7105-c5fb-3cb8-de05f4d98155 () oracle ! com
[Download RAW message or body]
<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<div class="moz-cite-prefix">Ok. The fix looks good to me.</div>
<div class="moz-cite-prefix"><br>
</div>
<div class="moz-cite-prefix">thanks,</div>
<div class="moz-cite-prefix"><br>
</div>
<div class="moz-cite-prefix">Chris<br>
</div>
<div class="moz-cite-prefix"><br>
</div>
<div class="moz-cite-prefix">On 3/22/19 4:01 PM,
<a class="moz-txt-link-abbreviated" \
href="mailto:gary.adams@oracle.com">gary.adams@oracle.com</a> wrote:<br> </div>
<blockquote type="cite"
cite="mid:6fa60048-5b22-0ad3-6717-251e39d9ecc1@oracle.com">
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
<div class="moz-cite-prefix">Yes. I just made it clearer.<br>
<br>
On 3/22/19 3:29 PM, Chris Plummer wrote:<br>
</div>
<blockquote type="cite"
cite="mid:4f453747-6d09-9ad9-22a1-62f3f1e0d9c8@oracle.com">
<meta http-equiv="Content-Type" content="text/html;
charset=UTF-8">
<div class="moz-cite-prefix">Hi Gary,<br>
<br>
It looks like there was already "-" support for the CCS
column. Was it not working, or did you add the parens just to
make it clearer to the reader what it is matching on?<br>
<br>
thanks,<br>
<br>
Chris<br>
<br>
On 3/22/19 1:18 AM, <a class="moz-txt-link-abbreviated"
href="mailto:gary.adams@oracle.com" \
moz-do-not-send="true">gary.adams@oracle.com</a> wrote:<br>
</div>
<blockquote type="cite"
cite="mid:d6895fd5-4b75-7880-1085-3be8ae7bc7a4@oracle.com">
<meta http-equiv="content-type" content="text/html;
charset=UTF-8">
The M and CCS columns from jstat output can present a
dash("-")<br>
for NaN values, such as :<br>
<br>
<pre>----------System.out:(13/1261)----------
S0 S1 E O M CCS YGC YGCT FGC FGCT CGC CGCT \
GCT 0.00 0.00 0.00 0.00 - - 0 0.000 0 0.000 0 \
0.000 0.000 0.00 0.00 0.00 0.00 - - 0 0.000 0 \
0.000 0 0.000 0.000 0.00 0.00 0.00 0.00 - - 0 \
0.000 0 0.000 0 0.000 0.000 0.00 0.00 0.00 0.00 - - \
0 0.000 0 0.000 0 0.000 0.000 0.00 0.00 0.00 0.00 - \
- 0 0.000 0 0.000 0 0.000 0.000 0.00 0.00 0.00 0.00 \
- - 0 0.000 0 0.000 0 0.000 0.000 0.00 0.00 0.00 \
0.00 - 28.19 1 0.571 0 0.000 0 0.000 0.571 0.00 \
100.00 0.00 14.85 31.29 28.19 1 0.571 0 0.000 0 0.000 \
0.571 0.00 100.00 0.00 14.85 31.29 28.19 1 0.571 0 0.000 0 \
0.000 0.571 0.00 100.00 0.00 14.85 31.29 28.19 1 0.571 0 \
0.000 0 0.000 0.571</pre> <br>
This proposed fix updates the awk scripts which are checking
output lines.<br>
For the M and CCS columns, allow either a floating point value
or a dash.<br>
e.g. "([0-9]+\.[0-9]+|-)" <br>
<br>
Webrev: <a class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Egadams/8221164/webrev/"
moz-do-not-send="true">http://cr.openjdk.java.net/~gadams/8221164/webrev/</a><br>
Issue: <a class="moz-txt-link-freetext"
href="https://bugs.openjdk.java.net/browse/JDK-8221164"
moz-do-not-send="true">https://bugs.openjdk.java.net/browse/JDK-8221164</a><br>
</blockquote>
<p><br>
</p>
</blockquote>
<br>
</blockquote>
<p><br>
</p>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic