[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR: JDK-8214756: SA should ignore archived java heap objects that are not in use
From:       Jiangli Zhou <jianglizhou () google ! com>
Date:       2019-02-24 18:29:33
Message-ID: CALrW1jx6k7Gd39_L_1uvcGipFjDXNCwbgkP8vShfMsZ0mv9-Ng () mail ! gmail ! com
[Download RAW message or body]

On Sat, Feb 23, 2019 at 9:01 PM Jini George <jini.george@oracle.com> wrote:

> Thank you very much, Jiangli! Yes, I did test
> open/test/hotspot/jtreg/serviceability/sa/TestHeapDumpForLargeArray.java
> after applying the changes from:
>
> http://cr.openjdk.java.net/~redestad/8214712/jdk.00/
>
> and it passed after this change.
>

Thanks!

Jiangli


>
> Thanks,
> Jini.
>
> On 2/24/2019 9:38 AM, Jiangli Zhou wrote:
> > Hi Jini,
> >
> > The change reflects the states of archived java objects and klass
> > metadata properly at runtime and looks good to me.
> >
> > You might have already done so, for additional testing try running
> > open/test/hotspot/jtreg/serviceability/sa/TestHeapDumpForLargeArray.java
> > with the planned changes for JDK-8214712
> > <https://bugs.openjdk.java.net/browse/JDK-8214712>.
> >
> > Thanks,
> > Jiangli
> >
> > On Sat, Feb 23, 2019 at 10:00 AM Jini George <jini.george@oracle.com
> > <mailto:jini.george@oracle.com>> wrote:
> >
> >     Requesting reviews for a very small change to fix:
> >
> >     https://bugs.openjdk.java.net/browse/JDK-8214756
> >
> >     Webrev:
> http://cr.openjdk.java.net/~jgeorge/8214756/webrev.00/index.html
> >
> >     The proposed change is to ignore objects whose associated classes are
> >     unloaded while walking the heap to create a heapdump in SA.
> >
> >     Thanks,
> >     Jini.
> >
>

[Attachment #3 (text/html)]

<div dir="ltr"><div dir="ltr"><br></div><br><div class="gmail_quote"><div dir="ltr" \
class="gmail_attr">On Sat, Feb 23, 2019 at 9:01 PM Jini George &lt;<a \
href="mailto:jini.george@oracle.com">jini.george@oracle.com</a>&gt; \
wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px \
0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Thank you very much, \
Jiangli! Yes, I did test <br> \
open/test/hotspot/jtreg/serviceability/sa/TestHeapDumpForLargeArray.java <br> after \
applying the changes from:<br> <br>
<a href="http://cr.openjdk.java.net/~redestad/8214712/jdk.00/" rel="noreferrer" \
target="_blank">http://cr.openjdk.java.net/~redestad/8214712/jdk.00/</a><br> <br>
and it passed after this \
change.<br></blockquote><div><br></div><div>Thanks!</div><div><br></div><div>Jiangli</div><div> \
</div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px \
solid rgb(204,204,204);padding-left:1ex"> <br>
Thanks,<br>
Jini.<br>
<br>
On 2/24/2019 9:38 AM, Jiangli Zhou wrote:<br>
&gt; Hi Jini,<br>
&gt; <br>
&gt; The change reflects the states of archived java objects and klass <br>
&gt; metadata properly at runtime and looks good to me.<br>
&gt; <br>
&gt; You might have already done so, for additional testing try running <br>
&gt; open/test/hotspot/jtreg/serviceability/sa/TestHeapDumpForLargeArray.java <br>
&gt; with the planned changes for JDK-8214712 <br>
&gt; &lt;<a href="https://bugs.openjdk.java.net/browse/JDK-8214712" rel="noreferrer" \
target="_blank">https://bugs.openjdk.java.net/browse/JDK-8214712</a>&gt;.<br> &gt; \
<br> &gt; Thanks,<br>
&gt; Jiangli<br>
&gt; <br>
&gt; On Sat, Feb 23, 2019 at 10:00 AM Jini George &lt;<a \
href="mailto:jini.george@oracle.com" target="_blank">jini.george@oracle.com</a> <br> \
&gt; &lt;mailto:<a href="mailto:jini.george@oracle.com" \
target="_blank">jini.george@oracle.com</a>&gt;&gt; wrote:<br> &gt; <br>
&gt;        Requesting reviews for a very small change to fix:<br>
&gt; <br>
&gt;        <a href="https://bugs.openjdk.java.net/browse/JDK-8214756" \
rel="noreferrer" target="_blank">https://bugs.openjdk.java.net/browse/JDK-8214756</a><br>
 &gt; <br>
&gt;        Webrev: <a \
href="http://cr.openjdk.java.net/~jgeorge/8214756/webrev.00/index.html" \
rel="noreferrer" target="_blank">http://cr.openjdk.java.net/~jgeorge/8214756/webrev.00/index.html</a><br>
 &gt; <br>
&gt;        The proposed change is to ignore objects whose associated classes are<br>
&gt;        unloaded while walking the heap to create a heapdump in SA.<br>
&gt; <br>
&gt;        Thanks,<br>
&gt;        Jini.<br>
&gt; <br>
</blockquote></div></div>



[prev in list] [next in list] [prev in thread] [next in thread]