[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR(XS): 8218947: jdb threads command should print threadID in decimal, not hex
From:       Chris Plummer <chris.plummer () oracle ! com>
Date:       2019-02-19 6:24:02
Message-ID: 723f268d-5709-0031-bd27-05f903094079 () oracle ! com
[Download RAW message or body]

On 2/18/19 9:17 PM, David Holmes wrote:
> Hi Chris,
>
> On 16/02/2019 11:08 am, Chris Plummer wrote:
>> Hi,
>>
>> Please review the updated webrev:
>>
>> http://cr.openjdk.java.net/~cjplummer/8218947/webrev.02/
>> https://bugs.openjdk.java.net/browse/JDK-8218947
>
> Seems fine.
>
>> I removed "hex" from "object description and hex id" and removed the 
>> java.lang. prefix from java.lang.Long references. There was no need 
>> to update the man page since it no longer references the "threads" 
>> command. The entire "Basic jdb Commands" section is gone.
>>
>> Also, it turns out one test was failing. Not sure how I missed it. 
>> I've been sitting on this change for months and never noticed it 
>> before. Maybe I didn't run the right set of tests.
>>
>> Anyway, the test (somewhat erroneously) searches the entire output 
>> line for the first thing that looks like a hex number, and assumes it 
>> is the thread id. If there was something that looked like a hex 
>> number in the class name, it would fail. I changed it to grab the 
>> first token after the classname.
>
> !           * Note we can't match on DEBUGGEE_THREAD because it includes a 
> $, which Pattern
> !           * uses to match the end of a line.
>
> You can escape the $ to get around that problem. But it suffices to 
> check for MyThread anyway.

That gets a little bit ugly. Pattern would require that I use "\\$" in 
order for the pattern string to actually contain an escaped $, but then 
the classname will no longer match. So that means I would need two 
different versions of DEBUGGEE_THREAD, one for the actual classname 
without the escaped $, and one for the pattern with the escaped $.

Chris

>
> Thanks,
> David
> -----
>
>> BTW, I also learned that in nsk/share/jdb/Jdb.java there is a 
>> getThreadIds() method that this test uses (along with about a dozen 
>> other tests). It returns a String[] containing all the thread ids. It 
>> finds the thread ID in a way similar to what I did. It first skips 
>> the class name and then grabs everything up to the first space (my 
>> code goes up to the first whitespace character).
>>
>> thanks,
>>
>> Chris
>>
>> On 2/13/19 7:37 PM, Chris Plummer wrote:
>>> Hi,
>>>
>>> Please review the following:
>>>
>>> http://cr.openjdk.java.net/~cjplummer/8218947/webrev
>>> https://bugs.openjdk.java.net/browse/JDK-8218947
>>>
>>> Tested by running the following on all supported platforms:
>>>
>>> open/test/hotspot/jtreg/vmTestbase/nsk/jdb
>>> open/test/jdk/com/sun/jdi
>>>
>>> thanks,
>>>
>>> Chris
>>
>>


[prev in list] [next in list] [prev in thread] [next in thread]