[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR: JDK-8211343: nsk_jvmti_parseoptions should handle multiple suboptions
From:       Chris Plummer <chris.plummer () oracle ! com>
Date:       2018-12-31 21:25:34
Message-ID: 45b3cee6-0922-3f14-df73-91b2cea63bac () oracle ! com
[Download RAW message or body]

Ok.

Chris

On 12/31/18 12:30 PM, gary.adams@oracle.com wrote:
> The one test that failed is changed in this webrev.
>
> When it failed, it was the check in add_option
> that does not allow an "empty" option name.
>
>
> On 12/31/18 2:25 PM, Chris Plummer wrote:
>> Looks good. Are empty options strings still allowed after your changes?
>>
>> Chris
>>
>> On 12/31/18 10:06 AM, gary.adams@oracle.com wrote:
>>> Here's a revised webrev.
>>>
>>>    Webrev: 
>>> http://bussund0416.us.oracle.com/export/users/gradams/work/webrevs/8211343/webrev.01/
>>>
>>> Updates in this round of changes :
>>>    - replaced index() with strchr() to avoid platform dependent 
>>> issues with strings.h include
>>>    - removed NSK_JVMTI_OPTION_VAL_SEP
>>>    - removed temporary debugging print statements
>>>    - removed empty options string from SetNativeMethodPrefix001
>>>    - added free for temporary strdup buffer
>>>    - updated copyright for 2019
>>>
>>> On 12/21/18 1:52 PM, Gary Adams wrote:
>>>> Here is a first pass at a replacement parser for jvmti test options.
>>>>
>>>>    Webrev: http://cr.openjdk.java.net/~gadams/8211343/webrev.00/
>>>>    Issue: https://bugs.openjdk.java.net/browse/JDK-8211343
>>>>
>>>> Testing is in progress. Need to check out more platforms.
>>>> On local linux testing one jvmti test failed SetNativeMethodPrefix001
>>>> which passed an empty options string.
>>>> ...
>>>
>>>
>>
>>
>


[prev in list] [next in list] [prev in thread] [next in thread]