[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: [8u] RFR: 8059038: Create new launcher for SA tools
From:       Andrew Hughes <gnu.andrew () redhat ! com>
Date:       2018-12-19 17:04:13
Message-ID: CABi63P4-BxJgYvrP2BHebctP7ALuXsGD_T_Z=XRhd6ac3X1nTQ () mail ! gmail ! com
[Download RAW message or body]

On Wed, 19 Dec 2018 at 16:59, Severin Gehwolf <sgehwolf@redhat.com> wrote:
> 
> On Wed, 2018-12-19 at 16:56 +0000, Andrew Hughes wrote:
> > On Wed, 19 Dec 2018 at 12:15, Severin Gehwolf <sgehwolf@redhat.com> wrote:
> > > 
> > > On Wed, 2018-12-19 at 06:46 +0000, Andrew Hughes wrote:
> > > > On Thu, 13 Dec 2018 at 17:19, Severin Gehwolf <sgehwolf@redhat.com>
> > > > wrote:
> > > > > 
> > > > > On Thu, 2018-12-13 at 15:49 +0000, Andrew Hughes wrote:
> > > > > > Ok, I presume that's not a change you're also going to make in
> > > > > > OpenJDK 12?
> > > > > 
> > > > > Yes. I don't intend to change this in JDK 12. JDK 8 and JDK 9+ are
> > > > > not
> > > > > compatible in this regard. That's the case before and after this
> > > > > patch.
> > > > > 
> > > > > > I'm fine with them being linked by the same bug ID, as they
> > > > > > resolve the same
> > > > > > underlying issue, but this really needs to be clear in the
> > > > > > summary
> > > > > > text, as, to the
> > > > > > uninformed, they look like completely different patches.
> > > > > 
> > > > > OK will do. Can I consider this reviewed?
> > > > > 
> > > > > Thanks,
> > > > > Severin
> > > > > 
> > > > 
> > > > I'd like to see an updated webrev with a more detailed commit message
> > > > first.
> > > 
> > > Here you go:
> > > http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8059038/03/
> > > 
> > > Thanks,
> > > Severin
> > > 
> > 
> > I was hoping for a note on why it differs from 9 :-)
> 
> Any suggestions? Perhaps this?
> 
> "Summary: Create separate launchers for clhsdb and hsdb since JDK 8 uses separate \
> launchers for SA tools" 
> Thanks,
> Severin
> 

Sounds fine to me. I'm just trying to avoid others having the
confusion I had with the differences
between these.

Consider it reviewed with that message.

Thanks,
-- 
Andrew :)

Senior Free Java Software Engineer
Red Hat, Inc. (http://www.redhat.com)

Web Site: http://fuseyism.com
Twitter: https://twitter.com/gnu_andrew_java
PGP Key: ed25519/0xCFDA0F9B35964222 (hkp://keys.gnupg.net)
Fingerprint = 5132 579D D154 0ED2 3E04  C5A0 CFDA 0F9B 3596 4222


[prev in list] [next in list] [prev in thread] [next in thread]