[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-serviceability-dev
Subject: Re: RFR (L) 8214417: Add space after/before {} in vmTestbase/nsk/jvmti/[A-I] tests
From: JC Beyler <jcbeyler () google ! com>
Date: 2018-11-30 2:59:18
Message-ID: CAF9BGBx=wqhEBfbansn1XYje+a+Fi5SMLpziR9KQ4m4obVBt3w () mail ! gmail ! com
[Download RAW message or body]
Thanks all, and pushed :)
Jc
On Thu, Nov 29, 2018 at 6:45 PM <serguei.spitsyn@oracle.com> wrote:
> +1
>
> Thanks,
> Serguei
>
> On 11/29/18 4:44 PM, David Holmes wrote:
> > +1
> >
> > This is burning a lot of cycles. :)
> >
> > David
> >
> > On 30/11/2018 9:57 am, Alex Menkov wrote:
> >> Looks ok
> >>
> >> --alex
> >>
> >> On 11/29/2018 15:00, JC Beyler wrote:
> >>> Hi Alex,
> >>>
> >>> Yes that is true, I had initially only done the one-liner {} because
> >>> I was unsure about the cases above :-)
> >>>
> >>> Here is a webrev handling all cases for those 40 files:
> >>> Webrev: http://cr.openjdk.java.net/~jcbeyler/8214417/webrev.01/
> >>> Bug: https://bugs.openjdk.java.net/browse/JDK-8214417
> >>>
> >>> This was tested on my dev machine for all changed tests.
> >>>
> >>> Thanks!
> >>> Jc
> >>>
> >>> On Thu, Nov 29, 2018 at 2:26 PM Alex Menkov
> >>> <alexey.menkov@oracle.com <mailto:alexey.menkov@oracle.com>> wrote:
> >>>
> >>> Ok, guys, you win :)
> >>>
> >>> About the fix:
> >>> Looks like only 1-line initializers are fixed, so now we have mixed
> >>> style in some files like:
> >>>
> >>> ClearFieldAccessWatch/clrfldw001/clrfldw001.cpp (lines 52-53 are
> >>> not
> >>> updated):
> >>>
> >>> NULL },
> >>> 51 { "nsk/jvmti/ClearFieldAccessWatch/clrfldw001", "fld1",
> >>> "I", 1,
> >>> NULL },
> >>> 52 {"nsk/jvmti/ClearFieldAccessWatch/clrfldw001", "fld2",
> >>> 53 "Lnsk/jvmti/ClearFieldAccessWatch/clrfldw001a;", 0, NULL},
> >>> 54 { "nsk/jvmti/ClearFieldAccessWatch/clrfldw001a", "fld3",
> >>> "[I", 0,
> >>> NULL },
> >>>
> >>>
> >>> The same in ClearFieldModificationWatch/clrfmodw001/clrfmodw001.cpp
> >>> (lines 52-53):
> >>> 51 { "nsk/jvmti/ClearFieldModificationWatch/clrfmodw001",
> >>> "fld1",
> >>> "I", 1, NULL },
> >>> 52 {"nsk/jvmti/ClearFieldModificationWatch/clrfmodw001", "fld2",
> >>> 53 "Lnsk/jvmti/ClearFieldModificationWatch/clrfmodw001a;",
> >>> 0, NULL},
> >>> 54 { "nsk/jvmti/ClearFieldModificationWatch/clrfmodw001a",
> >>> "fld3",
> >>> "[I", 0, NULL },
> >>>
> >>>
> >>> GetClassSignature/getclsig006/getclsig006.cpp (44-51)
> >>> 43 { "getclsig006",
> >>> "Lnsk/jvmti/GetClassSignature/getclsig006;",
> >>> "NULL" },
> >>> 44 {"getclsig006b",
> >>> "Lnsk/jvmti/GetClassSignature/getclsig006b;",
> >>> 45 "<L:Ljava/lang/String;>Ljava/lang/Object;"},
> >>> 46 {"getclsig006c",
> >>> "Lnsk/jvmti/GetClassSignature/getclsig006c;",
> >>> 47
> >>> "<A:Ljava/lang/Object;B:Ljava/lang/Integer;>Ljava/lang/Object;"},
> >>>
> >>> (and others files)
> >>>
> >>> --alex
> >>>
> >>> On 11/29/2018 11:32, Daniel D. Daugherty wrote:
> >>> > I would also write code like what David shows... :-)
> >>> >
> >>> > Dan
> >>> >
> >>> >
> >>> > On 11/29/18 5:48 AM, David Holmes wrote:
> >>> >> I vote for the spaces around { and }
> >>> >>
> >>> >> I would write:
> >>> >>
> >>> >> int foo() { return 1; }
> >>> >>
> >>> >> so would also write:
> >>> >>
> >>> >> static jvmtiEvent testEvents[] = { JVMTI_EVENT_THREAD_START,
> >>> >> JVMTI_EVENT_THREAD_END };
> >>> >>
> >>> >> Cheers,
> >>> >> David
> >>> >>
> >>> >> On 29/11/2018 8:29 pm, serguei.spitsyn@oracle.com
> >>> <mailto:serguei.spitsyn@oracle.com> wrote:
> >>> >>> Hi Alex,
> >>> >>>
> >>> >>>
> >>> >>> On 11/28/18 18:18, Alex Menkov wrote:
> >>> >>>> Hi Serguei,
> >>> >>>>
> >>> >>>> On 11/28/2018 16:44, serguei.spitsyn@oracle.com
> >>> <mailto:serguei.spitsyn@oracle.com> wrote:
> >>> >>>>> There are some implicit rules, like unification and
> >>> consistency.
> >>> >>>>> We want a space or new line after '{' and before '}'.
> >>> >>>>
> >>> >>>> I believe this rule is about braces for code blocks (new line
> >>> after
> >>> >>>> "{", "}" on a separate line), but this are array
> >>> initializers.
> >>> >>>
> >>> >>> Array initializers are blocs as well.
> >>> >>> It make it a base for unification.
> >>> >>>
> >>> >>>
> >>> >>>> And to me for 1-line array initializers spaces do not improve
> >>> >>>> readability.
> >>> >>>
> >>> >>> I politely disagree, at least, they improve it for me. :)
> >>> >>>
> >>> >>> We can do one simple test.
> >>> >>> What suggestion would make the Jc's awk script simpler?
> >>> >>> If yours then I'm out.
> >>> >>> Otherwise, why does it make simpler for script but not for
> >>> humans?
> >>> >>>
> >>> >>> Also, we can wait for one more opinion.
> >>> >>>
> >>> >>>
> >>> >>>> So to me this looks like the last item from "Whitespace" is
> >>> >>>> applicable here:
> >>> >>>> <cite>
> >>> >>>> Try not to change whitespace unless it improves
> >>> readability or
> >>> >>>> consistency. (Different editors indent differently, and
> >>> spurious
> >>> >>>> indentation changes will just make integrations more
> >>> difficult.)
> >>> >>>> </cite>
> >>> >>>
> >>> >>> It was Okay to break this rule when we decided to fix
> >>> spacing over
> >>> >>> all the tests.
> >>> >>>
> >>> >>> Thanks,
> >>> >>> Serguei
> >>> >>>
> >>> >>>
> >>> >>>> --alex
> >>> >>>>
> >>> >>>>> Why this case needs to have an exception?
> >>> >>>>>
> >>> >>>>> Thanks,
> >>> >>>>> Serguei
> >>> >>>>>
> >>> >>>>>
> >>> >>>>> On 11/28/18 16:18, Alex Menkov wrote:
> >>> >>>>>> I don't see such rule (I suppose
> >>> >>>>>> https://wiki.openjdk.java.net/display/HotSpot/StyleGuide
> is
> >>> >>>>>> correct link?)
> >>> >>>>>>
> >>> >>>>>> --alex
> >>> >>>>>>
> >>> >>>>>> On 11/28/2018 16:05, serguei.spitsyn@oracle.com
> >>> <mailto:serguei.spitsyn@oracle.com> wrote:
> >>> >>>>>>> On 11/28/18 15:43, Alex Menkov wrote:
> >>> >>>>>>>> Hi Jc,
> >>> >>>>>>>>
> >>> >>>>>>>> In the JDK-8212771 review thread cleanup for "{}" was
> >>> requested
> >>> >>>>>>>> for statements like
> >>> >>>>>>>>
> >>>
> test/hotspot/jtreg/vmTestbase/nsk/jvmti/unit/MethodBind/JvmtiTest/JvmtiTest.cpp,
>
> >>>
> >>>
> >>> >>>>>>>>
> >>> >>>>>>>>
> >>> >>>>>>>> +#define JVMTI_ERROR_CHECK(str,res) if (res !=
> >>> JVMTI_ERROR_NONE)
> >>> >>>>>>>> { printf(str); printf("%d\n",res); return res;}
> >>> >>>>>>>>
> >>> >>>>>>>> +#define JVMTI_ERROR_CHECK_EXPECTED_ERROR(str,res,err) if
> >>> (res
> >>> >>>>>>>> != err) { printf(str); printf("unexpected error
> >>> %d\n",res);
> >>> >>>>>>>> return res;}
> >>> >>>>>>>>
> >>> >>>>>>>> I.e. something like ";}" -> "; }"
> >>> >>>>>>>>
> >>> >>>>>>>>
> >>> >>>>>>>> I don't think changes like
> >>> >>>>>>>>
> >>> >>>>>>>> -static jvmtiEvent testEvents[] =
> >>> {JVMTI_EVENT_THREAD_START,
> >>> >>>>>>>> JVMTI_EVENT_THREAD_END};
> >>> >>>>>>>> +static jvmtiEvent testEvents[] = {
> >>> JVMTI_EVENT_THREAD_START,
> >>> >>>>>>>> JVMTI_EVENT_THREAD_END };
> >>> >>>>>>>>
> >>> >>>>>>>> are required.
> >>> >>>>>>>
> >>> >>>>>>> It is better to have it - rules are rules.
> >>> >>>>>>>
> >>> >>>>>>> Thanks,
> >>> >>>>>>> Serguei
> >>> >>>>>>>
> >>> >>>>>>>>
> >>> >>>>>>>> --alex
> >>> >>>>>>>>
> >>> >>>>>>>>
> >>> >>>>>>>> On 11/28/2018 11:20, JC Beyler wrote:
> >>> >>>>>>>>> Hi all,
> >>> >>>>>>>>>
> >>> >>>>>>>>> When working on a previous clean-up (JDK-8212771), I was
> >>> asked
> >>> >>>>>>>>> to clean-up also spaces around {}.
> >>> >>>>>>>>>
> >>> >>>>>>>>> Here is the first batch out of 2 to fix these cases.
> >>> Let me
> >>> >>>>>>>>> know what you think.
> >>> >>>>>>>>>
> >>> >>>>>>>>> Webrev:
> >>> http://cr.openjdk.java.net/~jcbeyler/8214417/webrev.00/
> >>> >>>>>>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8214417
> >>> >>>>>>>>>
> >>> >>>>>>>>> Thanks for your reviews :-),
> >>> >>>>>>>>> Jc
> >>> >>>>>>>
> >>> >>>>>
> >>> >>>
> >>> >
> >>>
> >>>
> >>>
> >>> --
> >>>
> >>> Thanks,
> >>> Jc
>
>
--
Thanks,
Jc
[Attachment #3 (text/html)]
<div dir="ltr">Thanks all, and pushed :)<div>Jc</div></div><br><div \
class="gmail_quote"><div dir="ltr">On Thu, Nov 29, 2018 at 6:45 PM <<a \
href="mailto:serguei.spitsyn@oracle.com">serguei.spitsyn@oracle.com</a>> \
wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 \
.8ex;border-left:1px #ccc solid;padding-left:1ex">+1<br> <br>
Thanks,<br>
Serguei<br>
<br>
On 11/29/18 4:44 PM, David Holmes wrote:<br>
> +1<br>
><br>
> This is burning a lot of cycles. :)<br>
><br>
> David<br>
><br>
> On 30/11/2018 9:57 am, Alex Menkov wrote:<br>
>> Looks ok<br>
>><br>
>> --alex<br>
>><br>
>> On 11/29/2018 15:00, JC Beyler wrote:<br>
>>> Hi Alex,<br>
>>><br>
>>> Yes that is true, I had initially only done the one-liner {} because \
<br> >>> I was unsure about the cases above :-)<br>
>>><br>
>>> Here is a webrev handling all cases for those 40 files:<br>
>>> Webrev: <a \
href="http://cr.openjdk.java.net/~jcbeyler/8214417/webrev.01/" rel="noreferrer" \
target="_blank">http://cr.openjdk.java.net/~jcbeyler/8214417/webrev.01/</a><br> \
>>> Bug: <a href="https://bugs.openjdk.java.net/browse/JDK-8214417" \
rel="noreferrer" target="_blank">https://bugs.openjdk.java.net/browse/JDK-8214417</a><br>
>>><br>
>>> This was tested on my dev machine for all changed tests.<br>
>>><br>
>>> Thanks!<br>
>>> Jc<br>
>>><br>
>>> On Thu, Nov 29, 2018 at 2:26 PM Alex Menkov <br>
>>> <<a href="mailto:alexey.menkov@oracle.com" \
target="_blank">alexey.menkov@oracle.com</a> <mailto:<a \
href="mailto:alexey.menkov@oracle.com" \
target="_blank">alexey.menkov@oracle.com</a>>> wrote:<br> >>><br>
>>> Ok, guys, you win :)<br>
>>><br>
>>> About the fix:<br>
>>> Looks like only 1-line initializers are fixed, so now we have \
mixed<br> >>> style in some files like:<br>
>>><br>
>>> ClearFieldAccessWatch/clrfldw001/clrfldw001.cpp (lines 52-53 are \
<br> >>> not<br>
>>> updated):<br>
>>><br>
>>> NULL },<br>
>>> 51 { \
"nsk/jvmti/ClearFieldAccessWatch/clrfldw001", "fld1", <br> \
>>> "I", 1,<br> >>> NULL },<br>
>>> 52 \
{"nsk/jvmti/ClearFieldAccessWatch/clrfldw001", "fld2",<br> \
>>> 53 "Lnsk/jvmti/ClearFieldAccessWatch/clrfldw001a;", \
0, NULL},<br> >>> 54 { \
"nsk/jvmti/ClearFieldAccessWatch/clrfldw001a", "fld3",<br> \
>>> "[I", 0,<br> >>> NULL },<br>
>>><br>
>>><br>
>>> The same in \
ClearFieldModificationWatch/clrfmodw001/clrfmodw001.cpp<br> >>> \
(lines 52-53):<br> >>> 51 { \
"nsk/jvmti/ClearFieldModificationWatch/clrfmodw001", <br> >>> \
"fld1",<br> >>> "I", 1, NULL },<br>
>>> 52 \
{"nsk/jvmti/ClearFieldModificationWatch/clrfmodw001", "fld2",<br> \
>>> 53 \
"Lnsk/jvmti/ClearFieldModificationWatch/clrfmodw001a;",<br> >>> \
0, NULL},<br> >>> 54 { \
"nsk/jvmti/ClearFieldModificationWatch/clrfmodw001a", <br> >>> \
"fld3",<br> >>> "[I", 0, NULL },<br>
>>><br>
>>><br>
>>> GetClassSignature/getclsig006/getclsig006.cpp (44-51)<br>
>>> 43 { "getclsig006", <br>
>>> "Lnsk/jvmti/GetClassSignature/getclsig006;",<br>
>>> "NULL" },<br>
>>> 44 {"getclsig006b", <br>
>>> "Lnsk/jvmti/GetClassSignature/getclsig006b;",<br>
>>> 45 \
"<L:Ljava/lang/String;>Ljava/lang/Object;"},<br> >>> \
46 {"getclsig006c", <br> >>> \
"Lnsk/jvmti/GetClassSignature/getclsig006c;",<br> >>> 47 \
<br> >>> "<A:Ljava/lang/Object;B:Ljava/lang/Integer;>Ljava/lang/Object;"},<br>
>>><br>
>>> (and others files)<br>
>>><br>
>>> --alex<br>
>>><br>
>>> On 11/29/2018 11:32, Daniel D. Daugherty wrote:<br>
>>> > I would also write code like what David shows... :-)<br>
>>> ><br>
>>> > Dan<br>
>>> ><br>
>>> ><br>
>>> > On 11/29/18 5:48 AM, David Holmes wrote:<br>
>>> >> I vote for the spaces around { and }<br>
>>> >><br>
>>> >> I would write:<br>
>>> >><br>
>>> >> int foo() { return 1; }<br>
>>> >><br>
>>> >> so would also write:<br>
>>> >><br>
>>> >> static jvmtiEvent testEvents[] = { \
JVMTI_EVENT_THREAD_START,<br> >>> >> JVMTI_EVENT_THREAD_END \
};<br> >>> >><br>
>>> >> Cheers,<br>
>>> >> David<br>
>>> >><br>
>>> >> On 29/11/2018 8:29 pm, <a \
href="mailto:serguei.spitsyn@oracle.com" \
target="_blank">serguei.spitsyn@oracle.com</a><br> >>> <mailto:<a \
href="mailto:serguei.spitsyn@oracle.com" \
target="_blank">serguei.spitsyn@oracle.com</a>> wrote:<br> >>> \
>>> Hi Alex,<br> >>> >>><br>
>>> >>><br>
>>> >>> On 11/28/18 18:18, Alex Menkov wrote:<br>
>>> >>>> Hi Serguei,<br>
>>> >>>><br>
>>> >>>> On 11/28/2018 16:44, <a \
href="mailto:serguei.spitsyn@oracle.com" \
target="_blank">serguei.spitsyn@oracle.com</a><br> >>> <mailto:<a \
href="mailto:serguei.spitsyn@oracle.com" \
target="_blank">serguei.spitsyn@oracle.com</a>> wrote:<br> >>> \
>>>>> There are some implicit rules, like unification and <br> \
>>> consistency.<br> >>> >>>>> We want a \
space or new line after '{' and before '}'.<br> >>> \
>>>><br> >>> >>>> I believe this rule is \
about braces for code blocks (new line<br> >>> after<br>
>>> >>>> "{", "}" on a separate \
line), but this are array <br> >>> initializers.<br>
>>> >>><br>
>>> >>> Array initializers are blocs as well.<br>
>>> >>> It make it a base for unification.<br>
>>> >>><br>
>>> >>><br>
>>> >>>> And to me for 1-line array initializers spaces \
do not improve<br> >>> >>>> readability.<br>
>>> >>><br>
>>> >>> I politely disagree, at least, they improve it for \
me. :)<br> >>> >>><br>
>>> >>> We can do one simple test.<br>
>>> >>> What suggestion would make the Jc's awk script \
simpler?<br> >>> >>> If yours then I'm out.<br>
>>> >>> Otherwise, why does it make simpler for script but \
not for <br> >>> humans?<br>
>>> >>><br>
>>> >>> Also, we can wait for one more opinion.<br>
>>> >>><br>
>>> >>><br>
>>> >>>> So to me this looks like the last item from \
"Whitespace" is<br> >>> >>>> applicable \
here:<br> >>> >>>> <cite><br>
>>> >>>> Try not to change whitespace unless it \
improves <br> >>> readability or<br>
>>> >>>> consistency. (Different editors indent \
differently, and <br> >>> spurious<br>
>>> >>>> indentation changes will just make \
integrations more <br> >>> difficult.)<br>
>>> >>>> </cite><br>
>>> >>><br>
>>> >>> It was Okay to break this rule when we decided to \
fix <br> >>> spacing over<br>
>>> >>> all the tests.<br>
>>> >>><br>
>>> >>> Thanks,<br>
>>> >>> Serguei<br>
>>> >>><br>
>>> >>><br>
>>> >>>> --alex<br>
>>> >>>><br>
>>> >>>>> Why this case needs to have an \
exception?<br> >>> >>>>><br>
>>> >>>>> Thanks,<br>
>>> >>>>> Serguei<br>
>>> >>>>><br>
>>> >>>>><br>
>>> >>>>> On 11/28/18 16:18, Alex Menkov wrote:<br>
>>> >>>>>> I don't see such rule (I \
suppose<br> >>> >>>>>> <a \
href="https://wiki.openjdk.java.net/display/HotSpot/StyleGuide" rel="noreferrer" \
target="_blank">https://wiki.openjdk.java.net/display/HotSpot/StyleGuide</a> is<br> \
>>> >>>>>> correct link?)<br> >>> \
>>>>>><br> >>> >>>>>> \
--alex<br> >>> >>>>>><br>
>>> >>>>>> On 11/28/2018 16:05, <a \
href="mailto:serguei.spitsyn@oracle.com" \
target="_blank">serguei.spitsyn@oracle.com</a><br> >>> <mailto:<a \
href="mailto:serguei.spitsyn@oracle.com" \
target="_blank">serguei.spitsyn@oracle.com</a>> wrote:<br> >>> \
>>>>>>> On 11/28/18 15:43, Alex Menkov wrote:<br> >>> \
>>>>>>>> Hi Jc,<br> >>> \
>>>>>>>><br> >>> \
>>>>>>>> In the JDK-8212771 review thread cleanup for \
"{}" was<br> >>> requested<br>
>>> >>>>>>>> for statements like<br>
>>> >>>>>>>><br>
>>> test/hotspot/jtreg/vmTestbase/nsk/jvmti/unit/MethodBind/JvmtiTest/JvmtiTest.cpp, \
<br> >>><br>
>>><br>
>>> >>>>>>>><br>
>>> >>>>>>>><br>
>>> >>>>>>>> +#define \
JVMTI_ERROR_CHECK(str,res) if (res !=<br> >>> JVMTI_ERROR_NONE)<br>
>>> >>>>>>>> { printf(str); \
printf("%d\n",res); return res;}<br> >>> \
>>>>>>>><br> >>> \
>>>>>>>> +#define \
JVMTI_ERROR_CHECK_EXPECTED_ERROR(str,res,err) if<br> >>> (res<br>
>>> >>>>>>>> != err) { printf(str); \
printf("unexpected error <br> >>> %d\n",res);<br>
>>> >>>>>>>> return res;}<br>
>>> >>>>>>>><br>
>>> >>>>>>>> I.e. something like \
";}" -> "; }"<br> >>> \
>>>>>>>><br> >>> \
>>>>>>>><br> >>> \
>>>>>>>> I don't think changes like<br> >>> \
>>>>>>>><br> >>> \
>>>>>>>> -static jvmtiEvent testEvents[] = <br> >>> \
{JVMTI_EVENT_THREAD_START,<br> >>> >>>>>>>> \
JVMTI_EVENT_THREAD_END};<br> >>> >>>>>>>> \
+static jvmtiEvent testEvents[] = { <br> >>> JVMTI_EVENT_THREAD_START,<br>
>>> >>>>>>>> JVMTI_EVENT_THREAD_END };<br>
>>> >>>>>>>><br>
>>> >>>>>>>> are required.<br>
>>> >>>>>>><br>
>>> >>>>>>> It is better to have it - rules \
are rules.<br> >>> >>>>>>><br>
>>> >>>>>>> Thanks,<br>
>>> >>>>>>> Serguei<br>
>>> >>>>>>><br>
>>> >>>>>>>><br>
>>> >>>>>>>> --alex<br>
>>> >>>>>>>><br>
>>> >>>>>>>><br>
>>> >>>>>>>> On 11/28/2018 11:20, JC Beyler \
wrote:<br> >>> >>>>>>>>> Hi all,<br>
>>> >>>>>>>>><br>
>>> >>>>>>>>> When working on a previous \
clean-up (JDK-8212771), I was<br> >>> asked<br>
>>> >>>>>>>>> to clean-up also spaces \
around {}.<br> >>> >>>>>>>>><br>
>>> >>>>>>>>> Here is the first batch \
out of 2 to fix these cases. <br> >>> Let me<br>
>>> >>>>>>>>> know what you think.<br>
>>> >>>>>>>>><br>
>>> >>>>>>>>> Webrev:<br>
>>> <a href="http://cr.openjdk.java.net/~jcbeyler/8214417/webrev.00/" \
rel="noreferrer" target="_blank">http://cr.openjdk.java.net/~jcbeyler/8214417/webrev.00/</a><br>
>>> >>>>>>>>> Bug: <a \
href="https://bugs.openjdk.java.net/browse/JDK-8214417" rel="noreferrer" \
target="_blank">https://bugs.openjdk.java.net/browse/JDK-8214417</a><br> >>> \
>>>>>>>>><br> >>> \
>>>>>>>>> Thanks for your reviews :-),<br> >>> \
>>>>>>>>> Jc<br> >>> \
>>>>>>><br> >>> >>>>><br>
>>> >>><br>
>>> ><br>
>>><br>
>>><br>
>>><br>
>>> -- <br>
>>><br>
>>> Thanks,<br>
>>> Jc<br>
<br>
</blockquote></div><br clear="all"><div><br></div>-- <br><div dir="ltr" \
class="gmail_signature" data-smartmail="gmail_signature"><div \
dir="ltr"><div><br></div>Thanks,<div>Jc</div></div></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic