[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR (S) 8214408: Migrate EventsOnOff to using the same allocateAndCheck method
From:       JC Beyler <jcbeyler () google ! com>
Date:       2018-11-28 19:13:53
Message-ID: CAF9BGBzwhWS08EoqJ570fCrWK+ZGBCTvEfWTDYGCm3_h2k7gLA () mail ! gmail ! com
[Download RAW message or body]

Thanks both, tested via submit repo and pushed!
Jc

On Tue, Nov 27, 2018 at 6:19 PM Alex Menkov <alexey.menkov@oracle.com>
wrote:

> +1
>
> --alex
>
> On 11/27/2018 16:42, serguei.spitsyn@oracle.com wrote:
> > Hi Jc,
> >
> > LGTM
> >
> > Thanks,
> > Serguei
> >
> >
> > On 11/27/18 1:45 PM, JC Beyler wrote:
> >> Hi all,
> >>
> >> Could I get a review for this webrev, it is an attempt to fix
> >> JDK-8214192, which I cannot reproduce locally:
> >>
> >> Webrev: http://cr.openjdk.java.net/~jcbeyler/8214408/webrev.00/
> >> <http://cr.openjdk.java.net/%7Ejcbeyler/8214408/webrev.00/>
> >> Bug: https://bugs.openjdk.java.net/browse/JDK-8214408
> >>
> >> Once pushed, I'll ask someone to check if the original failure
> >> JDK-8214192 has disappeared (or perhaps we could do a mach5 testing
> >> with this fix and see?)
> >>
> >> Thanks for your help,
> >> Jc
> >
>


-- 

Thanks,
Jc

[Attachment #3 (text/html)]

<div dir="ltr">Thanks both, tested via submit repo and \
pushed!<div>Jc</div></div><br><div class="gmail_quote"><div dir="ltr">On Tue, Nov 27, \
2018 at 6:19 PM Alex Menkov &lt;<a \
href="mailto:alexey.menkov@oracle.com">alexey.menkov@oracle.com</a>&gt; \
wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 \
.8ex;border-left:1px #ccc solid;padding-left:1ex">+1<br> <br>
--alex<br>
<br>
On 11/27/2018 16:42, <a href="mailto:serguei.spitsyn@oracle.com" \
target="_blank">serguei.spitsyn@oracle.com</a> wrote:<br> &gt; Hi Jc,<br>
&gt; <br>
&gt; LGTM<br>
&gt; <br>
&gt; Thanks,<br>
&gt; Serguei<br>
&gt; <br>
&gt; <br>
&gt; On 11/27/18 1:45 PM, JC Beyler wrote:<br>
&gt;&gt; Hi all,<br>
&gt;&gt;<br>
&gt;&gt; Could I get a review for this webrev, it is an attempt to fix <br>
&gt;&gt; JDK-8214192, which I cannot reproduce locally:<br>
&gt;&gt;<br>
&gt;&gt; Webrev: <a href="http://cr.openjdk.java.net/~jcbeyler/8214408/webrev.00/" \
rel="noreferrer" target="_blank">http://cr.openjdk.java.net/~jcbeyler/8214408/webrev.00/</a> \
<br> &gt;&gt; &lt;<a href="http://cr.openjdk.java.net/%7Ejcbeyler/8214408/webrev.00/" \
rel="noreferrer" target="_blank">http://cr.openjdk.java.net/%7Ejcbeyler/8214408/webrev.00/</a>&gt;<br>
 &gt;&gt; Bug: <a href="https://bugs.openjdk.java.net/browse/JDK-8214408" \
rel="noreferrer" target="_blank">https://bugs.openjdk.java.net/browse/JDK-8214408</a><br>
 &gt;&gt;<br>
&gt;&gt; Once pushed, I&#39;ll ask someone to check if the original failure <br>
&gt;&gt; JDK-8214192 has disappeared (or perhaps we could do a mach5 testing <br>
&gt;&gt; with this fix and see?)<br>
&gt;&gt;<br>
&gt;&gt; Thanks for your help,<br>
&gt;&gt; Jc<br>
&gt; <br>
</blockquote></div><br clear="all"><div><br></div>-- <br><div dir="ltr" \
class="gmail_signature" data-smartmail="gmail_signature"><div \
dir="ltr"><div><br></div>Thanks,<div>Jc</div></div></div>



[prev in list] [next in list] [prev in thread] [next in thread]