[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    RFR (M) 8201655: Add thread-enabled support for the Heap Sampling
From:       JC Beyler <jcbeyler () google ! com>
Date:       2018-10-26 17:48:14
Message-ID: CAF9BGBzLKyAe1eHBN7=F3xoA1-5U-kna6zrMwF4bd4T1HmJ5OA () mail ! gmail ! com
[Download RAW message or body]

Hi all,

When working on the heap sampling, I had promised to do the per thread
event so here it is!

Could I get a review for this:
Webrev: http://cr.openjdk.java.net/~jcbeyler/8201655/webrev.02/
Bug: https://bugs.openjdk.java.net/browse/JDK-8201655

I was thinking of adding GC-dev for the memAllocator change once I get
favorable reviews for the rest of the change.

I've done a bit of performance testing and on the Dacapo benchmark I see no
change in performance when turned off (logical, any code change is behind a
flag check already in place) and when turned on it is comparable to the
current performance.

(More information is: I see a very slight degradation if we are doing 512k
sampling but no degradation at 2MB).

Thanks,
Jc

[Attachment #3 (text/html)]

<div dir="ltr"><div dir="ltr"><div dir="ltr">Hi all,</div><div \
dir="ltr"><br></div><div>When working on the heap sampling, I had promised to do the \
per thread event so here it is!  </div><div><br></div><div dir="ltr">Could I get a \
review for this:<br clear="all"><div>Webrev: <a \
href="http://cr.openjdk.java.net/~jcbeyler/8201655/webrev.02/">http://cr.openjdk.java.net/~jcbeyler/8201655/webrev.02/</a><br></div><div>Bug: \
<a href="https://bugs.openjdk.java.net/browse/JDK-8201655">https://bugs.openjdk.java.net/browse/JDK-8201655</a></div><div><br></div><div>I \
was thinking of adding GC-dev for the memAllocator change once I get favorable \
reviews for the rest of the change.</div><div><br></div><div>I&#39;ve done a bit of \
performance testing and on the Dacapo benchmark I see no change in performance when \
turned off (logical, any code change is behind a flag check already in place) and \
when turned on it is comparable to the current \
performance.</div><div><br></div><div>(More information is: I see a very slight \
degradation if we are doing 512k sampling but no degradation at 2MB).  \
</div><div><br></div><div dir="ltr" class="gmail_signature"><div \
dir="ltr">Thanks,<div>Jc</div></div></div></div></div></div>



[prev in list] [next in list] [prev in thread] [next in thread]