[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-serviceability-dev
Subject: Re: RFR (M) 8212884: Remove the assignments in ifs for vmTestbase/[a-s]
From: Chris Plummer <chris.plummer () oracle ! com>
Date: 2018-10-25 17:05:56
Message-ID: 7f824920-7bda-792d-f28d-22e05427944c () oracle ! com
[Download RAW message or body]
<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<div class="moz-cite-prefix">+1<br>
<br>
On 10/25/18 9:38 AM, <a class="moz-txt-link-abbreviated" \
href="mailto:serguei.spitsyn@oracle.com">serguei.spitsyn@oracle.com</a> wrote:<br> \
</div> <blockquote type="cite"
cite="mid:462ecc44-d226-1342-14f7-ac55ba4af376@oracle.com">
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<div class="moz-cite-prefix">Hi Jc,<br>
<br>
LGTM.<br>
<br>
Thanks,<br>
Serguei<br>
<br>
<br>
On 10/25/18 09:00, JC Beyler wrote:<br>
</div>
<blockquote type="cite"
cite="mid:CAF9BGBx2eNFp4wOAsk2WcHh=Z5Bk+3LvVt95XCc1X+5BVgZbag@mail.gmail.com">
<div dir="ltr">
<div dir="ltr">
<div dir="ltr">
<div dir="ltr">
<div dir="ltr">
<div dir="ltr">Hi all,
<div><br>
</div>
<div>For reference, after the space removal webrev
has been pushed, this webrev had a tiny conflict
(as Chris had guessed) in one file:<br>
</div>
<div>test/hotspot/jtreg/vmTestbase/nsk/jvmti/scenarios/allocation/AP04/ap04t003/ap04t003.cpp<br>
</div>
<div><br>
</div>
<div>You can see the old change vs the new change,
it is trivial to see it is ok:</div>
<div>- <a
href="http://cr.openjdk.java.net/%7Ejcbeyler/8212884/webrev.00/test/hotspot/jtreg/vmTestbase/nsk/jvmti/scenarios/allocation/AP04/ap04t003/ap04t003.cpp.udiff.html"
moz-do-not-send="true">http://cr.openjdk.java.net/~jcbeyler/8212884/webrev.00/test/h \
otspot/jtreg/vmTestbase/nsk/jvmti/scenarios/allocation/AP04/ap04t003/ap04t003.cpp.udiff.html</a><br>
</div>
<div>- <a
href="http://cr.openjdk.java.net/%7Ejcbeyler/8212884/webrev.01/test/hotspot/jtreg/vmTestbase/nsk/jvmti/scenarios/allocation/AP04/ap04t003/ap04t003.cpp.udiff.html"
moz-do-not-send="true">http://cr.openjdk.java.net/~jcbeyler/8212884/webrev.01/test/h \
otspot/jtreg/vmTestbase/nsk/jvmti/scenarios/allocation/AP04/ap04t003/ap04t003.cpp.udiff.html</a><br>
</div>
<div><br>
</div>
<div>The full webrev is here:</div>
<div>Webrev: <a
\
href="http://cr.openjdk.java.net/%7Ejcbeyler/8212884/webrev.01/"
\
moz-do-not-send="true">http://cr.openjdk.java.net/~jcbeyler/8212884/webrev.01/</a></div>
<div>Bug: <a
href="https://bugs.openjdk.java.net/browse/JDK-8212884"
\
moz-do-not-send="true">https://bugs.openjdk.java.net/browse/JDK-8212884</a></div> \
<div><br> </div>
<div>If I could have a final LGTM, that would be
awesome!</div>
<div>Jc</div>
</div>
</div>
</div>
</div>
</div>
</div>
<br>
<div class="gmail_quote">
<div dir="ltr">On Wed, Oct 24, 2018 at 2:26 PM <a
href="mailto:serguei.spitsyn@oracle.com"
moz-do-not-send="true">serguei.spitsyn@oracle.com</a> <<a
href="mailto:serguei.spitsyn@oracle.com"
moz-do-not-send="true">serguei.spitsyn@oracle.com</a>>
wrote:<br>
</div>
<blockquote class="gmail_quote">
<div>
<div class="m_7524423201872714834moz-cite-prefix">Hi Jc,<br>
<br>
It looks great!<br>
Your AI-enabled conversion scripts are smart! :)<br>
<br>
Thanks,<br>
Serguei<br>
<br>
On 10/24/18 09:40, JC Beyler wrote:<br>
</div>
<blockquote type="cite">
<div dir="ltr">
<div dir="ltr">
<div dir="ltr">Hi all,
<div><br>
</div>
<div>Here is the first webrev to extract
assignments from if test clauses. It should be
relatively straightforward to review.</div>
<div><br>
</div>
<div>I tested all the tests changed and they pass
on my dev machine.<br>
<div><br>
</div>
<div>Most changes were done via the script I put
in the bug, I had to do a few clean-ups and
corner cases as well.</div>
<div><br>
</div>
<div dir="ltr"
class="m_7524423201872714834gmail_signature">
<div dir="ltr">
<div>Webrev: <a
\
href="http://cr.openjdk.java.net/%7Ejcbeyler/8212884/webrev.00/"
target="_blank" \
moz-do-not-send="true">http://cr.openjdk.java.net/~jcbeyler/8212884/webrev.00/</a></div>
<div>Bug: <a
\
href="https://bugs.openjdk.java.net/browse/JDK-8212884"
target="_blank" \
moz-do-not-send="true">https://bugs.openjdk.java.net/browse/JDK-8212884</a></div> \
<div><br> </div>
Thanks,
<div>Jc</div>
</div>
</div>
</div>
</div>
</div>
</div>
</blockquote>
<br>
</div>
</blockquote>
</div>
<br>
<div><br>
</div>
-- <br>
<div dir="ltr" class="gmail_signature"
data-smartmail="gmail_signature">
<div dir="ltr">
<div><br>
</div>
Thanks,
<div>Jc</div>
</div>
</div>
</blockquote>
<br>
</blockquote>
<p><br>
</p>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic