[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-serviceability-dev
Subject: Re: RFR (M) 8212771: Remove remaining spaces before/after () for vmTestbase
From: "Hohensee, Paul" <hohensee () amazon ! com>
Date: 2018-10-23 14:55:06
Message-ID: 69F1A35C-4AEB-4F68-910B-8C4D8A63F80E () amazon ! com
[Download RAW message or body]
[Attachment #2 (text/plain)]
Thanks for filing the new RFEs!
Paul
From: JC Beyler <jcbeyler@google.com>
Date: Tuesday, October 23, 2018 at 7:49 AM
To: "Hohensee, Paul" <hohensee@amazon.com>
Cc: "serguei.spitsyn@oracle.com" <serguei.spitsyn@oracle.com>, \
"serviceability-dev@openjdk.java.net" \
<serviceability-dev@openjdk.java.net>
Subject: Re: RFR (M) 8212771: Remove remaining spaces before/after () for vmTestbase
Hi Paul,
Thanks for the review! I created two new bugs for these two refactoring cases. They \
seem fairly uncommon so should be easy to fix throughout .cpp files in vmTestbase. \
https://bugs.openjdk.java.net/browse/JDK-8212822 \
https://bugs.openjdk.java.net/browse/JDK-8212824
So I'll keep them out of scope of this change as you recommended to do it separately \
;-), Jc
On Mon, Oct 22, 2018 at 5:10 PM Hohensee, Paul \
<hohensee@amazon.com<mailto:hohensee@amazon.com>> wrote: Lgtm.
There's a similar issue with ‘{‘'}' you might want to fix separately, except in \
the opposite direction :), e.g., in \
test/hotspot/jtreg/vmTestbase/nsk/jvmti/unit/MethodBind/JvmtiTest/JvmtiTest.cpp, \
+#define JVMTI_ERROR_CHECK(str,res) if (res != JVMTI_ERROR_NONE) { printf(str); \
printf("%d\n",res); return res;} +#define \
JVMTI_ERROR_CHECK_EXPECTED_ERROR(str,res,err) if (res != err) { printf(str); \
printf("unexpected error %d\n",res); return res;} =>
+#define JVMTI_ERROR_CHECK(str,res) if (res != JVMTI_ERROR_NONE) { printf(str); \
printf("%d\n",res); return res; }
+#define JVMTI_ERROR_CHECK_EXPECTED_ERROR(str,res,err) if (res != err) { printf(str); \
printf("unexpected error %d\n",res); return res; }
And somewhat different in \
test/hotspot/jtreg/vmTestbase/nsk/share/jvmti/aod/jvmti_aod.cpp
+ (threadConstructor = NSK_CPP_STUB4(GetMethodID, jni, klass, "<init>", \
"()V")) != NULL)) {
=>
+ (threadConstructor = NSK_CPP_STUB4(GetMethodID, jni, klass, "<init>", \
"()V")) != NULL)) {
Paul
From: serviceability-dev \
<serviceability-dev-bounces@openjdk.java.net<mailto:serviceability-dev-bounces@openjdk.java.net>> \
on behalf of "serguei.spitsyn@oracle.com<mailto:serguei.spitsyn@oracle.com>" \
<serguei.spitsyn@oracle.com<mailto:serguei.spitsyn@oracle.com>>
Date: Monday, October 22, 2018 at 3:15 PM
To: JC Beyler <jcbeyler@google.com<mailto:jcbeyler@google.com>>, \
"serviceability-dev@openjdk.java.net<mailto:serviceability-dev@openjdk.java.net>" \
<serviceability-dev@openjdk.java.net<mailto:serviceability-dev@openjdk.java.net>>
Subject: Re: RFR (M) 8212771: Remove remaining spaces before/after () for vmTestbase
Hi Jc,
It looks good.
Thanks!
Serguei
On 10/22/18 11:30, JC Beyler wrote:
Hi all,
Here is the last webrev (3 out of 3) to remove the spaces after/before () from \
vmTestbase. It is straightforward and I generated the webrev with white-space changes \
showing up of course:
Webrev: http://cr.openjdk.java.net/~jcbeyler/8212771/webrev.00/<http://cr.openjdk.java.net/%7Ejcbeyler/8212771/webrev.00/>
Bug: https://bugs.openjdk.java.net/browse/JDK-8212771
Could I please get some reviews?
Thanks,
Jc
--
Thanks,
Jc
[Attachment #3 (text/html)]
<html xmlns:o="urn:schemas-microsoft-com:office:office" \
xmlns:w="urn:schemas-microsoft-com:office:word" \
xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" \
xmlns="http://www.w3.org/TR/REC-html40"> <head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Consolas;
panose-1:2 11 6 9 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
h2
{mso-style-priority:9;
mso-style-link:"Heading 2 Char";
mso-margin-top-alt:auto;
margin-right:0in;
mso-margin-bottom-alt:auto;
margin-left:0in;
font-size:18.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
pre
{mso-style-priority:99;
mso-style-link:"HTML Preformatted Char";
margin:0in;
margin-bottom:.0001pt;
font-size:10.0pt;
font-family:"Courier New";}
p.msonormal0, li.msonormal0, div.msonormal0
{mso-style-name:msonormal;
mso-margin-top-alt:auto;
margin-right:0in;
mso-margin-bottom-alt:auto;
margin-left:0in;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
span.Heading2Char
{mso-style-name:"Heading 2 Char";
mso-style-priority:9;
mso-style-link:"Heading 2";
font-family:"Calibri Light",sans-serif;
color:#2F5496;}
span.HTMLPreformattedChar
{mso-style-name:"HTML Preformatted Char";
mso-style-priority:99;
mso-style-link:"HTML Preformatted";
font-family:"Consolas",serif;}
span.m-7104962076303880773new
{mso-style-name:m_-7104962076303880773new;}
span.EmailStyle22
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style>
</head>
<body lang="EN-US" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal">Thanks for filing the new RFEs!<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Paul<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span style="font-size:12.0pt;color:black">From: \
</span></b><span style="font-size:12.0pt;color:black">JC Beyler \
<jcbeyler@google.com><br> <b>Date: </b>Tuesday, October 23, 2018 at 7:49 AM<br>
<b>To: </b>"Hohensee, Paul" <hohensee@amazon.com><br>
<b>Cc: </b>"serguei.spitsyn@oracle.com" <serguei.spitsyn@oracle.com>, \
"serviceability-dev@openjdk.java.net" \
<serviceability-dev@openjdk.java.net><br> <b>Subject: </b>Re: RFR (M) 8212771: \
Remove remaining spaces before/after () for vmTestbase<o:p></o:p></span></p> </div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<div>
<div>
<p class="MsoNormal">Hi Paul, <o:p></o:p></p>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">Thanks for the review! I created two new bugs for these two \
refactoring cases. They seem fairly uncommon so should be easy to fix throughout .cpp \
files in vmTestbase.<o:p></o:p></p> </div>
<div>
<p class="MsoNormal"><a \
href="https://bugs.openjdk.java.net/browse/JDK-8212822">https://bugs.openjdk.java.net/browse/JDK-8212822</a><o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><a \
href="https://bugs.openjdk.java.net/browse/JDK-8212824">https://bugs.openjdk.java.net/browse/JDK-8212824</a><o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">So I'll keep them out of scope of this change as you recommended \
to do it separately ;-),<o:p></o:p></p> </div>
<div>
<p class="MsoNormal">Jc<o:p></o:p></p>
</div>
</div>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<div>
<p class="MsoNormal">On Mon, Oct 22, 2018 at 5:10 PM Hohensee, Paul <<a \
href="mailto:hohensee@amazon.com">hohensee@amazon.com</a>> wrote:<o:p></o:p></p> \
</div> <blockquote style="border:none;border-left:solid #CCCCCC 1.0pt;padding:0in 0in \
0in 6.0pt;margin-left:4.8pt;margin-right:0in"> <div>
<div>
<p class="MsoNormal" \
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto">Lgtm.<o:p></o:p></p> \
<h2><span style="font-size:11.0pt;font-weight:normal">There's a similar issue with \
‘{‘'}' you might want to fix separately, except in the opposite direction :), \
e.g., in test/hotspot/jtreg/vmTestbase/nsk/jvmti/unit/MethodBind/JvmtiTest/JvmtiTest.cpp,</span><o:p></o:p></h2>
<p class="MsoNormal" \
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span \
style="font-size:10.0pt;font-family:"Courier New"">+#define \
JVMTI_ERROR_CHECK(str,res) if (res != JVMTI_ERROR_NONE) { printf(str); \
printf("%d\n",res); return res;}</span><o:p></o:p></p> <p class="MsoNormal" \
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><span \
style="font-size:10.0pt;font-family:"Courier New"">+#define \
JVMTI_ERROR_CHECK_EXPECTED_ERROR(str,res,err) if (res != err) { printf(str); \
printf("unexpected error %d\n",res); return res;}</span><o:p></o:p></p>
<h2><span style="font-size:11.0pt;font-weight:normal">=></span><o:p></o:p></h2>
<pre><span class="m-7104962076303880773new">+#define JVMTI_ERROR_CHECK(str,res) \
if (res != JVMTI_ERROR_NONE) { printf(str); printf("%d\n",res); return res; \
}</span><o:p></o:p></pre> <pre><span class="m-7104962076303880773new">+#define \
JVMTI_ERROR_CHECK_EXPECTED_ERROR(str,res,err) if (res != err) { printf(str); \
printf("unexpected error %d\n",res); return res; }</span><o:p></o:p></pre> \
<p class="MsoNormal" \
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"> <o:p></o:p></p> \
<h2><span style="font-size:11.0pt;font-weight:normal">And somewhat different in \
test/hotspot/jtreg/vmTestbase/nsk/share/jvmti/aod/jvmti_aod.cpp</span><o:p></o:p></h2>
<pre><span class="m-7104962076303880773new">+ \
(threadConstructor = NSK_CPP_STUB4(GetMethodID, jni, klass, "<init>", \
"()V")) != NULL)) {</span><o:p></o:p></pre> <h2><span \
style="font-size:11.0pt;font-weight:normal">=></span><o:p></o:p></h2> <pre><span \
class="m-7104962076303880773new">+ \
(threadConstructor = NSK_CPP_STUB4(GetMethodID, jni, klass, "<init>", \
"()V")) != NULL)) {</span><o:p></o:p></pre> <h2><span \
style="font-size:11.0pt;font-weight:normal">Paul</span><o:p></o:p></h2> <div \
style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in"> <p \
class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"><b><span \
style="font-size:12.0pt;color:black">From: </span></b><span \
style="font-size:12.0pt;color:black">serviceability-dev <<a \
href="mailto:serviceability-dev-bounces@openjdk.java.net" \
target="_blank">serviceability-dev-bounces@openjdk.java.net</a>> on behalf of \
"<a href="mailto:serguei.spitsyn@oracle.com" \
target="_blank">serguei.spitsyn@oracle.com</a>" <<a \
href="mailto:serguei.spitsyn@oracle.com" \
target="_blank">serguei.spitsyn@oracle.com</a>><br> <b>Date: </b>Monday, October \
22, 2018 at 3:15 PM<br> <b>To: </b>JC Beyler <<a href="mailto:jcbeyler@google.com" \
target="_blank">jcbeyler@google.com</a>>, "<a \
href="mailto:serviceability-dev@openjdk.java.net" \
target="_blank">serviceability-dev@openjdk.java.net</a>" <<a \
href="mailto:serviceability-dev@openjdk.java.net" \
target="_blank">serviceability-dev@openjdk.java.net</a>><br> <b>Subject: </b>Re: \
RFR (M) 8212771: Remove remaining spaces before/after () for \
vmTestbase</span><o:p></o:p></p> </div>
<div>
<p class="MsoNormal" \
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"> <o:p></o:p></p> \
</div> <div>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto">Hi \
Jc,<br> <br>
It looks good.<br>
<br>
Thanks!<br>
Serguei<br>
<br>
<br>
On 10/22/18 11:30, JC Beyler wrote:<o:p></o:p></p>
</div>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<div>
<div>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto">Hi \
all,<o:p></o:p></p> </div>
<div>
<p class="MsoNormal" \
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"> <o:p></o:p></p> \
</div> <div>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto">Here \
is the last webrev (3 out of 3) to remove the spaces after/before () from vmTestbase. \
It is straightforward and I generated the webrev with white-space changes showing up \
of course:<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal" \
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"> <o:p></o:p></p> \
</div> <div>
<div>
<p class="MsoNormal" \
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto">Webrev: <a \
href="http://cr.openjdk.java.net/%7Ejcbeyler/8212771/webrev.00/" target="_blank"> \
http://cr.openjdk.java.net/~jcbeyler/8212771/webrev.00/</a><o:p></o:p></p> </div>
<div>
<p class="MsoNormal" \
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto">Bug: <a \
href="https://bugs.openjdk.java.net/browse/JDK-8212771" \
target="_blank">https://bugs.openjdk.java.net/browse/JDK-8212771</a><o:p></o:p></p> \
</div> <div>
<p class="MsoNormal" \
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"> <o:p></o:p></p> \
</div> <div>
<p class="MsoNormal" style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto">Could \
I please get some reviews?<o:p></o:p></p> </div>
<div>
<div>
<div>
<p class="MsoNormal" \
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto"> <o:p></o:p></p> \
</div> <p class="MsoNormal" \
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto">Thanks, <o:p></o:p></p>
<div>
<p class="MsoNormal" \
style="mso-margin-top-alt:auto;mso-margin-bottom-alt:auto">Jc<o:p></o:p></p> </div>
</div>
</div>
</div>
</div>
</blockquote>
<p class="MsoNormal" \
style="mso-margin-top-alt:auto;margin-bottom:12.0pt"><o:p> </o:p></p> </div>
</div>
</blockquote>
</div>
<p class="MsoNormal"><br clear="all">
<o:p></o:p></p>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<p class="MsoNormal">-- <o:p></o:p></p>
<div>
<div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<p class="MsoNormal">Thanks, <o:p></o:p></p>
<div>
<p class="MsoNormal">Jc<o:p></o:p></p>
</div>
</div>
</div>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic