[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-serviceability-dev
Subject: Re: RFR (M) 8212535: Remove spaces before/after () for vmTestbase/[a-s]*
From: "Hohensee, Paul" <hohensee () amazon ! com>
Date: 2018-10-23 0:23:30
Message-ID: DB25AB84-3D11-49C8-B8CC-FB0A1BEB17BF () amazon ! com
[Download RAW message or body]
[Attachment #2 (text/plain)]
Lgtm. One nit in libnativeGC01.cpp
- * A C function that takes a reference to java Object( a circular Linked list)
+ * A C function that takes a reference to java Object(a circular Linked list)
=>
+ * A C function that takes a reference to java Object (a circular Linked list)
No need for a new webrev.
Paul
From: serviceability-dev <serviceability-dev-bounces@openjdk.java.net> on behalf of \
"serguei.spitsyn@oracle.com" <serguei.spitsyn@oracle.com>
Date: Monday, October 22, 2018 at 2:40 PM
To: JC Beyler <jcbeyler@google.com>, "alexey.menkov@oracle.com" \
<alexey.menkov@oracle.com>
Cc: "serviceability-dev@openjdk.java.net" <serviceability-dev@openjdk.java.net>
Subject: Re: RFR (M) 8212535: Remove spaces before/after () for vmTestbase/[a-s]*
Hi Alex,
It looks good.
Thanks!
Serguei
On 10/22/18 12:56, JC Beyler wrote:
Hi Alex,
Done, I left this one:
- if (!NSK_JVMTI_VERIFY(
- jvmti->IterateOverHeap(JVMTI_HEAP_OBJECT_EITHER, \
heapObjectCallback, (void *)user_data))) { + if \
(!NSK_JVMTI_VERIFY(jvmti->IterateOverHeap( + \
JVMTI_HEAP_OBJECT_EITHER, heapObjectCallback, (void *)user_data))) {
The whole length was at 126 characters, it seemed a bit long:
http://cr.openjdk.java.net/~jcbeyler/8212535/webrev.02/test/hotspot/jtreg/vmTestbase/n \
sk/jvmti/IterateOverHeap/iterheap007/iterheap007.cpp.udiff.html<http://cr.openjdk.java \
.net/%7Ejcbeyler/8212535/webrev.02/test/hotspot/jtreg/vmTestbase/nsk/jvmti/IterateOverHeap/iterheap007/iterheap007.cpp.udiff.html>
The new webrev is here:
http://cr.openjdk.java.net/~jcbeyler/8212535/webrev.02/<http://cr.openjdk.java.net/%7Ejcbeyler/8212535/webrev.02/>
Thanks,
Jc
On Mon, Oct 22, 2018 at 12:44 PM Alex Menkov \
<alexey.menkov@oracle.com<mailto:alexey.menkov@oracle.com>> wrote: Hi Jc,
Looks good to me.
Could you please update
nsk/jvmti/IterateOverHeap/iterheap007/iterheap007.cpp :
if (!NSK_JVMTI_VERIFY(
- <jvmti_call>)) {
+ <jvmti_call>)) {
=>
if (!NSK_JVMTI_VERIFY(<jvmti_call>)) {
As all <jvmti_call>s there are quite short.
--alex
On 10/19/2018 14:56, JC Beyler wrote:
> Hi Chris,
>
> Done!
>
> Here is the newest version:
> http://cr.openjdk.java.net/~jcbeyler/8212535/webrev.01/<http://cr.openjdk.java.net/%7Ejcbeyler/8212535/webrev.01/>
> <http://cr.openjdk.java.net/%7Ejcbeyler/8212535/webrev.01/>
>
> Thanks for the review!
> Jc
>
> On Fri, Oct 19, 2018 at 2:24 PM Chris Plummer \
> <chris.plummer@oracle.com<mailto:chris.plummer@oracle.com> \
> <mailto:chris.plummer@oracle.com<mailto:chris.plummer@oracle.com>>> wrote:
> Hi JC,
>
> iterinstcls006.cpp: Can you fix the indentation of the second line.
>
> 98 NSK_COMPLAIN2("Local storage was corrupted: %s
> ,\n\texpected value: %s\n",
> 99 (char *)storage_ptr, storage_data);
>
> iterobjreachobj004.cpp: Can you fix the indentation of the second line.
>
> 123 NSK_COMPLAIN2("Local storage was corrupted: %s
> ,\n\texpected value: %s\n",
> 124 (char *)storage_ptr, storage_data);
>
> iterreachobj002.cpp: You didn't align the arguments like you have
> elsewhere.
>
> 175
> stackReferenceCallbackForSecondObjectsIteration(jvmtiHeapRootKind
> root_kind,
> 176 jlong class_tag,
> 177 jlong size,
> 178 jlong* tag_ptr,
> 179 jlong thread_tag,
> 180 jint depth,
> 181 jmethodID method,
> 182 jint slot,
> 183 void* user_data) {
>
> iterreachobj004.cpp: Can you fix the indentation of the second line.
>
> 75 NSK_COMPLAIN2("heapRootCallback: Local storage was
> corrupted: %s ,\n\texpected value: %s\n",
> 76 (char *)storage_ptr, storage_data);
>
> 119 NSK_COMPLAIN2("stackReferenceCallback: Local storage
> was corrupted: %s ,\n\texpected value: %s\n",
> 120 (char *)storage_ptr, storage_data);
>
> 162 NSK_COMPLAIN2("objectReferenceCallback: Local storage
> was corrupted: %s ,\n\texpected value: %s\n",
> 163 (char *)storage_ptr, storage_data);
>
> thanks,
>
> Chris
>
> On 10/19/18 1:49 PM, JC Beyler wrote:
> > Hi all,
> >
> > Sorry about the spam; forgot to add the subject :)
> >
> > Here is the first of three webrevs to remove spaces around (); I
> > also removed any space after !.
> >
> > When the change modified where future parameters should be
> > indented, I changed those too (such as
> > http://cr.openjdk.java.net/~jcbeyler/8212535/webrev.00/test/hotspot/jtreg/vmTestba \
> > se/nsk/jvmti/IterateOverObjectsReachableFromObject/iterobjreachobj002/iterobjreach \
> > obj002.cpp.udiff.html<http://cr.openjdk.java.net/%7Ejcbeyler/8212535/webrev.00/tes \
> > t/hotspot/jtreg/vmTestbase/nsk/jvmti/IterateOverObjectsReachableFromObject/iterobjreachobj002/iterobjreachobj002.cpp.udiff.html>
> > <http://cr.openjdk.java.net/%7Ejcbeyler/8212535/webrev.00/test/hotspot/jtreg/vmTe \
> > stbase/nsk/jvmti/IterateOverObjectsReachableFromObject/iterobjreachobj002/iterobjreachobj002.cpp.udiff.html>)
> >
> > Webrev: http://cr.openjdk.java.net/~jcbeyler/8212535/webrev.00/<http://cr.openjdk.java.net/%7Ejcbeyler/8212535/webrev.00/>
> > <http://cr.openjdk.java.net/%7Ejcbeyler/8212535/webrev.00/>
> > Bug: https://bugs.openjdk.java.net/browse/JDK-8212535
> >
> > Thanks!
> > Jc
> >
> > On Fri, Oct 19, 2018 at 1:47 PM JC Beyler \
> > <jcbeyler@google.com<mailto:jcbeyler@google.com> \
> > <mailto:jcbeyler@google.com<mailto:jcbeyler@google.com>>> wrote:
> > Hi all,
> >
> > Here is the first of three webrevs to remove spaces around ();
> > I also removed any space after !.
> >
> > When the change modified where future parameters should be
> > indented, I changed those too (such as
> > http://cr.openjdk.java.net/~jcbeyler/8212535/webrev.00/test/hotspot/jtreg/vmTestba \
> > se/nsk/jvmti/IterateOverObjectsReachableFromObject/iterobjreachobj002/iterobjreach \
> > obj002.cpp.udiff.html<http://cr.openjdk.java.net/%7Ejcbeyler/8212535/webrev.00/tes \
> > t/hotspot/jtreg/vmTestbase/nsk/jvmti/IterateOverObjectsReachableFromObject/iterobjreachobj002/iterobjreachobj002.cpp.udiff.html>
> > <http://cr.openjdk.java.net/%7Ejcbeyler/8212535/webrev.00/test/hotspot/jtreg/vmTe \
> > stbase/nsk/jvmti/IterateOverObjectsReachableFromObject/iterobjreachobj002/iterobjreachobj002.cpp.udiff.html>)
> >
> > Webrev: https://bugs.openjdk.java.net/browse/JDK-8212535
> > Bug: https://bugs.openjdk.java.net/browse/JDK-8212535
> >
> > Let me know what you think,
> > Jc
> >
> >
>
>
>
> --
>
> Thanks,
> Jc
--
Thanks,
Jc
[Attachment #3 (text/html)]
<html xmlns:v="urn:schemas-microsoft-com:vml" \
xmlns:o="urn:schemas-microsoft-com:office:office" \
xmlns:w="urn:schemas-microsoft-com:office:word" \
xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" \
xmlns="http://www.w3.org/TR/REC-html40"> <head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
h2
{mso-style-priority:9;
mso-style-link:"Heading 2 Char";
mso-margin-top-alt:auto;
margin-right:0in;
mso-margin-bottom-alt:auto;
margin-left:0in;
font-size:18.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
pre
{mso-style-priority:99;
mso-style-link:"HTML Preformatted Char";
margin:0in;
margin-bottom:.0001pt;
font-size:10.0pt;
font-family:"Courier New";}
p.msonormal0, li.msonormal0, div.msonormal0
{mso-style-name:msonormal;
mso-margin-top-alt:auto;
margin-right:0in;
mso-margin-bottom-alt:auto;
margin-left:0in;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
span.EmailStyle18
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:windowtext;}
span.HTMLPreformattedChar
{mso-style-name:"HTML Preformatted Char";
mso-style-priority:99;
mso-style-link:"HTML Preformatted";
font-family:"Courier New";}
span.removed
{mso-style-name:removed;}
span.new
{mso-style-name:new;}
span.Heading2Char
{mso-style-name:"Heading 2 Char";
mso-style-priority:9;
mso-style-link:"Heading 2";
font-family:"Calibri",sans-serif;
font-weight:bold;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="blue" vlink="purple">
<div class="WordSection1">
<h2><span style="font-size:11.0pt;font-weight:normal">Lgtm. One nit in</span><span \
style="font-size:11.0pt;font-weight:normal"> libnativeGC01.cpp<o:p></o:p></span></h2> \
<p class="MsoNormal"><span style="font-size:10.0pt;font-family:"Courier \
New"">- * A C function that takes a reference to java Object( a circular Linked \
list)<o:p></o:p></span></p> <p class="MsoNormal"><span \
style="font-size:10.0pt;font-family:"Courier New"">+ * A C function \
that takes a reference to java Object(a circular Linked list)<o:p></o:p></span></p> \
<p class="MsoNormal"><o:p> </o:p></p> <p class="MsoNormal">=><o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<pre><span class="new">+ * A C function that takes a reference to java Object (a \
circular Linked list)</span><o:p></o:p></pre> <p \
class="MsoNormal"><o:p> </o:p></p> <p class="MsoNormal">No need for a new \
webrev.<o:p></o:p></p> <p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Paul<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span style="font-size:12.0pt;color:black">From: \
</span></b><span style="font-size:12.0pt;color:black">serviceability-dev \
<serviceability-dev-bounces@openjdk.java.net> on behalf of \
"serguei.spitsyn@oracle.com" <serguei.spitsyn@oracle.com><br> \
<b>Date: </b>Monday, October 22, 2018 at 2:40 PM<br> <b>To: </b>JC Beyler \
<jcbeyler@google.com>, "alexey.menkov@oracle.com" \
<alexey.menkov@oracle.com><br> <b>Cc: \
</b>"serviceability-dev@openjdk.java.net" \
<serviceability-dev@openjdk.java.net><br> <b>Subject: </b>Re: RFR (M) 8212535: \
Remove spaces before/after () for vmTestbase/[a-s]*<o:p></o:p></span></p> </div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">Hi Alex,<br>
<br>
It looks good.<br>
<br>
Thanks!<br>
Serguei<br>
<br>
<br>
On 10/22/18 12:56, JC Beyler wrote:<o:p></o:p></p>
</div>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<div>
<div>
<div>
<div>
<p class="MsoNormal">Hi Alex, <o:p></o:p></p>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">Done, I left this one:<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<div>
<p class="MsoNormal">- if \
(!NSK_JVMTI_VERIFY(<o:p></o:p></p> </div>
<div>
<p class="MsoNormal">- \
jvmti->IterateOverHeap(JVMTI_HEAP_OBJECT_EITHER, heapObjectCallback, (void \
*)user_data))) {<o:p></o:p></p> </div>
<div>
<p class="MsoNormal">+ if \
(!NSK_JVMTI_VERIFY(jvmti->IterateOverHeap(<o:p></o:p></p> </div>
<div>
<p class="MsoNormal">+ \
JVMTI_HEAP_OBJECT_EITHER, heapObjectCallback, (void *)user_data))) \
{<o:p></o:p></p> </div>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">The whole length was at 126 characters, it seemed a bit \
long:<o:p></o:p></p> </div>
<div>
<p class="MsoNormal"><a \
href="http://cr.openjdk.java.net/%7Ejcbeyler/8212535/webrev.02/test/hotspot/jtreg/vmTe \
stbase/nsk/jvmti/IterateOverHeap/iterheap007/iterheap007.cpp.udiff.html">http://cr.ope \
njdk.java.net/~jcbeyler/8212535/webrev.02/test/hotspot/jtreg/vmTestbase/nsk/jvmti/IterateOverHeap/iterheap007/iterheap007.cpp.udiff.html</a><o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">The new webrev is here:<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><a \
href="http://cr.openjdk.java.net/%7Ejcbeyler/8212535/webrev.02/">http://cr.openjdk.java.net/~jcbeyler/8212535/webrev.02/</a><o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">Thanks,<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal">Jc<o:p></o:p></p>
</div>
</div>
</div>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<div>
<p class="MsoNormal">On Mon, Oct 22, 2018 at 12:44 PM Alex Menkov <<a \
href="mailto:alexey.menkov@oracle.com" \
target="_blank">alexey.menkov@oracle.com</a>> wrote:<o:p></o:p></p> </div>
<blockquote style="margin-top:5.0pt;margin-bottom:5.0pt">
<p class="MsoNormal">Hi Jc,<br>
<br>
Looks good to me.<br>
Could you please update<br>
nsk/jvmti/IterateOverHeap/iterheap007/iterheap007.cpp :<br>
<br>
if (!NSK_JVMTI_VERIFY(<br>
- <jvmti_call>)) {<br>
+ <jvmti_call>)) {<br>
<br>
=><br>
if (!NSK_JVMTI_VERIFY(<jvmti_call>)) {<br>
<br>
As all <jvmti_call>s there are quite short.<br>
<br>
--alex<br>
<br>
<br>
On 10/19/2018 14:56, JC Beyler wrote:<br>
> Hi Chris,<br>
> <br>
> Done!<br>
> <br>
> Here is the newest version:<br>
> <a href="http://cr.openjdk.java.net/%7Ejcbeyler/8212535/webrev.01/" \
target="_blank"> http://cr.openjdk.java.net/~jcbeyler/8212535/webrev.01/</a> <br>
> <<a href="http://cr.openjdk.java.net/%7Ejcbeyler/8212535/webrev.01/" \
target="_blank">http://cr.openjdk.java.net/%7Ejcbeyler/8212535/webrev.01/</a>><br> \
> <br> > Thanks for the review!<br>
> Jc<br>
> <br>
> On Fri, Oct 19, 2018 at 2:24 PM Chris Plummer <<a \
href="mailto:chris.plummer@oracle.com" target="_blank">chris.plummer@oracle.com</a> \
<br> > <mailto:<a href="mailto:chris.plummer@oracle.com" \
target="_blank">chris.plummer@oracle.com</a>>> wrote:<br> > <br>
> Hi JC,<br>
> <br>
> iterinstcls006.cpp: Can you fix the indentation of the second \
line.<br> > <br>
> \
98 \
NSK_COMPLAIN2("Local storage was corrupted: %s<br> > \
,\n\texpected value: %s\n",<br> > \
99 \
\
(char *)storage_ptr, storage_data);<br> > <br>
> iterobjreachobj004.cpp: Can you fix the indentation of the \
second line.<br> > <br>
> \
123 \
NSK_COMPLAIN2("Local storage was corrupted: %s<br> > \
,\n\texpected value: %s\n",<br> > \
124   \
; \
(char *)storage_ptr, storage_data);<br> > <br>
> iterreachobj002.cpp: You didn't align the arguments like you \
have<br> > elsewhere.<br>
> <br>
> 175<br>
> stackReferenceCallbackForSecondObjectsIteration(jvmtiHeapRootKind<br>
> root_kind,<br>
> \
176 \
jlong class_tag,<br> > \
177 \
jlong size,<br> > \
178 \
jlong* tag_ptr,<br> > \
179 \
jlong thread_tag,<br> > \
180 \
jint depth,<br> > \
181 \
jmethodID method,<br> > \
182 \
jint slot,<br> > \
183 \
void* user_data) {<br> > <br>
> iterreachobj004.cpp: Can you fix the indentation of the \
second line.<br> > <br>
> 75 \
NSK_COMPLAIN2("heapRootCallback: Local storage was<br> > \
corrupted: %s ,\n\texpected value: %s\n",<br> > \
76 \
(char *)storage_ptr, storage_data);<br> > <br>
> 119 \
NSK_COMPLAIN2("stackReferenceCallback: Local storage<br> > \
was corrupted: %s ,\n\texpected value: %s\n",<br> > \
120 \
(char *)storage_ptr, storage_data);<br> > <br>
> 162 \
NSK_COMPLAIN2("objectReferenceCallback: Local storage<br> > \
was corrupted: %s ,\n\texpected value: %s\n",<br> > \
163 \
(char *)storage_ptr, storage_data);<br> > <br>
> thanks,<br>
> <br>
> Chris<br>
> <br>
> On 10/19/18 1:49 PM, JC Beyler wrote:<br>
>> Hi all,<br>
>><br>
>> Sorry about the spam; forgot to add the subject :)<br>
>><br>
>> Here is the first of three webrevs to remove spaces \
around (); I<br> >> also removed any space after !.<br>
>><br>
>> When the change modified where future parameters should \
be<br> >> indented, I changed those too (such as<br>
>> <a \
href="http://cr.openjdk.java.net/%7Ejcbeyler/8212535/webrev.00/test/hotspot/jtreg/vmTe \
stbase/nsk/jvmti/IterateOverObjectsReachableFromObject/iterobjreachobj002/iterobjreachobj002.cpp.udiff.html" \
target="_blank">http://cr.openjdk.java.net/~jcbeyler/8212535/webrev.00/test/hotspot/jt \
reg/vmTestbase/nsk/jvmti/IterateOverObjectsReachableFromObject/iterobjreachobj002/iterobjreachobj002.cpp.udiff.html</a><br>
>> <<a \
href="http://cr.openjdk.java.net/%7Ejcbeyler/8212535/webrev.00/test/hotspot/jtreg/vmTe \
stbase/nsk/jvmti/IterateOverObjectsReachableFromObject/iterobjreachobj002/iterobjreachobj002.cpp.udiff.html" \
target="_blank">http://cr.openjdk.java.net/%7Ejcbeyler/8212535/webrev.00/test/hotspot/ \
jtreg/vmTestbase/nsk/jvmti/IterateOverObjectsReachableFromObject/iterobjreachobj002/iterobjreachobj002.cpp.udiff.html</a>>)<br>
>><br>
>> Webrev: <a \
href="http://cr.openjdk.java.net/%7Ejcbeyler/8212535/webrev.00/" target="_blank"> \
http://cr.openjdk.java.net/~jcbeyler/8212535/webrev.00/</a><br> >> \
<<a href="http://cr.openjdk.java.net/%7Ejcbeyler/8212535/webrev.00/" \
target="_blank">http://cr.openjdk.java.net/%7Ejcbeyler/8212535/webrev.00/</a>><br> \
>> Bug: <a \
href="https://bugs.openjdk.java.net/browse/JDK-8212535" target="_blank"> \
https://bugs.openjdk.java.net/browse/JDK-8212535</a><br> >><br>
>> Thanks!<br>
>> Jc<br>
>><br>
>> On Fri, Oct 19, 2018 at 1:47 PM JC Beyler <<a \
href="mailto:jcbeyler@google.com" target="_blank">jcbeyler@google.com</a><br> \
>> <mailto:<a href="mailto:jcbeyler@google.com" \
target="_blank">jcbeyler@google.com</a>>> wrote:<br> >><br>
>> Hi all,<br>
>><br>
>> Here is the first of three webrevs to \
remove spaces around ();<br> >> I also removed \
any space after !.<br> >><br>
>> When the change modified where future \
parameters should be<br> >> indented, I \
changed those too (such as<br> >> <a \
href="http://cr.openjdk.java.net/%7Ejcbeyler/8212535/webrev.00/test/hotspot/jtreg/vmTe \
stbase/nsk/jvmti/IterateOverObjectsReachableFromObject/iterobjreachobj002/iterobjreachobj002.cpp.udiff.html" \
target="_blank">http://cr.openjdk.java.net/~jcbeyler/8212535/webrev.00/test/hotspot/jt \
reg/vmTestbase/nsk/jvmti/IterateOverObjectsReachableFromObject/iterobjreachobj002/iterobjreachobj002.cpp.udiff.html</a><br>
>> <<a \
href="http://cr.openjdk.java.net/%7Ejcbeyler/8212535/webrev.00/test/hotspot/jtreg/vmTe \
stbase/nsk/jvmti/IterateOverObjectsReachableFromObject/iterobjreachobj002/iterobjreachobj002.cpp.udiff.html" \
target="_blank">http://cr.openjdk.java.net/%7Ejcbeyler/8212535/webrev.00/test/hotspot/ \
jtreg/vmTestbase/nsk/jvmti/IterateOverObjectsReachableFromObject/iterobjreachobj002/iterobjreachobj002.cpp.udiff.html</a>>)<br>
>><br>
>> Webrev: <a \
href="https://bugs.openjdk.java.net/browse/JDK-8212535" target="_blank"> \
https://bugs.openjdk.java.net/browse/JDK-8212535</a><br> >> \
Bug: <a href="https://bugs.openjdk.java.net/browse/JDK-8212535" \
target="_blank"> https://bugs.openjdk.java.net/browse/JDK-8212535</a><br>
>><br>
>> Let me know what you think,<br>
>> Jc<br>
>><br>
>><br>
> <br>
> <br>
> <br>
> -- <br>
> <br>
> Thanks,<br>
> Jc<o:p></o:p></p>
</blockquote>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<p class="MsoNormal">-- <o:p></o:p></p>
<div>
<div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<p class="MsoNormal">Thanks, <o:p></o:p></p>
<div>
<p class="MsoNormal">Jc<o:p></o:p></p>
</div>
</div>
</div>
</blockquote>
<p class="MsoNormal"><br>
<br>
<o:p></o:p></p>
</div>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic