[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    =?UTF-8?Q?Re:_=d0=9a=d0=90=d0=9a_JDK-8212665:_com/sun/jdi/DeferredS?= =?UTF-8?Q?tepTest.java:_jj1_=2
From:       "serguei.spitsyn () oracle ! com" <serguei ! spitsyn () oracle ! com>
Date:       2018-10-22 21:40:00
Message-ID: 89dbf562-0221-5ced-a6c3-544047d41b4c () oracle ! com
[Download RAW message or body]

LGTM

Thanks,
Serguei


On 10/22/18 14:38, Alex Menkov wrote:
> Hi Jc, Gary, Serguei,
>
> Just for the record, updated webrev:
> http://cr.openjdk.java.net/~amenkov/deferredStep_endOfCycle/webrev.01
>
> (spaces are added, "steps" in the comment is replaced with "stops")
>
> --alex
>
> On 10/22/2018 13:10, serguei.spitsyn@oracle.com wrote:
>> Hi Alex,
>>
>> The fix looks good.
>> +1 for the Jc's suggestion to add spacing to the line:
>>
>>     176                 for (int i=0; i<50; i++) {
>>
>> Thanks,
>> Serguei
>>
>>
>> On 10/18/18 15:42, Alex Menkov wrote:
>>> Hi all,
>>>
>>> Please review small test fix for
>>> https://bugs.openjdk.java.net/browse/JDK-8212665
>>> webrev:
>>> http://cr.openjdk.java.net/~amenkov/deferredStep_endOfCycle/webrev/
>>>
>>> The test verifies that after "next" command debugger always stops in 
>>> the position within loops. Each thread has maximum 40 stops (10 
>>> iterations, 4 lines each), but with 50 "next" command it's possible 
>>> that one of the thread exits the loop.
>>> The fix increments loops to make 15 iterations, so each thread has 
>>> more than 50 stops.
>>>
>>> --alex
>>

[prev in list] [next in list] [prev in thread] [next in thread]