[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re:
From:       Martin Buchholz <martinrb () google ! com>
Date:       2018-10-19 21:43:22
Message-ID: CA+kOe088AWnz+amtS-W1MDjvMWutaXR3gk96EbWL6PwbumB_ag () mail ! gmail ! com
[Download RAW message or body]

Whenever I change only whitespace, I run a variant of

hg diff -wbB

to more easily see that it's truly only whitespace that has changed.

On Fri, Oct 19, 2018 at 1:47 PM, JC Beyler <jcbeyler@google.com> wrote:

> Hi all,
>
> Here is the first of three webrevs to remove spaces around (); I also
> removed any space after !.
>
> When the change modified where future parameters should be indented, I
> changed those too (such as http://cr.openjdk.java.net/
> ~jcbeyler/8212535/webrev.00/test/hotspot/jtreg/vmTestbase/nsk/jvmti/
> IterateOverObjectsReachableFromObject/iterobjreachobj002/
> iterobjreachobj002.cpp.udiff.html)
>
> Webrev: https://bugs.openjdk.java.net/browse/JDK-8212535
> Bug: https://bugs.openjdk.java.net/browse/JDK-8212535
>
> Let me know what you think,
> Jc
>

[Attachment #3 (text/html)]

<div dir="ltr">Whenever I change only whitespace, I run a variant \
of<div><br></div><div>hg diff -wbB</div><div><br></div><div>to more easily see that \
it&#39;s truly only whitespace that has changed.</div></div><div \
class="gmail_extra"><br><div class="gmail_quote">On Fri, Oct 19, 2018 at 1:47 PM, JC \
Beyler <span dir="ltr">&lt;<a href="mailto:jcbeyler@google.com" \
target="_blank">jcbeyler@google.com</a>&gt;</span> wrote:<br><blockquote \
class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"><div dir="ltr"><div dir="ltr"><div dir="ltr"><div \
dir="ltr"><div>Hi all,</div><div><br></div><div>Here is the first of three webrevs to \
remove spaces around (); I also removed any space after \
!.</div><div><br></div><div>When the change modified where future parameters should \
be indented, I changed those too (such as  <a \
href="http://cr.openjdk.java.net/~jcbeyler/8212535/webrev.00/test/hotspot/jtreg/vmTest \
base/nsk/jvmti/IterateOverObjectsReachableFromObject/iterobjreachobj002/iterobjreachobj002.cpp.udiff.html" \
target="_blank">http://cr.openjdk.java.net/<wbr>~jcbeyler/8212535/webrev.00/<wbr>test/ \
hotspot/jtreg/vmTestbase/<wbr>nsk/jvmti/<wbr>IterateOverObjectsReachableFro<wbr>mObjec \
t/iterobjreachobj002/<wbr>iterobjreachobj002.cpp.udiff.<wbr>html</a>)</div><div><br></div>Webrev: \
<a href="https://bugs.openjdk.java.net/browse/JDK-8212535" \
target="_blank">https://bugs.openjdk.<wbr>java.net/browse/JDK-8212535</a></div><div \
dir="ltr">Bug:  <a href="https://bugs.openjdk.java.net/browse/JDK-8212535" \
target="_blank">https://bugs.openjdk.<wbr>java.net/browse/JDK-8212535</a><br \
clear="all"><div><br></div><div dir="ltr"><div dir="ltr">Let me know what you \
think,<div>Jc</div></div></div></div></div></div></div> </blockquote></div><br></div>



[prev in list] [next in list] [prev in thread] [next in thread]