[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR JDK-8203928: [Test] Convert non-JDB scaffolding serviceability shell script tests to java
From:       JC Beyler <jcbeyler () google ! com>
Date:       2018-09-27 22:43:34
Message-ID: CAF9BGBxe3x1b9Gq6E41uN0ZjPNu+x0Lf+xMFPAxoQX8-QUCuGw () mail ! gmail ! com
[Download RAW message or body]

Hi Alex,

Looks good to me, I especially liked the simplification of
the PrivateTransportTest :)
Jc

On Thu, Sep 27, 2018 at 2:33 PM Alex Menkov <alexey.menkov@oracle.com>
wrote:

> Hi all,
>
> please review a fix for
> https://bugs.openjdk.java.net/browse/JDK-8203928
> webrev:
> http://cr.openjdk.java.net/~amenkov/sh2java/non-jdb/webrev.01/
>
> Some details:
>
> ImmutableResourceTest.java
>    - required compile/run args are specified by using jtreg tag options;
>
> JITDebug.java
>    - was not able to reproduce failures described (looks like that it's
> something ancient). Actually we use dt_socket transport on Windows for a
> long time without any issues;
>    - replaced Runtime.exec with ProcessBuilder, used some /test/lib
> stuff, fixed some minor issues;
>
> connect/spi/JdiLoadedByCustomLoader.java
> redefine/RedefineTest.java
> redefineMethod/RedefineTest.java
>    - implemented compilation tasks in java, removed shell files;
>
> PrivateTransportTest.java (was
> test/jdk/com/sun/jdi/PrivateTransportTest.sh)
>    - just converted the test from shell to java.
>
> --alex
>


-- 

Thanks,
Jc

[Attachment #3 (text/html)]

<div dir="ltr"><div dir="ltr">Hi Alex,<div><br></div><div>Looks good to me, I \
especially liked the simplification of the  PrivateTransportTest \
:)</div><div>Jc</div></div></div><br><div class="gmail_quote"><div dir="ltr">On Thu, \
Sep 27, 2018 at 2:33 PM Alex Menkov &lt;<a \
href="mailto:alexey.menkov@oracle.com">alexey.menkov@oracle.com</a>&gt; \
wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 \
.8ex;border-left:1px #ccc solid;padding-left:1ex">Hi all,<br> <br>
please review a fix for<br>
<a href="https://bugs.openjdk.java.net/browse/JDK-8203928" rel="noreferrer" \
target="_blank">https://bugs.openjdk.java.net/browse/JDK-8203928</a><br> webrev:<br>
<a href="http://cr.openjdk.java.net/~amenkov/sh2java/non-jdb/webrev.01/" \
rel="noreferrer" target="_blank">http://cr.openjdk.java.net/~amenkov/sh2java/non-jdb/webrev.01/</a><br>
 <br>
Some details:<br>
<br>
ImmutableResourceTest.java<br>
     - required compile/run args are specified by using jtreg tag options;<br>
<br>
JITDebug.java<br>
     - was not able to reproduce failures described (looks like that it&#39;s <br>
something ancient). Actually we use dt_socket transport on Windows for a <br>
long time without any issues;<br>
     - replaced Runtime.exec with ProcessBuilder, used some /test/lib <br>
stuff, fixed some minor issues;<br>
<br>
connect/spi/JdiLoadedByCustomLoader.java<br>
redefine/RedefineTest.java<br>
redefineMethod/RedefineTest.java<br>
     - implemented compilation tasks in java, removed shell files;<br>
<br>
PrivateTransportTest.java (was test/jdk/com/sun/jdi/PrivateTransportTest.sh)<br>
     - just converted the test from shell to java.<br>
<br>
--alex<br>
</blockquote></div><br clear="all"><div><br></div>-- <br><div dir="ltr" \
class="gmail_signature" data-smartmail="gmail_signature"><div \
dir="ltr"><div><br></div>Thanks,<div>Jc</div></div></div>



[prev in list] [next in list] [prev in thread] [next in thread]