[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-serviceability-dev
Subject: Re: [CAUTION] RFR : 8211146 : fix problematic elif-tests after recent gcc warning changes Werror=und
From: David Holmes <david.holmes () oracle ! com>
Date: 2018-09-26 11:41:23
Message-ID: 9af9d8c2-2580-0f25-2881-f4d76b2596a9 () oracle ! com
[Download RAW message or body]
That all seems fine to me.
Thanks for fixing.
David
On 26/09/2018 5:48 AM, Langer, Christoph wrote:
> Hi Matthias,
>
> looks good (and trivial). Ccing serviceability-dev because of change in
> libjdwp.
>
> Best regards
>
> Christoph
>
> *From:*nio-dev <nio-dev-bounces@openjdk.java.net> *On Behalf Of
> *Baesken, Matthias
> *Sent:* Mittwoch, 26. September 2018 11:25
> *To:* 'build-dev@openjdk.java.net' <build-dev@openjdk.java.net>; net-dev
> <net-dev@openjdk.java.net>; nio-dev@openjdk.java.net
> *Cc:* Lindenmaier, Goetz <goetz.lindenmaier@sap.com>; Schmidt, Lutz
> <lutz.schmidt@sap.com>
> *Subject:* [CAUTION] RFR : 8211146 : fix problematic elif-tests after
> recent gcc warning changes Werror=undef
>
> Hello, please review this small build fix .
>
> After the recent changes to the gcc compile flags with 8211029
> , most of our Linux builds stopped working .
>
> Error :
>
> === Output from failing command(s) repeated here ===
>
> * For target support_native_java.base_libnet_DatagramPacket.o:
>
> In file included from
> /OpenJDK/8210319/jdk/src/java.base/share/native/libnet/net_util.h:31:0,
>
> from
> /OpenJDK/8210319/jdk/src/java.base/share/native/libnet/DatagramPacket.c:27:
>
> /OpenJDK/8210319/jdk/src/java.base/unix/native/libnet/net_util_md.h:50:7: error:
> "__solaris__" is not defined [-Werror=undef]
>
> #elif __solaris__
>
> ^
>
> After looking into it, it seems that the
> jdk/src/java.base/unix/native/libnet/net_util_md.h compile error is
> only triggered on older Linux OS (e.g. SLES11).
>
> Probably that’s why it was not seen at Oracle after puhsing after
> 8211029 .
>
> Some greps showed me a number of similar problematic #elif-checks for
> OS, I adjusted them too .
>
> Bug / webrev :
>
> https://bugs.openjdk.java.net/browse/JDK-8211146
>
> http://cr.openjdk.java.net/~mbaesken/webrevs/8211146.0/
> <http://cr.openjdk.java.net/%7Embaesken/webrevs/8211146.0/>
>
> Thanks, Matthias
>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic