[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR(XS): JDK-8210987: Extra newlines on Windows when running nsk jdb tests
From:       Alex Menkov <alexey.menkov () oracle ! com>
Date:       2018-09-21 22:44:57
Message-ID: 022e6583-ab9c-9012-3bd9-9d9c492bf352 () oracle ! com
[Download RAW message or body]

+1

--alex

On 09/21/2018 14:19, JC Beyler wrote:
> Hi Chris,
> 
> Looks good to me!
> 
> Thanks,
> Jc
> 
> On Fri, Sep 21, 2018 at 1:47 PM Chris Plummer <chris.plummer@oracle.com 
> <mailto:chris.plummer@oracle.com>> wrote:
> 
>     Hi,
> 
>     Please review the following:
> 
>     https://bugs.openjdk.java.net/browse/JDK-8210987
>     http://cr.openjdk.java.net/~cjplummer/8210987/webrev.00/
>     <http://cr.openjdk.java.net/%7Ecjplummer/8210987/webrev.00/>
> 
>     Here's an example of some "before" output on windows:
> 
>      > Sending command: cont
>      >
>      > reply[0]: >
>      > reply[1]:
>      > Method entered: "thread=MyThread-1",
>     java.util.Locale.getDefault(), line=910 bci=0
>      > reply[2]:
>      >
>      > reply[3]:
>      > MyThread-1[1]
> 
>     And the same output after the fix:
> 
>      > Sending command: cont
>      > reply[0]: >
>      > reply[1]: Method entered: "thread=MyThread-1",
>     java.util.Locale.getDefault(), line=910 bci=0
>      > reply[2]:
>      > reply[3]: MyThread-1[1]
> 
>     And this also matches the output we've been seeing on the unix
>     platforms.
> 
>     thanks,
> 
>     Chris
> 
> 
> 
> -- 
> 
> Thanks,
> Jc
[prev in list] [next in list] [prev in thread] [next in thread]