[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR (XS) 8210726: Fix up a few minor nits forgotten by JDK-8210665
From:       serguei.spitsyn () oracle ! com
Date:       2018-09-17 7:10:52
Message-ID: 29737cb4-5729-3b8f-785e-f4329f66d4c0 () oracle ! com
[Download RAW message or body]

Hi Jc,

+1

Thanks,
Serguei


On 9/14/18 10:54 AM, Chris Plummer wrote:
> One minor issue. There's an extra space in the following line:
>
>   157                         fields[i].fid = env-> GetStaticFieldID(cls, 
> fields[i].name, fields[i].sig);
>
> Chris
>
> On 9/14/18 9:49 AM, JC Beyler wrote:
>> Hi all,
>>
>> When doing the work for  JDK-8210665, I got confused with the webrevs 
>> and forgot to add Serguei's nits for the patch. I apologize for that 
>> and here they are in a separate bug.
>>
>> Could I get a review for it?
>>
>> Webrev: http://cr.openjdk.java.net/~jcbeyler/8210726/webrev.00/ 
>> <http://cr.openjdk.java.net/%7Ejcbeyler/8210726/webrev.00/>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8210726
>>
>> Thanks and sorry again,
>> Jc
>
>


[Attachment #3 (text/html)]

<html>
  <head>
    <meta http-equiv="Content-Type" content="text/html; charset=utf-8">
  </head>
  <body bgcolor="#FFFFFF" text="#000000">
    Hi Jc,<br>
    <br>
    +1<br>
    <br>
    Thanks,<br>
    Serguei<br>
    <br>
    <br>
    <div class="moz-cite-prefix">On 9/14/18 10:54 AM, Chris Plummer
      wrote:<br>
    </div>
    <blockquote type="cite"
      cite="mid:d8a65a77-ede5-1adc-2ddc-d04b95e59378@oracle.com">
      <meta http-equiv="Content-Type" content="text/html; charset=utf-8">
      <div class="moz-cite-prefix">One minor issue. There's an extra
        space in the following line:<br>
        <br>
          157                         fields[i].fid = env-&gt; GetStaticFieldID(cls,
        fields[i].name, fields[i].sig);<br>
        <br>
        Chris<br>
        <br>
        On 9/14/18 9:49 AM, JC Beyler wrote:<br>
      </div>
      <blockquote type="cite"
cite="mid:CAF9BGBzfOap8Eq_apWf_=e+XDcT0kyRK9Ae5EtT2VYc2NWtcxw@mail.gmail.com">
        <meta http-equiv="content-type" content="text/html;
          charset=utf-8">
        <div dir="ltr">
          <div dir="ltr">
            <div dir="ltr">
              <div>Hi all,</div>
              <div><br>
              </div>
              <div>When doing the work for  JDK-8210665, I got confused
                with the webrevs and forgot to add Serguei's nits for
                the patch. I apologize for that and here they are in a
                separate bug.</div>
              <div><br>
              </div>
              <div>Could I get a review for it?</div>
              <div><br>
              </div>
              <div dir="ltr">Webrev:  <a
                  href="http://cr.openjdk.java.net/%7Ejcbeyler/8210726/webrev.00/"
                  target="_blank" \
moz-do-not-send="true">http://cr.openjdk.java.net/~jcbeyler/8210726/webrev.00/</a></div>
  <div dir="ltr">Bug:  <a
                  href="https://bugs.openjdk.java.net/browse/JDK-8210726"
                  target="_blank" \
moz-do-not-send="true">https://bugs.openjdk.java.net/browse/JDK-8210726</a></div>  \
<div dir="ltr"><br clear="all">  <div>Thanks and sorry again,<br>
                </div>
                <div dir="ltr"
                  class="m_831480963062267845m_-4624036937475291803gmail_signature">
                  <div dir="ltr">
                    <div>Jc</div>
                  </div>
                </div>
              </div>
            </div>
          </div>
        </div>
      </blockquote>
      <p><br>
      </p>
    </blockquote>
    <br>
  </body>
</html>



[prev in list] [next in list] [prev in thread] [next in thread]

Configure | About | News | Add a list | Sponsored by KoreLogic