[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-serviceability-dev
Subject: Re: RFR(XXS) : 8210108 : sun/tools/jstatd test build failures after JDK-8210022
From: Chris Plummer <chris.plummer () oracle ! com>
Date: 2018-08-28 21:26:19
Message-ID: 2f79c6ea-4f02-4e82-8c68-860f0c417bda () oracle ! com
[Download RAW message or body]
<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<div class="moz-cite-prefix">Looks good.<br>
<br>
Chris<br>
<br>
On 8/28/18 1:35 PM, Igor Ignatyev wrote:<br>
</div>
<blockquote type="cite"
cite="mid:0ED3AED5-2AB2-49D5-A98B-F0851A611A73@oracle.com">
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
JC, Mikael,
<div class=""><br class="">
</div>
<div class="">thanks for reviewing.</div>
<div class=""><br class="">
</div>
<div class="">still need a Review from a Reviewer though.</div>
<div class=""><br class="">
</div>
<div class="">-- Igor<br class="">
<div><br class="">
<blockquote type="cite" class="">
<div class="">On Aug 28, 2018, at 1:30 PM, JC Beyler <<a
href="mailto:jcbeyler@google.com" class=""
moz-do-not-send="true">jcbeyler@google.com</a>>
wrote:</div>
<br class="Apple-interchange-newline">
<div class="">
<div dir="ltr" class="">Hi Igor,
<div class=""><br class="">
</div>
<div class="">Looks good to me,</div>
<div class="">Jc</div>
</div>
<br class="">
<div class="gmail_quote">
<div dir="ltr" class="">On Tue, Aug 28, 2018 at 1:19 PM
Mikael Vidstedt <<a
href="mailto:mikael.vidstedt@oracle.com" class=""
moz-do-not-send="true">mikael.vidstedt@oracle.com</a>>
wrote:<br class="">
</div>
<blockquote class="gmail_quote" style="margin:0 0 0
.8ex;border-left:1px #ccc solid;padding-left:1ex"><br
class="">
Looks good, thanks for fixing!<br class="">
<br class="">
Cheers,<br class="">
Mikael<br class="">
<br class="">
> On Aug 28, 2018, at 11:57 AM, Igor Ignatyev <<a
href="mailto:igor.ignatyev@oracle.com"
target="_blank" class="" \
moz-do-not-send="true">igor.ignatyev@oracle.com</a>> wrote:<br class="">
> <br class="">
> <a
href="http://cr.openjdk.java.net/%7Eiignatyev//8210108/webrev.00/index.html"
rel="noreferrer" target="_blank" class=""
moz-do-not-send="true">http://cr.openjdk.java.net/~iignatyev//8210108/webrev.00/index.html</a><br
class="">
>> 3 lines changed: 1 ins; 1 del; 1 mod; <br
class="">
> <br class="">
> <br class="">
> Hi all,<br class="">
> <br class="">
> could you please review this small and trivial
follow-up fix?<br class="">
> <br class="">
> unfortunately,
test/jdk/sun/tools/jstatd/JstatdTest now uses two
different OutputAnalyzer classes,
jdk.test.lib.process.OutputAnalyzer which it gets from
jdk.test.lib.process.ProcessThread, and
jdk.testlibrary.OutputAnalyzer from
jdk.testlibrary.ProcessTools. as JstatdTest uses
j.t.OutputAnalyzer more often, the fix restores import
statement and uses FQDN where
j.t.l.process.OutputAnalyzer is used.<br class="">
> <br class="">
> // we will get rid of this FQDN, as soon as
jdk.testlibrary.ProcessTools is "merged" w/
jdk.t.l.process.ProcessTools, which is tracked by
8210112.<br class="">
> <br class="">
> JBS: <a
href="https://bugs.openjdk.java.net/browse/JDK-8210108"
rel="noreferrer" target="_blank" class=""
moz-do-not-send="true">https://bugs.openjdk.java.net/browse/JDK-8210108</a><br
class="">
> webrev: <a
href="http://cr.openjdk.java.net/%7Eiignatyev//8210108/webrev.00/index.html"
rel="noreferrer" target="_blank" class=""
moz-do-not-send="true">http://cr.openjdk.java.net/~iignatyev//8210108/webrev.00/index.html</a><br
class="">
> testing: sun/tools/jstatd tests<br class="">
> <br class="">
> Thanks,<br class="">
> -- Igor<br class="">
<br class="">
</blockquote>
</div>
<br class="" clear="all">
<div class=""><br class="">
</div>
-- <br class="">
<div dir="ltr" class="gmail_signature"
data-smartmail="gmail_signature">
<div dir="ltr" class="">
<div class=""><br class="">
</div>
Thanks,
<div class="">Jc</div>
</div>
</div>
</div>
</blockquote>
</div>
<br class="">
</div>
</blockquote>
<p><br>
</p>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic