[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-serviceability-dev
Subject: Re: RFR (S) 8203356: VM Object Allocation Collector can infinite recurse
From: JC Beyler <jcbeyler () google ! com>
Date: 2018-08-28 4:01:01
Message-ID: CAF9BGBxs7VUAZcjjBVjASELecWMU=A2+tR+tsEGBMQyq0Pnh0A () mail ! gmail ! com
[Download RAW message or body]
Hi Chris,
Thanks for looking at the webrev. I fixed the copyrights for the files here
and also created https://bugs.openjdk.java.net/browse/JDK-8210035 because I
saw that files I created for the HeapMonitor work have the same issue. I'll
send out a webrev shortly to fix those.
Thanks again!
Jc
On Mon, Aug 27, 2018 at 3:39 PM Chris Plummer <chris.plummer@oracle.com>
wrote:
> Hi JC,
>
> The jvmtiExport.cpp changes look fine, but I'm no expert in this area.
>
> I think you need to fix the copyrights in the new files. My understanding
> is they need to include the Oracle copyright. Search for examples from "Red
> Hat" and "SAP" to see what I mean.
>
> I'm not sure about the nbproject changes. I've never seen this file get
> updated before.
>
> thanks,
>
> Chris
>
> On 8/22/18 4:20 PM, JC Beyler wrote:
>
> Hi all,
>
> Would anyone want to look at this change? It helps fix a minor bug if
> someone provokes a VM allocation during a VM Allocation Event.
>
> Webrev: http://cr.openjdk.java.net/~jcbeyler/8203356/webrev.00/
> Bug: https://bugs.openjdk.java.net/browse/JDK-8203356
>
> Thanks!
> Jc
>
> On Thu, Aug 2, 2018 at 12:46 PM JC Beyler <jcbeyler@google.com> wrote:
>
>> Hi all,
>>
>> (Renaming the thread that did not have the RFR in front of the subject, I
>> apologize)
>>
>> Could someone review this change:
>>
>> Webrev: http://cr.openjdk.java.net/~jcbeyler/8203356/webrev.00/
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8203356
>>
>> Basically, if during a callback from a VMObjectAlloc event, the user
>> provokes a clone, the code would send a new callback and you can recurse
>> infinitely.
>>
>> I added a test that fails without the fix and passes now.
>>
>> Thanks,
>> Jc
>>
>
>
> --
>
> Thanks,
> Jc
>
>
>
--
Thanks,
Jc
[Attachment #3 (text/html)]
<div dir="ltr">Hi Chris,<div><br></div><div>Thanks for looking at the webrev. I fixed \
the copyrights for the files here and also created <a \
href="https://bugs.openjdk.java.net/browse/JDK-8210035">https://bugs.openjdk.java.net/browse/JDK-8210035</a> \
because I saw that files I created for the HeapMonitor work have the same issue. \
I'll send out a webrev shortly to fix those.</div><div><br></div><div>Thanks \
again!</div><div>Jc</div></div><br><div class="gmail_quote"><div dir="ltr">On Mon, \
Aug 27, 2018 at 3:39 PM Chris Plummer <<a \
href="mailto:chris.plummer@oracle.com">chris.plummer@oracle.com</a>> \
wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 \
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<div text="#000000" bgcolor="#FFFFFF">
<div class="m_6214233416943672707moz-cite-prefix">Hi JC,<br>
<br>
The jvmtiExport.cpp changes look fine, but I'm no expert in this
area.<br>
<br>
I think you need to fix the copyrights in the new files. My
understanding is they need to include the Oracle copyright. Search
for examples from "Red Hat" and "SAP" to see what I \
mean.<br> <br>
I'm not sure about the nbproject changes. I've never seen this
file get updated before.<br>
<br>
thanks,<br>
<br>
Chris<br>
<br>
On 8/22/18 4:20 PM, JC Beyler wrote:<br>
</div>
<blockquote type="cite">
<div dir="ltr">Hi all,<br>
<div><br>
</div>
<div>Would anyone want to look at this change? It helps fix a
minor bug if someone provokes a VM allocation during a VM
Allocation Event.</div>
<div><br>
</div>
<div>Webrev: <a \
href="http://cr.openjdk.java.net/%7Ejcbeyler/8203356/webrev.00/" \
target="_blank">http://cr.openjdk.java.net/~jcbeyler/8203356/webrev.00/</a><br \
clear="all">
<div>Bug: <a href="https://bugs.openjdk.java.net/browse/JDK-8203356" \
target="_blank">https://bugs.openjdk.java.net/browse/JDK-8203356</a></div> </div>
<div><br>
</div>
<div>Thanks!</div>
<div>Jc</div>
</div>
<br>
<div class="gmail_quote">
<div dir="ltr">On Thu, Aug 2, 2018 at 12:46 PM JC Beyler <<a \
href="mailto:jcbeyler@google.com" target="_blank">jcbeyler@google.com</a>> \
wrote:<br> </div>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc \
solid;padding-left:1ex"> <div dir="ltr">Hi all,
<div><br>
</div>
<div>(Renaming the thread that did not have the RFR in front
of the subject, I apologize)</div>
<div><br>
</div>
<div>Could someone review this change:</div>
<div><br>
</div>
<div>Webrev: <a \
href="http://cr.openjdk.java.net/%7Ejcbeyler/8203356/webrev.00/" \
target="_blank">http://cr.openjdk.java.net/~jcbeyler/8203356/webrev.00/</a><br \
clear="all">
<div>Bug: <a href="https://bugs.openjdk.java.net/browse/JDK-8203356" \
target="_blank">https://bugs.openjdk.java.net/browse/JDK-8203356</a></div> <div><br>
</div>
<div>Basically, if during a callback from a VMObjectAlloc
event, the user provokes a clone, the code would send a
new callback and you can recurse infinitely.</div>
<div><br>
</div>
<div>I added a test that fails without the fix and passes
now.</div>
<div><br>
</div>
<div dir="ltr" \
class="m_6214233416943672707m_5265400520167476713gmail-m_1857162544524225239gmail_signature">
<div dir="ltr">Thanks,
<div>Jc</div>
</div>
</div>
</div>
</div>
</blockquote>
</div>
<br clear="all">
<div><br>
</div>
-- <br>
<div dir="ltr" class="m_6214233416943672707gmail_signature" \
data-smartmail="gmail_signature"> <div dir="ltr">
<div><br>
</div>
Thanks,
<div>Jc</div>
</div>
</div>
</blockquote>
<p><br>
</p>
</div>
</blockquote></div><br clear="all"><div><br></div>-- <br><div dir="ltr" \
class="gmail_signature" data-smartmail="gmail_signature"><div \
dir="ltr"><div><br></div>Thanks,<div>Jc</div></div></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic