[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR(S) : 8210022 : remove jdk.testlibrary.ProcessThread, TestThread and XRun
From:       "serguei.spitsyn () oracle ! com" <serguei ! spitsyn () oracle ! com>
Date:       2018-08-28 3:11:23
Message-ID: f9cbd900-3ba4-45b9-b817-702fbd9d5b93 () oracle ! com
[Download RAW message or body]

Hi Igor,

It looks good.
The copyright comment needs an update:
http://cr.openjdk.java.net/~iignatyev//8210022/webrev.00/test/jdk/com/sun/tools/attach/ProviderTest.java.frames.html


Thanks,
Serguei


On 8/27/18 17:32, Igor Ignatyev wrote:
> http://cr.openjdk.java.net/~iignatyev//8210022/webrev.00/index.html
> > 303 lines changed: 21 ins; 266 del; 16 mod;
> Hi all,
> 
> could you please review the testlibrary clean up which removes \
> jdk.testlibrary.ProcessThread, TestThread and XRun classes and update all their \
> users to use the same classes from jdk.test.lib.thread package. 
> JBS: https://bugs.openjdk.java.net/browse/JDK-8210022
> webrev: http://cr.openjdk.java.net/~iignatyev//8210022/webrev.00/index.html
> testing: changed tests + jdk-tier[1-3] (in progress)
> 
> Thanks,
> -- Igor


[prev in list] [next in list] [prev in thread] [next in thread]