[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR(XS) : 8186548 : move jdk.testlibrary.JcmdBase closer to tests
From:       "serguei.spitsyn () oracle ! com" <serguei ! spitsyn () oracle ! com>
Date:       2018-08-28 3:04:28
Message-ID: 0b8098e0-3629-c89f-2d32-3e4e75e29b49 () oracle ! com
[Download RAW message or body]

+1

Thanks,
Serguei

On 8/27/18 16:16, Alex Menkov wrote:
> +1
>
> --alex
>
> On 08/27/2018 15:41, Chris Plummer wrote:
>> Looks good.
>>
>> Chris
>>
>> On 8/27/18 3:37 PM, Igor Ignatyev wrote:
>>> http://cr.openjdk.java.net/~iignatyev//8186548/webrev.00/index.html
>>>> 10 lines changed: 4 ins; 4 del; 2 mod;
>>> Hi all,
>>>
>>> could you please review this small patch which puts JcmdBase into 
>>> the directory w/ the only two tests which use it?
>>>
>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8186548
>>> webrev: 
>>> http://cr.openjdk.java.net/~iignatyev//8186548/webrev.00/index.html
>>> testing: sun/tools/jcmd tests + jdk-tier[1-3]
>>>
>>> Thanks,
>>> -- Igor
>>
>>

[prev in list] [next in list] [prev in thread] [next in thread]