[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: 8202342: [Graal] fromTonga/nsk/jvmti/unit/FollowReferences/followref003/TestDescription.java
From:       Daniil Titov <daniil.x.titov () oracle ! com>
Date:       2018-08-21 21:44:19
Message-ID: AF63CFCA-A0E0-4C13-8DEC-8CD0846F6D05 () oracle ! com
[Download RAW message or body]

Thank you, Serguei and Alex, for reviewing this change.

Best regards,
Daniil


On 8/21/18, 2:18 PM, "Alex Menkov" <alexey.menkov@oracle.com> wrote:

    +1
    
    --alex
    
    On 08/20/2018 20:06, serguei.spitsyn@oracle.com wrote:
    > Hi Daniil,
    > 
    > Looks good.
    > 
    > Thanks,
    > Serguei
    > 
    > 
    > 
    > On 8/16/18 19:04, Daniil Titov wrote:
    >> Please review the change that fix the test failure when running with 
    >> Graal.
    >>
    >> There are 2 problems here. The first one is that when running with 
    >> Graal the number of local references reported by JVMTI 
    >> FollowReferences () to the callback exceeds the size of the array  ( 
    >> 100 ) the test uses for storing them. The second issue is that the 
    >> test explicitly checks that the frame depth is in 0..50 range while 
    >> the frame depth for some of the references reported by the compiler 
    >> thread may exceed this limit.
    >>
    >> The fix ensures that only local references from the main thread are 
    >> processed by the test and local references from other (e.g. compiler) 
    >> threads are ignored.
    >>
    >> Webrev: http://cr.openjdk.java.net/~dtitov/8202342/webrev.01
    >> Issue: https://bugs.openjdk.java.net/browse/JDK-8202342
    >>
    >>
    >> Thanks,
    >> Daniil
    >>
    >>
    > 
    


[prev in list] [next in list] [prev in thread] [next in thread]