[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-serviceability-dev
Subject: RE: [8u-backport] RFR: JDK-8191948: jdb error: InvalidTypeException: Can't assign double[][][] to do
From: Fairoz Matte <fairoz.matte () oracle ! com>
Date: 2018-07-26 4:20:43
Message-ID: 309fc6ca-8099-4ebc-8502-a4e88e899b8e () default
[Download RAW message or body]
Hi Chris and Serguei,
Thanks for the review, I will add the appropriate noreg label.
Thanks,
Fairoz
From: Serguei Spitsyn
Sent: Wednesday, July 25, 2018 11:24 PM
To: Chris Plummer <chris.plummer@oracle.com>; Fairoz Matte <fairoz.matte@oracle.com>; \
serviceability-dev@openjdk.java.net
Subject: Re: [8u-backport] RFR: JDK-8191948: jdb error: InvalidTypeException: Can't \
assign double[][][] to double[][][]
Hi Fairoz,
Looks good to me too.
Thank you for taking care about this backport!
On 7/25/18 10:31, Chris Plummer wrote:
Hi Fairoz,
The changes look good. I'm not sure what the policy is when part of the (full) \
backport contains test changes that aren't directly applicable to 8u. You might need \
some sort of noreg label on the backport CR.
The test test/hotspot/jtreg/vmTestbase/nsk/jdb/eval/eval001 is located in the VM \
testbase which is a separate repository for jdk 8. I agree with Chris, noreg label on \
the backport CR is probably needed.
Thanks,
Serguei
thanks,
Chris
On 7/25/18 1:23 AM, Fairoz Matte wrote:
Hi,
Kindly review the backport of "JDK-8191948: jdb error: InvalidTypeException: Can't \
assign double[][][] to double[][][]" to 8u
Webrev - http://cr.openjdk.java.net/~fmatte/8191948/webrev.00/
JDK 11 bug - https://bugs.openjdk.java.net/browse/JDK-8191948
JDK 11 changeset - http://hg.openjdk.java.net/jdk/jdk11/rev/73c769e0486a
Review thread - http://mail.openjdk.java.net/pipermail/serviceability-dev/2018-July/024405.html
Thanks,
Fairoz
[Attachment #3 (text/html)]
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 3.2//EN">
<HTML>
<HEAD>
<META HTTP-EQUIV="Content-Type" CONTENT="text/html; charset=utf-8">
<META NAME="Generator" CONTENT="MS Exchange Server version rmj.rmm.rup.rpr">
<TITLE>RE: [8u-backport] RFR: JDK-8191948: jdb error: InvalidTypeException: Can't \
assign double[][][] to double[][][]</TITLE> </HEAD>
<BODY>
<!-- Converted from text/rtf format -->
<P DIR=LTR><SPAN LANG="en-us"><FONT FACE="Calibri">Hi Chris and</FONT></SPAN><SPAN \
LANG="en-us"> <FONT FACE="Calibri">Serguei</FONT></SPAN><SPAN LANG="en-us"><FONT \
FACE="Calibri">,</FONT></SPAN></P>
<P DIR=LTR><SPAN LANG="en-us"><FONT FACE="Calibri">Thanks for the review, I will add \
the appropriate noreg label.</FONT></SPAN></P>
<P DIR=LTR><SPAN LANG="en-us"><FONT FACE="Calibri">Thanks,</FONT></SPAN></P>
<P DIR=LTR><SPAN LANG="en-us"><FONT FACE="Calibri">Fairoz</FONT></SPAN><SPAN \
LANG="en-us"></SPAN></P>
<P DIR=LTR><SPAN LANG="en-us"></SPAN></P>
<UL DIR=LTR><UL DIR=LTR>
<P DIR=LTR><SPAN LANG="en-us"><FONT FACE="Calibri">From: Serguei Spitsyn \
</FONT></SPAN></P>
<P DIR=LTR><SPAN LANG="en-us"><FONT FACE="Calibri">Sent: Wednesday, July 25, 2018 \
11:24 PM</FONT></SPAN></P>
<P DIR=LTR><SPAN LANG="en-us"><FONT FACE="Calibri">To: Chris Plummer \
<chris.plummer@oracle.com>; Fairoz Matte <fairoz.matte@oracle.com>; \
serviceability-dev@openjdk.java.net</FONT></SPAN></P>
<P DIR=LTR><SPAN LANG="en-us"><FONT FACE="Calibri">Subject: Re: [8u-backport] RFR: \
JDK-8191948: jdb error: InvalidTypeException: Can't assign double[][][] to \
double[][][]</FONT></SPAN></P>
<P DIR=LTR><SPAN LANG="en-us"><FONT FACE="Calibri">Hi Fairoz,</FONT></SPAN></P>
<P DIR=LTR><SPAN LANG="en-us"><FONT FACE="Calibri">Looks good to me \
too.</FONT></SPAN></P>
<P DIR=LTR><SPAN LANG="en-us"><FONT FACE="Calibri">Thank you for taking care about \
this backport!</FONT></SPAN></P>
<P DIR=LTR><SPAN LANG="en-us"><FONT FACE="Calibri">On 7/25/18 10:31, Chris Plummer \
wrote:</FONT></SPAN></P>
<P DIR=LTR><SPAN LANG="en-us"><FONT FACE="Calibri">Hi Fairoz, </FONT></SPAN></P>
<P DIR=LTR><SPAN LANG="en-us"><FONT FACE="Calibri">The changes look good. I'm not \
sure what the policy is when part of the (full) backport contains test changes that \
aren't directly applicable to 8u. You might need some sort of noreg label on the \
backport CR.</FONT></SPAN></P>
<P DIR=LTR><SPAN LANG="en-us"><FONT FACE="Calibri">The test \
test/hotspot/jtreg/vmTestbase/nsk/jdb/eval/eval001 is located in the VM testbase \
which is a separate repository for jdk 8.</FONT></SPAN></P>
<P DIR=LTR><SPAN LANG="en-us"><FONT FACE="Calibri">I agree with Chris, noreg label on \
the backport CR is probably needed.</FONT></SPAN></P>
<P DIR=LTR><SPAN LANG="en-us"><FONT FACE="Calibri">Thanks,</FONT></SPAN></P>
<P DIR=LTR><SPAN LANG="en-us"><FONT FACE="Calibri">Serguei</FONT></SPAN></P>
<BR>
<BR>
<P DIR=LTR><SPAN LANG="en-us"><FONT FACE="Calibri">thanks, </FONT></SPAN></P>
<P DIR=LTR><SPAN LANG="en-us"><FONT FACE="Calibri">Chris </FONT></SPAN></P>
<P DIR=LTR><SPAN LANG="en-us"><FONT FACE="Calibri">On 7/25/18 1:23 AM, Fairoz Matte \
wrote: </FONT></SPAN></P>
<P DIR=LTR><SPAN LANG="en-us"><FONT FACE="Calibri">Hi, </FONT></SPAN></P>
<P DIR=LTR><SPAN LANG="en-us"><FONT FACE="Calibri">Kindly review the backport of \
"JDK-8191948: jdb error: InvalidTypeException: Can't assign double[][][] to \
double[][][]" to 8u </FONT></SPAN></P>
<P DIR=LTR><SPAN LANG="en-us"><FONT FACE="Calibri">Webrev - <A \
HREF="http://cr.openjdk.java.net/~fmatte/8191948/webrev.00/">http://cr.openjdk.java.net/~fmatte/8191948/webrev.00/</A> \
</FONT></SPAN></P>
<P DIR=LTR><SPAN LANG="en-us"><FONT FACE="Calibri">JDK 11 bug - <A \
HREF="https://bugs.openjdk.java.net/browse/JDK-8191948">https://bugs.openjdk.java.net/browse/JDK-8191948</A> \
</FONT></SPAN></P>
<P DIR=LTR><SPAN LANG="en-us"><FONT FACE="Calibri">JDK 11 changeset - <A \
HREF="http://hg.openjdk.java.net/jdk/jdk11/rev/73c769e0486a">http://hg.openjdk.java.net/jdk/jdk11/rev/73c769e0486a</A> \
</FONT></SPAN></P>
<P DIR=LTR><SPAN LANG="en-us"><FONT FACE="Calibri">Review thread - <A \
HREF="http://mail.openjdk.java.net/pipermail/serviceability-dev/2018-July/024405.html" \
>http://mail.openjdk.java.net/pipermail/serviceability-dev/2018-July/024405.html</A></FONT></SPAN></P>
>
<P DIR=LTR><SPAN LANG="en-us"><FONT FACE="Calibri">Thanks, </FONT></SPAN></P>
<P DIR=LTR><SPAN LANG="en-us"><FONT FACE="Calibri">Fairoz </FONT></SPAN></P>
</UL></UL>
<P DIR=LTR><SPAN LANG="en-us"></SPAN></P>
<P DIR=LTR><SPAN LANG="en-us"></SPAN></P>
</BODY>
</HTML>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic