[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: [11] RFR(XS): 8195156 [Graal] serviceability/jvmti/GetModulesInfo/JvmtiGetAllModulesTest.java fa
From:       Ekaterina Pavlova <ekaterina.pavlova () oracle ! com>
Date:       2018-07-25 2:08:22
Message-ID: 72710916-021f-6dd9-7f05-b1b1b410734d () oracle ! com
[Download RAW message or body]

Vladimir, Serguei, thanks for your reviews!
I fixed copyright year.

-katya

On 7/24/18 5:51 PM, serguei.spitsyn@oracle.com wrote:
> Forgot to tell that a copyright comment needs a year update.
> No need in new webrev.
> 
> Thanks,
> Serguei
> 
> On 7/24/18 17:48, serguei.spitsyn@oracle.com wrote:
> > Hi Katya,
> > 
> > Nice simple fix.
> > Thank you for taking care about it!
> > 
> > Thanks,
> > Serguei
> > 
> > On 7/24/18 15:10, Ekaterina Pavlova wrote:
> > > Hi All,
> > > 
> > > serviceability/jvmti/GetModulesInfo/JvmtiGetAllModulesTest.java fails with \
> > > Graal because two more modules jdk.proxy1 and jdk.proxy2 are dynamically \
> > > initialized by Graal code. These modules are not part of boot modules and as \
> > > results the check fails. It was agreed with Serviceability team to filter these \
> > > modules out. 
> > > Please review the fix.
> > > 
> > > JBS: https://bugs.openjdk.java.net/browse/JDK-8195156
> > > webrev: http://cr.openjdk.java.net/~epavlova//8195156/webrev.00/index.html
> > > testing: tested by running \
> > > serviceability/jvmti/GetModulesInfo/JvmtiGetAllModulesTest.java with Graal and \
> > > -Xcomp 
> > > 
> > > Thanks,
> > > -katya
> > > 
> > > p.s.
> > > Igor Ignatyev volunteered to sponsor this change.
> > > 
> > 
> 


[prev in list] [next in list] [prev in thread] [next in thread]