[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR (S): C1 still does eden allocations when TLAB is enabled
From:       Vladimir Kozlov <vladimir.kozlov () oracle ! com>
Date:       2018-07-20 17:57:11
Message-ID: 22211468-5b15-e6a8-be6b-7ce5d2fbdf27 () oracle ! com
[Download RAW message or body]

Please, don't do review in 2 mailing threads.

Thanks,
Vladimir

On 7/20/18 8:30 AM, JC Beyler wrote:
> Awesome thanks Thomas!
> 
> Here is the webrev with the extra information then:
> http://cr.openjdk.java.net/~jcbeyler/8207252/webrev.03/
> 
> Thanks again for all the reviews everyone!
> Jc
> 
> On Fri, Jul 20, 2018 at 3:23 AM Thomas Schatzl <thomas.schatzl@oracle.com>
> wrote:
> 
>> Hi,
>>
>> On Mon, 2018-07-16 at 14:58 -0700, JC Beyler wrote:
>>> Hi all,
>>>
>>> Here is a webrev that does all the architectures in the same way:
>>> http://cr.openjdk.java.net/~jcbeyler/8207252/webrev.02/
>>>
>>> Could anyone review the other architectures and test?
>>>    - arm, sparc & aarch64 are also modified now to follow the same "if
>>> no
>>> tlab, then consider eden space allocation" logic.
>>>
>>> Thanks for your help!
>>> Jc
>>>
>>
>>    looks good.
>>
>> I ran the change through hs-tier1-3 with no issues. It only tests on
>> sparc and x64 though.
>>
>> I do not expect issues on the other platforms though :)
>>
>> Thanks,
>>    Thomas
>>
>>
> 
[prev in list] [next in list] [prev in thread] [next in thread]