[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR 8206086: [Graal] JDI tests fail with com.sun.jdi.ObjectCollectedException
From:       Alex Menkov <alexey.menkov () oracle ! com>
Date:       2018-06-29 11:16:15
Message-ID: d6831548-e319-a89c-677c-ab785ec83690 () oracle ! com
[Download RAW message or body]

+1

--alex

On 06/28/2018 22:53, Chris Plummer wrote:
> +1
> 
> Please add the description of the problem to the CR.
> 
> thanks,
> 
> Chris
> 
> On 6/28/18 10:10 PM, serguei.spitsyn@oracle.com wrote:
>> Hi Daniil,
>>
>> It looks good to me.
>>
>> Thanks,
>> Serguei
>>
>>
>> On 6/28/18 20:57, Daniil Titov wrote:
>>> Please review the changes that fix 4 JDI tests that fail when running 
>>> with Graal.
>>>
>>> The problem here is that in some cases by the time the test decides 
>>> whether the JDI event should be saved for further analysis the object 
>>> this event refers to might be already collected in the debuggee VM. 
>>> The fix ensures that if this happens then ObjectCollectedException is 
>>> gracefully handled and the event is skipped.
>>>
>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8206086
>>> Webrev: http://cr.openjdk.java.net/~dtitov/8206086/webrev.001/
>>>
>>> Thanks!
>>>
>>> --Daniil
>>>
>>>
>>
> 
[prev in list] [next in list] [prev in thread] [next in thread]