[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR: 8204170: MXBeanException.java assumes the existence of a pool that doesn't support usage th
From:       Stefan Karlsson <stefan.karlsson () oracle ! com>
Date:       2018-05-31 17:06:42
Message-ID: 674e786c-f13e-96ab-dc68-4fa7f009526a () oracle ! com
[Download RAW message or body]

On 2018-05-31 19:04, mandy chung wrote:
>
>
> On 5/31/18 10:01 AM, Stefan Karlsson wrote:
>> Hi Mandy,
>>
>> On 2018-05-31 18:44, mandy chung wrote:
>>> Hi Stefan,
>>>
>>> I think a better fix is to find another operation that will throw an 
>>> exception.   ThreadMXBean::getThreadInfo throws IAE and it can be a 
>>> candidate.
>>
>> Thanks for taking a look at this patch.
>>
>> The test checks a number of different operations, and the suggestion 
>> would change the test significantly. I'm not sure this is the time to 
>> completely rewrite this test. If the null check is problematic, then 
>> I think it would be better to just exclude this test when running 
>> with ZGC, and get the current testing when running with the other GCs.
>>
>> Does this sound reasonable?
>
> Sounds good with me.
>
> Filtering out the test when running with ZGC is a good interim fix.   
> The serviceability team can modify this test to use a different 
> operation as a separate issue.

OK. Then I'm revoking this RFE and will add the ZGC filtering to the ZGC 
patch.

Thanks,
StefanK

>
> Mandy


[prev in list] [next in list] [prev in thread] [next in thread]