[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR 8203802: Jvmti test fails to build with VS2017
From:       Erik Joelsson <erik.joelsson () oracle ! com>
Date:       2018-05-29 21:37:09
Message-ID: d6fc415e-5b46-650a-7d03-9491726c39dd () oracle ! com
[Download RAW message or body]

Looks good to me.

/Erik


On 2018-05-29 14:35, Daniil Titov wrote:
> Hi Serguei,
> 
> Thank you, for review.
> 
> I will need one more reviewer to push this changes.
> 
> Best regards,
> Daniil
> 
> 
> On 5/29/18, 12:01 PM, "serguei.spitsyn@oracle.com" <serguei.spitsyn@oracle.com> \
> wrote: 
> Hi Daniil,
> 
> It looks good.
> 
> Thanks,
> Serguei
> 
> 
> On 5/26/18 11:57, Daniil Titov wrote:
> > Please review the changes that fix a build failure for Jvmti tests.
> > 
> > The fix replaces printf "%ld" format with JLONG_FORMAT macro defined in the same \
> > way as it is defined in the hotspot \
> > (src/hotspot//share/utilities/globalDefinitions.hpp and \
> > src/hotspot//share/utilities/globalDefinitions_gcc.hpp) 
> > Bug: https://bugs.openjdk.java.net/browse/JDK-8203802
> > Webrev: http://cr.openjdk.java.net/~dtitov/8203802/webrev.01
> > 
> > 
> > Mach5 builds and hs-tier1-3, jdk-tier1-3 tests were completed successfully.
> > 
> > Best regards,
> > Daniil
> > 
> > 
> 
> 
> 
> 


[prev in list] [next in list] [prev in thread] [next in thread]