[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR(L) : 8199379 : [TESTBUG] Open source vm testbase JDB tests
From:       Mikhailo Seledtsov <mikhailo.seledtsov () oracle ! com>
Date:       2018-05-22 2:45:56
Message-ID: 5B038464.4080304 () oracle ! com
[Download RAW message or body]

+1,

Misha

On 5/18/18, 6:42 PM, serguei.spitsyn@oracle.com wrote:
> Hi Igor,
>
> This looks good to me.
> Thank you a lot for taking care about this move from closed to open!
>
> Thanks,
> Serguei
>
>
> On 5/15/18 14:21, Igor Ignatyev wrote:
>> http://cr.openjdk.java.net/~iignatyev//8199379/webrev.00/index.html
>>> 18000 lines changed: 17999 ins; 0 del; 1 mod;
>>
>> Hi all,
>>
>> could you please review this patch which open sources JDB tests from 
>> VM testbase?
>>
>> these tests were developed to test 'jdb' tool and JDI thru it.
>>
>> As usually w/ VM testbase code, these tests are old, they have been 
>> run in hotspot testing for a long period of time. Originally, these 
>> tests were run by a test harness different from jtreg and had 
>> different build and execution schemes, some parts couldn't be easily 
>> translated to jtreg, so tests might have actions or pieces of code 
>> which look weird. In a long term, we are planning to rework them.
>>
>> JBS: https://bugs.openjdk.java.net/browse/JDK-8199379
>> webrev: 
>> http://cr.openjdk.java.net/~iignatyev//8199379/webrev.00/index.html
>> testing: :vmTestbase_nsk_jdb test group
>>
>> Thanks,
>> -- Igor
>
[prev in list] [next in list] [prev in thread] [next in thread]