[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-serviceability-dev
Subject: RE: RFR (S): 8203500: Fix broken links to Specification in "specs" directory
From: Iris Clark <iris.clark () oracle ! com>
Date: 2018-05-21 23:20:52
Message-ID: 011f88b2-8807-4f83-b3d6-7e55687911b5 () default
[Download RAW message or body]
Hi, Mandy.
Thanks for the super-fast review!
iris
From: mandy chung
Sent: Monday, May 21, 2018 4:15 PM
To: Iris Clark <iris.clark@oracle.com>
Cc: compiler-dev@openjdk.java.net; core-libs-dev@openjdk.java.net; \
serviceability-dev@openjdk.java.net
Subject: Re: RFR (S): 8203500: Fix broken links to Specification in "specs" directory
The fix looks fine.
Mandy
On 5/21/18 3:54 PM, Iris Clark wrote:
Hi.
Please review this small change to fix a few broken links to
Specification in the "specs" directory from the JavaDoc API.
The incorrect references either not include "{@docRoot}" or
include the non-existent "{@docRootParent}". They should all
begin with "HYPERLINK "mailto:%7b@docRoot%7d/../specs/"{@docRoot}/../specs/".
Bug:
8203500 Fix broken links to Specification in "spec" directory
https://bugs.openjdk.java.net/browse/JDK-8203500
webrev:
HYPERLINK "http://cr.openjdk.java.net/%7Eiris/8203500/webrev/"http://cr.openjdk.java.net/~iris/8203500/webrev/
Thanks,
Iris
[Attachment #3 (text/html)]
<html xmlns:v="urn:schemas-microsoft-com:vml" \
xmlns:o="urn:schemas-microsoft-com:office:office" \
xmlns:w="urn:schemas-microsoft-com:office:word" \
xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" \
xmlns="http://www.w3.org/TR/REC-html40"><head><meta http-equiv=Content-Type \
content="text/html; charset=us-ascii"><meta name=Generator content="Microsoft Word 15 \
(filtered medium)"><style><!-- /* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;
color:black;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:#954F72;
text-decoration:underline;}
p.msonormal0, li.msonormal0, div.msonormal0
{mso-style-name:msonormal;
mso-margin-top-alt:auto;
margin-right:0in;
mso-margin-bottom-alt:auto;
margin-left:0in;
font-size:12.0pt;
font-family:"Times New Roman",serif;
color:black;}
span.EmailStyle18
{mso-style-type:personal;
font-family:"Calibri",sans-serif;
color:windowtext;}
span.EmailStyle19
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]--></head><body bgcolor=white lang=EN-US \
link="#0563C1" vlink="#954F72"><div class=WordSection1><p class=MsoNormal><span \
style='color:#1F497D'>Hi, Mandy.<o:p></o:p></span></p><p class=MsoNormal><span \
style='color:#1F497D'><o:p> </o:p></span></p><p class=MsoNormal><span \
style='color:#1F497D'>Thanks for the super-fast review!<o:p></o:p></span></p><p \
class=MsoNormal><span style='color:#1F497D'><o:p> </o:p></span></p><p \
class=MsoNormal><span style='color:#1F497D'>iris<o:p></o:p></span></p><p \
class=MsoNormal><span style='color:#1F497D'><o:p> </o:p></span></p><div><div \
style='border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in'><p \
class=MsoNormal><b><span style='color:windowtext'>From:</span></b><span \
style='color:windowtext'> mandy chung <br><b>Sent:</b> Monday, May 21, 2018 4:15 \
PM<br><b>To:</b> Iris Clark <iris.clark@oracle.com><br><b>Cc:</b> \
compiler-dev@openjdk.java.net; core-libs-dev@openjdk.java.net; \
serviceability-dev@openjdk.java.net<br><b>Subject:</b> Re: RFR (S): 8203500: Fix \
broken links to Specification in "specs" \
directory<o:p></o:p></span></p></div></div><p class=MsoNormal><o:p> </o:p></p><p \
class=MsoNormal style='margin-bottom:12.0pt'>The fix looks fine.<br><br>Mandy<span \
style='font-size:12.0pt'><o:p></o:p></span></p><div><p class=MsoNormal>On 5/21/18 \
3:54 PM, Iris Clark wrote:<o:p></o:p></p></div><blockquote \
style='margin-top:5.0pt;margin-bottom:5.0pt'><p class=MsoNormal>Hi.<o:p></o:p></p><p \
class=MsoNormal> <o:p></o:p></p><p class=MsoNormal>Please review this small \
change to fix a few broken links to<o:p></o:p></p><p class=MsoNormal>Specification in \
the “specs” directory from the JavaDoc API.<o:p></o:p></p><p \
class=MsoNormal>The incorrect references either not include "{@docRoot}" \
or<o:p></o:p></p><p class=MsoNormal>include the non-existent \
"{@docRootParent}". They should all<o:p></o:p></p><p \
class=MsoNormal>begin with “<a \
href="mailto:%7b@docRoot%7d/../specs/">{@docRoot}/../specs/</a>”.<o:p></o:p></p><p \
class=MsoNormal> <o:p></o:p></p><p class=MsoNormal>Bug:<o:p></o:p></p><p \
class=MsoNormal> <o:p></o:p></p><p class=MsoNormal> 8203500 \
Fix broken links to Specification in “spec” directory<o:p></o:p></p><p \
class=MsoNormal> <a \
href="https://bugs.openjdk.java.net/browse/JDK-8203500">https://bugs.openjdk.java.net/browse/JDK-8203500</a><o:p></o:p></p><p \
class=MsoNormal> <o:p></o:p></p><p class=MsoNormal>webrev:<o:p></o:p></p><p \
class=MsoNormal> <o:p></o:p></p><p class=MsoNormal> <a \
href="http://cr.openjdk.java.net/%7Eiris/8203500/webrev/">http://cr.openjdk.java.net/~iris/8203500/webrev/</a><o:p></o:p></p><p \
class=MsoNormal> <o:p></o:p></p><p class=MsoNormal>Thanks,<o:p></o:p></p><p \
class=MsoNormal>Iris<o:p></o:p></p><p \
class=MsoNormal> <o:p></o:p></p></blockquote><p class=MsoNormal><span \
style='font-size:12.0pt;font-family:"Times New \
Roman",serif'><o:p> </o:p></span></p></div></body></html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic