[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR: 8202417: [TESTBUG] Broken hard-coded dependency in serviceability/sa/ClhsdbJhisto.java
From:       Jini George <jini.george () oracle ! com>
Date:       2018-04-30 13:24:02
Message-ID: 68355d9c-eeac-d84d-6f89-69a3c8bd927b () oracle ! com
[Download RAW message or body]

Hi Claes,

This looks fine to me.

Thanks,
Jini. (Not a Reviewer)

On 4/30/2018 3:00 PM, Claes Redestad wrote:
> Hi,
> 
> ClhsdbJhisto has a hard-coded dependency on an 
> ImmutableCollections$SetN$1 appearing in the jhisto output, which is 
> fragile and sometimes break after JDK-8201650. I suggest removing it 
> from the test:
> 
> diff -r 96d4658eb7f2 test/hotspot/jtreg/serviceability/sa/ClhsdbJhisto.java
> --- a/test/hotspot/jtreg/serviceability/sa/ClhsdbJhisto.java  Mon Apr 30 
> 09:15:44 2018 +0200
> +++ b/test/hotspot/jtreg/serviceability/sa/ClhsdbJhisto.java  Mon Apr 30 
> 11:28:08 2018 +0200
> @@ -62,8 +62,7 @@
>                       "java.nio.HeapByteBuffer",
>                       "java.net.URI",
>                       "LingeredAppWithInterface",
> -                    "ParselTongue",
> -                    "ImmutableCollections$SetN$1"));
> +                    "ParselTongue"));
> 
>               test.run(theApp.getPid(), cmds, expStrMap, null);
>           } catch (Exception ex) {

[prev in list] [next in list] [prev in thread] [next in thread]