[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR: (S): SA: clhsdb 'where -a' throws Assertion Failure with illegal code 236 when CDS is used
From:       Ioi Lam <ioi.lam () oracle ! com>
Date:       2018-04-26 20:24:51
Message-ID: f87e82ae-5e5d-e4d8-e978-bc3b2d098503 () oracle ! com
[Download RAW message or body]

HI Jini,

[1] "_nofast_aload" should be "_nofast_aload_0": aload and aload_0 are 
two different bytecodes.

[2] Only the _nofast_aload_0 bytecode is tested. For completeness, do 
you think it makes sense to add test cases for these other 3 bytecodes?

        _nofast_getfield
        _nofast_putfield
        _nofast_iload


Thanks
- Ioi

On 4/26/18 11:15 AM, Jini George wrote:
> Hello all,
>
> Please review the following proposed fix for the issue:
>
> https://bugs.openjdk.java.net/browse/JDK-8174995
>
> Webrev: http://cr.openjdk.java.net/~jgeorge/8174995/webrev.00/
>
> Issue: Clhsdb commands like 'where -a', 'printall' would throw an 
> illegal code assertion failure when CDS is used.
>
> Root cause and proposed fix: SA has been unaware of the new bytecodes 
> introduced for rewriting at CDS dump time (_nofast* bytecodes). The 
> fix is to make SA aware of these new _nofast* bytecodes.
>
> Tests Run and Passed: SA tests on Mach5 (including the tests modified 
> to test this fix).
>
> Thank you,
> Jini.

[prev in list] [next in list] [prev in thread] [next in thread]