[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR(xxs): 8200384: jcmd help output should be sorted
From:       Thomas_Stüfe <thomas.stuefe () gmail ! com>
Date:       2018-04-11 18:01:04
Message-ID: CAA-vtUx+Ww2VxKU0GMZP9u=WWbopRkgkaiNDS+q2GMV_u8HKFA () mail ! gmail ! com
[Download RAW message or body]

Hi Serguei,

On Wed, Apr 11, 2018 at 7:51 PM, serguei.spitsyn@oracle.com
<serguei.spitsyn@oracle.com> wrote:
> Hi Thomas,
>
> Sorry, I did not reply to this.

no problem.

> Thank you a lot for providing the output!
> I agree, the sorted one looks much better.
>
> Probably, it is late to say but I'm Ok with a push. :)
>

Thanks :) Have not yet pushed but will do it today or tomorrow.

..Thomas

> Thanks,
> Serguei
>
>
>
> On 4/9/18 02:07, Thomas St=C3=BCfe wrote:
>
> Hi Sergey, Christoph,
>
> thanks for the review!
>
> Sure, here you go:
>
> Old output, unsorted:
>
> thomas@mainframe /shared/projects/openjdk/jdk-submit-hs/output-fastdebug =
$
> ./images/jdk/bin/jcmd test3.Example2 help
> 24278:
> The following commands are available:
> VM.log
> VM.native_memory
> ManagementAgent.status
> ManagementAgent.stop
> ManagementAgent.start_local
> ManagementAgent.start
> Compiler.directives_clear
> Compiler.directives_remove
> Compiler.directives_add
> Compiler.directives_print
> Compiler.CodeHeap_Analytics
> VM.print_touched_methods
> Compiler.codecache
> Compiler.codelist
> Compiler.queue
> VM.classloader_stats
> Thread.print
> JVMTI.data_dump
> JVMTI.agent_load
> VM.metaspace
> VM.stringtable
> VM.symboltable
> VM.class_hierarchy
> VM.systemdictionary
> GC.class_stats
> GC.class_histogram
> GC.heap_dump
> GC.finalizer_info
> GC.heap_info
> GC.run_finalization
> GC.run
> VM.info
> VM.uptime
> VM.dynlibs
> VM.set_flag
> VM.flags
> VM.system_properties
> VM.command_line
> VM.version
> help
>
> New output, sorted:
>
> thomas@mainframe /shared/projects/openjdk/jdk-submit-hs/output-fastdebug =
$
> ./images/jdk/bin/jcmd test3.Example2 help
> 30230:
> The following commands are available:
> Compiler.CodeHeap_Analytics
> Compiler.codecache
> Compiler.codelist
> Compiler.directives_add
> Compiler.directives_clear
> Compiler.directives_print
> Compiler.directives_remove
> Compiler.queue
> GC.class_histogram
> GC.class_stats
> GC.finalizer_info
> GC.heap_dump
> GC.heap_info
> GC.run
> GC.run_finalization
> JVMTI.agent_load
> JVMTI.data_dump
> ManagementAgent.start
> ManagementAgent.start_local
> ManagementAgent.status
> ManagementAgent.stop
> Thread.print
> VM.class_hierarchy
> VM.classloader_stats
> VM.command_line
> VM.dynlibs
> VM.flags
> VM.info
> VM.log
> VM.metaspace
> VM.native_memory
> VM.print_touched_methods
> VM.set_flag
> VM.stringtable
> VM.symboltable
> VM.system_properties
> VM.systemdictionary
> VM.uptime
> VM.version
> help
>
>
> I'm running submit tests now, if they pass I'll push.
>
> Best Regards, Thomas
>
>
> On Tue, Apr 3, 2018 at 3:52 AM, serguei.spitsyn@oracle.com
> <serguei.spitsyn@oracle.com> wrote:
>>
>> Hi Thomas,
>>
>> Added the serviceability-dev mailing list as it is a Serviceability area=
.
>>
>> The fix looks good to me.
>> One question:
>>  Could you, please, post the sorted help output?
>>  It is interesting how does it look like when sorted.
>>
>> Thanks,
>> Serguei
>>
>>
>>
>> On 3/28/18 13:08, Thomas St=C3=BCfe wrote:
>>>
>>> Hi all,
>>>
>>> may I get reviews for this tiny trivial change which causes jcmd help
>>> output (the command list) to be sorted?
>>>
>>> bug: https://bugs.openjdk.java.net/browse/JDK-8200384
>>> webrev:
>>>
>>> http://cr.openjdk.java.net/~stuefe/webrevs/8200384-jcmd-help-sorted/web=
rev.00/webrev/
>>>
>>> Thanks!
>>>
>>> Best Regards, Thomas
>>
>>
>
>
[prev in list] [next in list] [prev in thread] [next in thread]