[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: [8u] RFR for backport of "JDK-8165736: Error message should be shown when JVMTI agent cannot be 
From:       David Holmes <david.holmes () oracle ! com>
Date:       2018-03-31 7:24:28
Message-ID: 70a18b4a-a310-babe-1f41-c86100638457 () oracle ! com
[Download RAW message or body]

Hi Shafi,

On 29/03/2018 7:11 PM, Shafi Ahmad wrote:
> Hi,
> 
> Please review the backport of ' JDK-8165736: Error message should be shown when \
> JVMTI agent cannot be attached' to jdk8u-dev. Please note that this is not a clean \
> backport because we can't not backport native jtreg tests as  infrastructure of \
> naive jtreg test has been available since JDK 9.

Ok.

> webrev: http://cr.openjdk.java.net/~shshahma/8165736/
> jdk10 bug: https://bugs.openjdk.java.net/browse/JDK-8165736
> original patch pushed to jdk10: http://hg.openjdk.java.net/jdk/jdk/rev/bc1cffa26561

src/share/vm/prims/jvmtiExport.cpp

You missed the initalization of ebuf:

+  char ebuf[1024] = {0};

Otherwise the functional backport seems okay.

Thanks,
David

> Test:  Run jprt -testset hotspot, -testset core
> 
> Regards,
> Shafi
> 


[prev in list] [next in list] [prev in thread] [next in thread]