[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    RE: RFR : JDK-8071367 - JMX: Remove SNMP support
From:       Amit Sapre <amit.sapre () oracle ! com>
Date:       2018-03-26 10:28:46
Message-ID: 325a2e31-5559-4819-a9f7-c7e0dadc59d5 () default
[Download RAW message or body]

Thanks Alan & mandy for reviews.

Amit

 

From: Alan Bateman 
Sent: Friday, March 23, 2018 9:54 PM
To: Amit Sapre; Mandy Chung; serviceability-dev@openjdk.java.net; \
                compiler-dev@openjdk.java.net
Subject: Re: RFR : JDK-8071367 - JMX: Remove SNMP support

 

On 23/03/2018 10:43, Amit Sapre wrote:



Thanks all for the inputs.

This webrev addresses the inputs : HYPERLINK \
"http://cr.openjdk.java.net/%7Easapre/webrev/2018/JDK-8071367/webrev.02/"http://cr.openjdk.java.net/~asapre/webrev/2018/JDK-8071367/webrev.02/


 

I think you need to put {@code ... } around "-Dcom.sun.management.*", otherwise looks \
good to me.

-Alan


[Attachment #3 (text/html)]

<html xmlns:v="urn:schemas-microsoft-com:vml" \
xmlns:o="urn:schemas-microsoft-com:office:office" \
xmlns:w="urn:schemas-microsoft-com:office:word" \
xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" \
xmlns="http://www.w3.org/TR/REC-html40"><head><meta http-equiv=Content-Type \
content="text/html; charset=us-ascii"><meta name=Generator content="Microsoft Word 15 \
(filtered medium)"><style><!-- /* Font Definitions */
@font-face
	{font-family:"Cambria Math";
	panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
	{font-family:Calibri;
	panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
	{margin:0in;
	margin-bottom:.0001pt;
	font-size:11.0pt;
	font-family:"Calibri","sans-serif";
	color:black;}
a:link, span.MsoHyperlink
	{mso-style-priority:99;
	color:#0563C1;
	text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
	{mso-style-priority:99;
	color:#954F72;
	text-decoration:underline;}
span.EmailStyle17
	{mso-style-type:personal;
	font-family:"Calibri","sans-serif";
	color:windowtext;}
span.EmailStyle18
	{mso-style-type:personal;
	font-family:"Calibri","sans-serif";
	color:#1F497D;}
span.EmailStyle19
	{mso-style-type:personal;
	font-family:"Calibri","sans-serif";
	color:#1F497D;}
span.EmailStyle20
	{mso-style-type:personal-reply;
	font-family:"Calibri","sans-serif";
	color:#1F497D;}
.MsoChpDefault
	{mso-style-type:export-only;
	font-size:10.0pt;}
@page WordSection1
	{size:8.5in 11.0in;
	margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
	{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]--></head><body bgcolor=white lang=EN-US \
link="#0563C1" vlink="#954F72"><div class=WordSection1><p class=MsoNormal><span \
style='color:#1F497D'>Thanks Alan &amp; mandy for reviews.<o:p></o:p></span></p><p \
class=MsoNormal><span style='color:#1F497D'>Amit<o:p></o:p></span></p><p \
class=MsoNormal><span style='color:#1F497D'><o:p>&nbsp;</o:p></span></p><div \
style='border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt'><div><div \
style='border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in'><p \
class=MsoNormal><b><span style='color:windowtext'>From:</span></b><span \
style='color:windowtext'> Alan Bateman <br><b>Sent:</b> Friday, March 23, 2018 9:54 \
PM<br><b>To:</b> Amit Sapre; Mandy Chung; serviceability-dev@openjdk.java.net; \
compiler-dev@openjdk.java.net<br><b>Subject:</b> Re: RFR : JDK-8071367 - JMX: Remove \
SNMP support<o:p></o:p></span></p></div></div><p \
class=MsoNormal><o:p>&nbsp;</o:p></p><p class=MsoNormal>On 23/03/2018 10:43, Amit \
Sapre wrote:<br><br><span style='font-size:12.0pt'><o:p></o:p></span></p><blockquote \
style='margin-top:5.0pt;margin-bottom:5.0pt'><p class=MsoNormal><span \
style='color:#1F497D'>Thanks all for the inputs.</span><o:p></o:p></p><p \
class=MsoNormal><span style='color:#1F497D'>This webrev addresses the inputs : <a \
href="http://cr.openjdk.java.net/%7Easapre/webrev/2018/JDK-8071367/webrev.02/">http:// \
cr.openjdk.java.net/~asapre/webrev/2018/JDK-8071367/webrev.02/</a></span><o:p></o:p></p><p \
class=MsoNormal><span style='font-size:12.0pt;font-family:"Times New \
Roman","serif"'><o:p>&nbsp;</o:p></span></p></blockquote><p class=MsoNormal><span \
style='font-size:12.0pt;font-family:"Times New Roman","serif"'>I think you need to \
put {@code ... } around &quot;-Dcom.sun.management.*&quot;, otherwise looks good to \
me.<br><br>-Alan<o:p></o:p></span></p></div></div></body></html>



[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic