[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR 8199467 Compilation Errors in libinstrument Reentrancy.c with VS2017
From:       Roger Riggs <Roger.Riggs () Oracle ! com>
Date:       2018-03-22 13:46:16
Message-ID: b3f991f0-c8c7-5093-6f84-8599fe457f12 () Oracle ! com
[Download RAW message or body]

Hi Martin,

Good recommendation; pushed.

Thanks, Roger



On 3/21/2018 3:31 PM, Martin Buchholz wrote:
>
>
> On Wed, Mar 21, 2018 at 12:13 PM, Roger Riggs <Roger.Riggs@oracle.com 
> <mailto:Roger.Riggs@oracle.com>> wrote:
>
>
>     -       void *           test = (void *) 0x99999999;
>     +       void *           test = (void *) 0x99999999ul;
>
>
> Martin's 15th law: Never use "l" in a numeric constant unless the 
> constant is 0xCafeBabel,
>
> so 0x99999999UL


[Attachment #3 (text/html)]

<html>
  <head>
    <meta http-equiv="Content-Type" content="text/html; charset=utf-8">
  </head>
  <body text="#000000" bgcolor="#FFFFE0">
    Hi Martin,<br>
    <br>
    Good recommendation; pushed.<br>
    <br>
    Thanks, Roger<br>
    <br>
    <br>
    <br>
    <div class="moz-cite-prefix">On 3/21/2018 3:31 PM, Martin Buchholz
      wrote:<br>
    </div>
    <blockquote type="cite"
cite="mid:CA+kOe0_mKCCB29DbjJkDKhzoO-NgxpXWQTxOH0Lxc5byNQXz2A@mail.gmail.com">
      <div dir="ltr"><br>
        <div class="gmail_extra"><br>
          <div class="gmail_quote">On Wed, Mar 21, 2018 at 12:13 PM,
            Roger Riggs <span dir="ltr">&lt;<a
                href="mailto:Roger.Riggs@oracle.com" target="_blank"
                moz-do-not-send="true">Roger.Riggs@oracle.com</a>&gt;</span>
            wrote:<br>
            <blockquote class="gmail_quote" style="margin:0 0 0
              .8ex;border-left:1px #ccc solid;padding-left:1ex"><br>
              -       void *           test = (void *) 0x99999999;<br>
              +       void *           test = (void *) 0x99999999ul;<br>
            </blockquote>
            <div><br>
            </div>
            <div>Martin's 15th law: Never use "l" in a numeric constant
              unless the constant is 0xCafeBabel,</div>
            <div><br>
            </div>
            <div>so  <span
style="color:rgb(34,34,34);font-family:arial,sans-serif;font-size:small;font-style:nor \
mal;font-variant-ligatures:normal;font-variant-caps:normal;font-weight:400;letter-spac \
ing:normal;text-align:start;text-indent:0px;text-transform:none;white-space:normal;wor \
d-spacing:0px;background-color:rgb(255,255,255);text-decoration-style:initial;text-decoration-color:initial;float:none;display:inline">0x99999999UL</span></div>
  </div>
        </div>
      </div>
    </blockquote>
    <br>
  </body>
</html>



[prev in list] [next in list] [prev in thread] [next in thread]

Configure | About | News | Add a list | Sponsored by KoreLogic