[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-serviceability-dev
Subject: Re: RFR: Two line change in documentation
From: JC Beyler <jcbeyler () google ! com>
Date: 2018-03-14 17:11:56
Message-ID: CAF9BGBxi7KE71YSTJ1KA8Ny-OvktsUNRFU9nSJ5XeOZBhH92kA () mail ! gmail ! com
[Download RAW message or body]
Thanks Serguei!
Jc
On Wed, Mar 14, 2018 at 10:07 AM serguei.spitsyn@oracle.com <
serguei.spitsyn@oracle.com> wrote:
> Hi Jc,
>
> I forgot to ask you for a patch yesterday.
> Thank you for webrev, it has to be enough as it has a patch in it.
> I'll push it now.
>
> Thanks,
> Serguei
>
>
> On 3/14/18 09:59, JC Beyler wrote:
>
> Hi David and Serguei,
>
> Sorry, I was not sure what would be the process for a small fix like this.
> Did it make sense to make a bug/webrev and all that or not was not clear to
> me. I'll know for next time. Anyway, I assigned the bug to myself, and put
> the fix here:
> http://cr.openjdk.java.net/~jcbeyler/8199561/
>
> Let me know if I need to do anything else,
> Jc
>
>
>
> On Tue, Mar 13, 2018 at 5:56 PM David Holmes <david.holmes@oracle.com>
> wrote:
>
>> On 14/03/2018 7:32 AM, serguei.spitsyn@oracle.com wrote:
>> > Hi Jc,
>> >
>> > Yes, these are typos.
>> > Thank you for fixing them!
>> >
>> > Is it a formal review request (RFR) ?
>> > If so, then a bug number is needed.
>> > I've filed one:
>> > https://bugs.openjdk.java.net/browse/JDK-8199561
>> >
>> > The fix looks good.
>> > I think, this can be fixed under a trivial fix rule with just one
>> review.
>>
>> I agree. No need for CSR either as these are just obvious typos. :)
>>
>> Thanks,
>> David
>>
>> > I'll sponsor it for you.
>> >
>> > Thanks,
>> > Serguei
>> >
>> >
>> > On 3/13/18 10:37, JC Beyler wrote:
>> >> Hi all,
>> >>
>> >> I saw an error in the SetEventNotificationMode method where the
>> >> parameter is called event_thread but the documentation was referring
>> >> to it as thread. I then went and did a quick scan of the documentation
>> >> and found one type of "couse" instead of "course".
>> >>
>> >> Here is the diff, not sure it was worth doing a webrev for it but let
>> >> me know:
>> >> diff -r 2d1d0c66966b src/hotspot/share/prims/jvmti.xml
>> >> --- a/src/hotspot/share/prims/jvmti.xmlMon Mar 12 14:11:54 2018 -0700
>> >> +++ b/src/hotspot/share/prims/jvmti.xmlTue Mar 13 10:35:03 2018 -0700
>> >> @@ -693,7 +693,7 @@
>> >> mechanism causes the unload (an unload mechanism is not specified
>> >> in this document)
>> >> or the library is (in effect) unloaded by the termination of the
>> >> VM whether through
>> >> normal termination or VM failure, including start-up failure.
>> >> - Uncontrolled shutdown is, of couse, an exception to this rule.
>> >> + Uncontrolled shutdown is, of course, an exception to this rule.
>> >> Note the distinction between this function and the
>> >> <eventlink id="VMDeath">VM Death event</eventlink>: for the VM
>> >> Death event
>> >> to be sent, the VM must have run at least to the point of
>> >> initialization and a valid
>> >> @@ -9405,7 +9405,7 @@
>> >> the event <paramlink id="event_type"></paramlink> will be disabled
>> >> </constant>
>> >> </constants>
>> >> -If <code>thread</code> is <code>NULL</code>,
>> >> +If <code>event_thread</code> is <code>NULL</code>,
>> >> the event is enabled or disabled globally; otherwise, it is
>> >> enabled or disabled for a particular thread.
>> >> An event is generated for
>> >>
>> >> Thanks,
>> >> Jc
>> >
>>
>
>
[Attachment #3 (text/html)]
<div dir="ltr">Thanks Serguei!<div>Jc</div></div><br><br><div \
class="gmail_quote"><div dir="ltr">On Wed, Mar 14, 2018 at 10:07 AM <a \
href="mailto:serguei.spitsyn@oracle.com">serguei.spitsyn@oracle.com</a> <<a \
href="mailto:serguei.spitsyn@oracle.com">serguei.spitsyn@oracle.com</a>> \
wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 \
.8ex;border-left:1px #ccc solid;padding-left:1ex">
<div text="#000000" bgcolor="#FFFFFF">
<div class="m_-3831337859530762045moz-cite-prefix">Hi Jc,<br>
<br>
I forgot to ask you for a patch yesterday.<br>
Thank you for webrev, it has to be enough as it has a patch in it.<br>
I'll push it now.<br>
<br>
Thanks,<br>
Serguei<br>
<br>
<br>
On 3/14/18 09:59, JC Beyler wrote:<br>
</div>
<blockquote type="cite">
<div dir="ltr">Hi David and Serguei,
<div><br>
</div>
<div>Sorry, I was not sure what would be the process for a small
fix like this. Did it make sense to make a bug/webrev and all
that or not was not clear to me. I'll know for next time.
Anyway, I assigned the bug to myself, and put the fix here:</div>
<div><a href="http://cr.openjdk.java.net/%7Ejcbeyler/8199561/" \
target="_blank">http://cr.openjdk.java.net/~jcbeyler/8199561/</a><br> </div>
<div><br>
</div>
<div>Let me know if I need to do anything else,</div>
<div>Jc</div>
<div><br>
</div>
</div>
<br>
<br>
<div class="gmail_quote">
<div dir="ltr">On Tue, Mar 13, 2018 at 5:56 PM David Holmes <<a \
href="mailto:david.holmes@oracle.com" target="_blank">david.holmes@oracle.com</a>> \
wrote:<br> </div>
<blockquote class="gmail_quote">On 14/03/2018 7:32 AM, <a \
href="mailto:serguei.spitsyn@oracle.com" \
target="_blank">serguei.spitsyn@oracle.com</a> wrote:<br> > Hi Jc,<br>
><br>
> Yes, these are typos.<br>
> Thank you for fixing them!<br>
><br>
> Is it a formal review request (RFR) ?<br>
> If so, then a bug number is needed.<br>
> I've filed one:<br>
> <a href="https://bugs.openjdk.java.net/browse/JDK-8199561" \
rel="noreferrer" target="_blank">https://bugs.openjdk.java.net/browse/JDK-8199561</a><br>
><br>
> The fix looks good.<br>
> I think, this can be fixed under a trivial fix rule with
just one review.<br>
<br>
I agree. No need for CSR either as these are just obvious
typos. :)<br>
<br>
Thanks,<br>
David<br>
<br>
> I'll sponsor it for you.<br>
><br>
> Thanks,<br>
> Serguei<br>
><br>
><br>
> On 3/13/18 10:37, JC Beyler wrote:<br>
>> Hi all,<br>
>><br>
>> I saw an error in the SetEventNotificationMode method
where the<br>
>> parameter is called event_thread but the
documentation was referring<br>
>> to it as thread. I then went and did a quick scan of
the documentation<br>
>> and found one type of "couse" instead of \
"course".<br> >><br>
>> Here is the diff, not sure it was worth doing a
webrev for it but let<br>
>> me know:<br>
>> diff -r 2d1d0c66966b
src/hotspot/share/prims/jvmti.xml<br>
>> --- a/src/hotspot/share/prims/jvmti.xmlMon Mar 12
14:11:54 2018 -0700<br>
>> +++ b/src/hotspot/share/prims/jvmti.xmlTue Mar 13
10:35:03 2018 -0700<br>
>> @@ -693,7 +693,7 @@<br>
>> mechanism causes the unload (an unload mechanism
is not specified<br>
>> in this document)<br>
>> or the library is (in effect) unloaded by the
termination of the<br>
>> VM whether through<br>
>> normal termination or VM failure, including
start-up failure.<br>
>> - Uncontrolled shutdown is, of couse, an exception
to this rule.<br>
>> + Uncontrolled shutdown is, of course, an
exception to this rule.<br>
>> Note the distinction between this function and
the<br>
>> <eventlink id="VMDeath">VM Death
event</eventlink>: for the VM<br>
>> Death event<br>
>> to be sent, the VM must have run at least to the
point of<br>
>> initialization and a valid<br>
>> @@ -9405,7 +9405,7 @@<br>
>> the event <paramlink
id="event_type"></paramlink> will be disabled<br>
>> </constant><br>
>> </constants><br>
>> -If <code>thread</code> is
<code>NULL</code>,<br>
>> +If <code>event_thread</code> is
<code>NULL</code>,<br>
>> the event is enabled or disabled globally; otherwise,
it is<br>
>> enabled or disabled for a particular thread.<br>
>> An event is generated for<br>
>><br>
>> Thanks,<br>
>> Jc<br>
><br>
</blockquote>
</div>
</blockquote>
<br>
</div>
</blockquote></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic