[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR: 8196337 Add commit methods that take all event properties as argument
From:       Leo Korinth <leo.korinth () oracle ! com>
Date:       2018-03-09 14:45:23
Message-ID: d7346815-593d-45dd-ad12-050fe7b2465f () oracle ! com
[Download RAW message or body]



On 09/03/18 15:19, Erik Helin wrote:
> On 03/09/2018 02:34 PM, Leo Korinth wrote:
>> I still need another reviewer (and a sponsor).
> 
> Looks good (well XSLT combined with C++ is awful, but the patch is good 
> :D), Reviewed. I can sponsor this patch.

Great!

Thanks,
Leo

> 
> Thanks,
> Erik
> 
>> Thanks,
>> Leo
>>
>> On 08/03/18 10:23, Markus Gronlund wrote:
>>> Hi Leo,
>>>
>>> Looks good, thanks for doing this.
>>>
>>> Sorry for the delay.
>>>
>>> Cheers
>>> Markus
>>>
>>> -----Original Message-----
>>> From: Leo Korinth
>>> Sent: den 13 februari 2018 12:26
>>> To: hotspot-runtime-dev@openjdk.java.net; 
>>> serviceability-dev@openjdk.java.net
>>> Subject: Re: RFR: 8196337 Add commit methods that take all event 
>>> properties as argument
>>>
>>> Hi,
>>>
>>> I would be happy for reviews!
>>>
>>> Thanks,
>>> Leo
>>>
>>> On 31/01/18 11:00, Leo Korinth wrote:
>>>> Hi,
>>>>
>>>> I am adding commit methods that take all event properties as argument.
>>>>
>>>> For instant events (without start and stop times) a static commit
>>>> method is created (taking all properties).
>>>>
>>>> For non-instant events, a non static commit method is created (taking
>>>> all properties). Also a static commit method (with additional
>>>> startTicks/endTicks) is created.
>>>>
>>>> Also an extra constructor is created (taking all properties). An auto
>>>> commit destructor was considered (that would auto commit if the
>>>> constructor with all properties was used) but has not yet been 
>>>> implemented.
>>>>
>>>> Enhancement:
>>>> https://bugs.openjdk.java.net/browse/JDK-8196337
>>>>
>>>> Webrev:
>>>> http://cr.openjdk.java.net/~lkorinth/8196337/00/ (open)
>>>>
>>>> Testing:
>>>> - hs-tier1, hs-tier2
>>>>
>>>> Thanks,
>>>> Leo
[prev in list] [next in list] [prev in thread] [next in thread]