[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    RE: RFR (XS): 8198539: Cleanup of unused imports in java/util/jar/Attributes.java (java.base) and Jd
From:       "Langer, Christoph" <christoph.langer () sap ! com>
Date:       2018-02-23 9:05:06
Message-ID: d38ca53ba0334db697371698b1774e41 () sap ! com
[Download RAW message or body]

[Attachment #2 (text/plain)]

Thanks, Thomas.

From: Thomas Stüfe [mailto:thomas.stuefe@gmail.com]
Sent: Donnerstag, 22. Februar 2018 09:54
To: Langer, Christoph <christoph.langer@sap.com>
Cc: Java Core Libs <core-libs-dev@openjdk.java.net>; \
                serviceability-dev@openjdk.java.net; andrew_m_leonard@uk.ibm.com
Subject: Re: RFR (XS): 8198539: Cleanup of unused imports in \
java/util/jar/Attributes.java (java.base) and JdpController.java \
(jdk.management.agent)

Hi Christoph,

Looks fine.

.. Thomas

On Feb 22, 2018 09:42, "Langer, Christoph" \
<christoph.langer@sap.com<mailto:christoph.langer@sap.com>> wrote: Hi,

please review a simple import cleanup fix for java/util/jar/Attributes.java and \
sun/management/jdp/JdpController.java.

Bug: https://bugs.openjdk.java.net/browse/JDK-8198539
Webrev: http://cr.openjdk.java.net/~clanger/webrevs/8198539.0/

Thanks and best regards
Christoph


[Attachment #3 (text/html)]

<html xmlns:v="urn:schemas-microsoft-com:vml" \
xmlns:o="urn:schemas-microsoft-com:office:office" \
xmlns:w="urn:schemas-microsoft-com:office:word" \
xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" \
xmlns="http://www.w3.org/TR/REC-html40"> <head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
	{font-family:"Cambria Math";
	panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
	{font-family:Calibri;
	panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
	{margin:0cm;
	margin-bottom:.0001pt;
	font-size:12.0pt;
	font-family:"Times New Roman",serif;}
a:link, span.MsoHyperlink
	{mso-style-priority:99;
	color:blue;
	text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
	{mso-style-priority:99;
	color:purple;
	text-decoration:underline;}
p.msonormal0, li.msonormal0, div.msonormal0
	{mso-style-name:msonormal;
	mso-margin-top-alt:auto;
	margin-right:0cm;
	mso-margin-bottom-alt:auto;
	margin-left:0cm;
	font-size:12.0pt;
	font-family:"Times New Roman",serif;}
span.EmailStyle18
	{mso-style-type:personal-reply;
	font-family:"Calibri",sans-serif;
	color:windowtext;}
.MsoChpDefault
	{mso-style-type:export-only;
	font-family:"Calibri",sans-serif;
	mso-fareast-language:EN-US;}
@page WordSection1
	{size:612.0pt 792.0pt;
	margin:72.0pt 72.0pt 72.0pt 72.0pt;}
div.WordSection1
	{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="DE" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal"><span \
style="font-size:11.0pt;font-family:&quot;Calibri&quot;,sans-serif;mso-fareast-language:EN-US">Thanks, \
Thomas.<o:p></o:p></span></p> <p class="MsoNormal"><a name="_MailEndCompose"><span \
style="mso-fareast-language:EN-US"><o:p>&nbsp;</o:p></span></a></p> <span \
style="mso-bookmark:_MailEndCompose"></span> <div \
style="border:none;border-left:solid blue 1.5pt;padding:0cm 0cm 0cm 4.0pt"> <div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0cm 0cm 0cm">
<p class="MsoNormal"><b><span lang="EN-US" \
style="font-size:11.0pt;font-family:&quot;Calibri&quot;,sans-serif">From:</span></b><span \
lang="EN-US" style="font-size:11.0pt;font-family:&quot;Calibri&quot;,sans-serif"> \
Thomas Stüfe [mailto:thomas.stuefe@gmail.com] <br>
<b>Sent:</b> Donnerstag, 22. Februar 2018 09:54<br>
<b>To:</b> Langer, Christoph &lt;christoph.langer@sap.com&gt;<br>
<b>Cc:</b> Java Core Libs &lt;core-libs-dev@openjdk.java.net&gt;; \
serviceability-dev@openjdk.java.net; andrew_m_leonard@uk.ibm.com<br> <b>Subject:</b> \
Re: RFR (XS): 8198539: Cleanup of unused imports in java/util/jar/Attributes.java \
(java.base) and JdpController.java (jdk.management.agent)<o:p></o:p></span></p> \
</div> </div>
<p class="MsoNormal"><o:p>&nbsp;</o:p></p>
<div>
<p class="MsoNormal">Hi Christoph,<o:p></o:p></p>
<div>
<p class="MsoNormal"><o:p>&nbsp;</o:p></p>
</div>
<div>
<p class="MsoNormal">Looks fine.&nbsp;<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p>&nbsp;</o:p></p>
</div>
<div>
<p class="MsoNormal">.. Thomas&nbsp;<o:p></o:p></p>
</div>
</div>
<div>
<p class="MsoNormal"><o:p>&nbsp;</o:p></p>
<div>
<p class="MsoNormal">On Feb 22, 2018 09:42, &quot;Langer, Christoph&quot; &lt;<a \
href="mailto:christoph.langer@sap.com">christoph.langer@sap.com</a>&gt; \
wrote:<o:p></o:p></p> <blockquote style="border:none;border-left:solid #CCCCCC \
1.0pt;padding:0cm 0cm 0cm 6.0pt;margin-left:4.8pt;margin-right:0cm"> <p \
class="MsoNormal" style="margin-bottom:12.0pt">Hi,<br> <br>
please review a simple import cleanup fix for java/util/jar/Attributes.java and \
sun/management/jdp/JdpController.java.<br> <br>
Bug: <a href="https://bugs.openjdk.java.net/browse/JDK-8198539" \
                target="_blank">https://bugs.openjdk.java.net/browse/JDK-8198539</a><br>
                
Webrev: <a href="http://cr.openjdk.java.net/~clanger/webrevs/8198539.0/" \
target="_blank"> http://cr.openjdk.java.net/~clanger/webrevs/8198539.0/</a><br>
<br>
Thanks and best regards<br>
Christoph<o:p></o:p></p>
</blockquote>
</div>
</div>
</div>
</div>
</body>
</html>



[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic