[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-serviceability-dev
Subject:    Re: RFR(S): 8196909: gcc 7.2.1 compiler warning in libdt_socket
From:       Chris Plummer <chris.plummer () oracle ! com>
Date:       2018-02-15 17:17:28
Message-ID: ad0d2cd9-5a89-79c9-41fb-07b4b12a415a () oracle ! com
[Download RAW message or body]

Thanks Christoph and Serguei.

Chris

On 2/14/18 11:47 PM, Langer, Christoph wrote:
> Hi Chris,
>
> looks good.
>
> Best regards
> Christoph
>
>> -----Original Message-----
>> From: serviceability-dev [mailto:serviceability-dev-
>> bounces@openjdk.java.net] On Behalf Of Chris Plummer
>> Sent: Mittwoch, 14. Februar 2018 23:31
>> To: serviceability-dev <serviceability-dev@openjdk.java.net>
>> Cc: Indu Bhagat <indu.bhagat@oracle.com>
>> Subject: RFR(S): 8196909: gcc 7.2.1 compiler warning in libdt_socket
>>
>> Hello,
>>
>> Please review the following simple fix for a compiler warning:
>>
>> https://bugs.openjdk.java.net/browse/JDK-8196909
>>
>> diff --git
>> a/src/jdk.jdwp.agent/share/native/libdt_socket/socketTransport.c
>> b/src/jdk.jdwp.agent/share/native/libdt_socket/socketTransport.c
>> --- a/src/jdk.jdwp.agent/share/native/libdt_socket/socketTransport.c
>> +++ b/src/jdk.jdwp.agent/share/native/libdt_socket/socketTransport.c
>> @@ -398,7 +398,7 @@
>>                  return instr;
>>            }
>>
>> -       *mask = htonl(-1 << (32 - m));
>> +       *mask = htonl((uint32_t)(~0) << (32 - m));
>>            return s;
>>     }
>>
>>
>> Tested with all open and closed jdb, jdwp, and jdi test suites on all
>> supported platforms.
>>
>> thanks,
>>
>> Chris



[prev in list] [next in list] [prev in thread] [next in thread]