[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-serviceability-dev
Subject: Re: Issues debugging java 9 from jdk 8
From: Egor Ushakov <egor.ushakov () jetbrains ! com>
Date: 2018-02-13 9:14:14
Message-ID: 77f0c027-4df2-baba-8d90-0755df27aec0 () jetbrains ! com
[Download RAW message or body]
Thanks Chris!
Unfortunately, I'm unable to join the list, also I do not see this
forwarded email in the jdk8u-dev archives:
http://mail.openjdk.java.net/pipermail/jdk8u-dev/2018-February/thread.html
Probably we're not on the list or something.
Can someone on the jdk8u-dev mailing list forward it there?
Thanks,
Egor
On 08-Feb-18 01:44, Chris Plummer wrote:
> Hi Egor,
>
> [adding jdk8u-dev, which is where 8u backports are discussed]
>
> I think major.minor changed from 1.8 to 9.0, although I haven't found
> the code to confirm that yet. I'm assuming this because of the
> following code:
>
> public boolean canGetModuleInfo() {
> validateVM();
> return versionInfo().jdwpMajor >= 9;
> }
>
> Given that, your changes look correct. I'm not an 8u reviewer. You'll
> need to get the official ok from someone on the 8u list.
>
> thanks,
>
> Chris
>
> On 2/5/18 7:44 AM, Egor Ushakov wrote:
>>
>> Hi all,
>>
>> in IDEA we faced an issue that when debugging java 9 process memory
>> view does not work:
>> https://youtrack.jetbrains.com/issue/JRE-641
>>
>> It seems that there's a bug in how
>> VirtualMachineImpl.canGetInstanceInfo checks vm version (it does not
>> pass jdk 9 where minor is 0):
>> if(versionInfo().jdwpMajor <1||
>> versionInfo().jdwpMinor <6){
>> returnfalse;
>> }
>> I've found this fixed in jdk 9 inside the fix:
>> http://hg.openjdk.java.net/jdk9/hs/rev/f900d5afd9c8
>> 8142968: Module System implementation Summary: Initial integration of
>> JEP 200, JEP 260, JEP 261, and JEP 282 alanb 17-Mar-16 22:04
>>
>> We've applied the part of the fix into our jdk 8 fork:
>> https://github.com/JetBrains/jdk8u_jdk/commit/6424e2786e8adc4e012e0b7bd0cfc78ba1ab34dd
>>
>> It seems reasonable to backport at least this part into openjdk 8?
>> What do you think?
>> Maybe some other parts deserve backporting as well.
>> I've attached the patch just in case.
>> --
>> Egor Ushakov
>> Software Developer
>> JetBrains
>> http://www.jetbrains.com
>> The Drive to Develop
>
>
--
Egor Ushakov
Software Developer
JetBrains
http://www.jetbrains.com
The Drive to Develop
[Attachment #3 (text/html)]
<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<p>Thanks Chris!</p>
Unfortunately, I'm unable to join the list, also I do not see this
forwarded email in the jdk8u-dev archives:<br>
<a class="moz-txt-link-freetext" \
href="http://mail.openjdk.java.net/pipermail/jdk8u-dev/2018-February/thread.html">http://mail.openjdk.java.net/pipermail/jdk8u-dev/2018-February/thread.html</a><br>
Probably we're not on the list or something.<br>
<br>
Can someone on the jdk8u-dev mailing list forward it there?<br>
<br>
Thanks,<br>
Egor<br>
<br>
<div class="moz-cite-prefix">On 08-Feb-18 01:44, Chris Plummer
wrote:<br>
</div>
<blockquote type="cite"
cite="mid:d64ddcc7-9f61-a807-4a07-51a92ca7439e@oracle.com">
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<div class="moz-cite-prefix">Hi Egor,<br>
<br>
[adding jdk8u-dev, which is where 8u backports are discussed]<br>
<br>
I think major.minor changed from 1.8 to 9.0, although I haven't
found the code to confirm that yet. I'm assuming this because of
the following code:<br>
<br>
public boolean canGetModuleInfo() {<br>
validateVM();<br>
return versionInfo().jdwpMajor >= 9;<br>
}<br>
<br>
Given that, your changes look correct. I'm not an 8u reviewer.
You'll need to get the official ok from someone on the 8u list.<br>
<br>
thanks,<br>
<br>
Chris<br>
<br>
On 2/5/18 7:44 AM, Egor Ushakov wrote:<br>
</div>
<blockquote type="cite"
cite="mid:69179b71-90c0-d921-dd8c-3b5800ce8f6d@jetbrains.com">
<meta http-equiv="content-type" content="text/html;
charset=utf-8">
<p>Hi all,</p>
in IDEA we faced an issue that when debugging java 9 process
memory view does not work:<br>
<a class="moz-txt-link-freetext"
href="https://youtrack.jetbrains.com/issue/JRE-641"
moz-do-not-send="true">https://youtrack.jetbrains.com/issue/JRE-641</a><br>
<br>
It seems that there's a bug in how
VirtualMachineImpl.canGetInstanceInfo checks vm version (it does
not pass jdk 9 where minor is 0):<br>
<span class="kwd" style="display: inline; font-family: Menlo,"Bitstream \
Vera Sans Mono",Consolas,"Lucida Console","Courier \
New",Courier,monospace; font-size: 14px; font-style: normal; \
font-variant-ligatures: normal; font-variant-caps: normal; font-weight: 400; \
letter-spacing: normal; text-align: left; text-indent: 0px; text-transform: none; \
white-space: pre-wrap; word-spacing: 0px; -webkit-text-stroke-width: 0px; \
text-decoration-style: initial; text-decoration-color: initial;">if</span><span \
class="pln" style="display: inline; font-family: Menlo,"Bitstream Vera Sans \
Mono",Consolas,"Lucida Console","Courier \
New",Courier,monospace; font-size: 14px; font-style: normal; \
font-variant-ligatures: normal; font-variant-caps: normal; font-weight: 400; \
letter-spacing: normal; text-align: left; text-indent: 0px; text-transform: none; \
white-space: pre-wrap; word-spacing: 0px; -webkit-text-stroke-width: 0px; \
text-decoration-style: initial; text-decoration-color: initial;"> </span><span \
class="pun" style="display: inline; font-family: Menlo,"Bitstream Vera Sans \
Mono",Consolas,"Lucida Console","Courier \
New",Courier,monospace; font-size: 14px; font-style: normal; \
font-variant-ligatures: normal; font-variant-caps: normal; font-weight: 400; \
letter-spacing: normal; text-align: left; text-indent: 0px; text-transform: none; \
white-space: pre-wrap; word-spacing: 0px; -webkit-text-stroke-width: 0px; \
text-decoration-style: initial; text-decoration-color: initial;">(</span><span \
class="pln" style="display: inline; font-family: Menlo,"Bitstream Vera Sans \
Mono",Consolas,"Lucida Console","Courier \
New",Courier,monospace; font-size: 14px; font-style: normal; \
font-variant-ligatures: normal; font-variant-caps: normal; font-weight: 400; \
letter-spacing: normal; text-align: left; text-indent: 0px; text-transform: none; \
white-space: pre-wrap; word-spacing: 0px; -webkit-text-stroke-width: 0px; \
text-decoration-style: initial; text-decoration-color: \
initial;">versionInfo</span><span class="pun" style="display: inline; font-family: \
Menlo,"Bitstream Vera Sans Mono",Consolas,"Lucida \
Console","Courier New",Courier,monospace; font-size: 14px; font-style: \
normal; font-variant-ligatures: normal; font-variant-caps: normal; font-weight: 400; \
letter-spacing: normal; text-align: left; text-indent: 0px; text-transform: none; \
white-space: pre-wrap; word-spacing: 0px; -webkit-text-stroke-width: 0px; \
text-decoration-style: initial; text-decoration-color: initial;">().</span><span \
class="pln" style="display: inline; font-family: Menlo,"Bitstream Vera Sans \
Mono",Consolas,"Lucida Console","Courier \
New",Courier,monospace; font-size: 14px; font-style: normal; \
font-variant-ligatures: normal; font-variant-caps: normal; font-weight: 400; \
letter-spacing: normal; text-align: left; text-indent: 0px; text-transform: none; \
white-space: pre-wrap; word-spacing: 0px; -webkit-text-stroke-width: 0px; \
text-decoration-style: initial; text-decoration-color: initial;">jdwpMajor \
</span><span class="pun" style="display: inline; font-family: Menlo,"Bitstream \
Vera Sans Mono",Consolas,"Lucida Console","Courier \
New",Courier,monospace; font-size: 14px; font-style: normal; \
font-variant-ligatures: normal; font-variant-caps: normal; font-weight: 400; \
letter-spacing: normal; text-align: left; text-indent: 0px; text-transform: none; \
white-space: pre-wrap; word-spacing: 0px; -webkit-text-stroke-width: 0px; \
text-decoration-style: initial; text-decoration-color: initial;"><</span><span \
class="pln" style="display: inline; font-family: Menlo,"Bitstream Vera Sans \
Mono",Consolas,"Lucida Console","Courier \
New",Courier,monospace; font-size: 14px; font-style: normal; \
font-variant-ligatures: normal; font-variant-caps: normal; font-weight: 400; \
letter-spacing: normal; text-align: left; text-indent: 0px; text-transform: none; \
white-space: pre-wrap; word-spacing: 0px; -webkit-text-stroke-width: 0px; \
text-decoration-style: initial; text-decoration-color: initial;"> </span><span \
class="lit" style="display: inline; font-family: Menlo,"Bitstream Vera Sans \
Mono",Consolas,"Lucida Console","Courier \
New",Courier,monospace; font-size: 14px; font-style: normal; \
font-variant-ligatures: normal; font-variant-caps: normal; font-weight: 400; \
letter-spacing: normal; text-align: left; text-indent: 0px; text-transform: none; \
white-space: pre-wrap; word-spacing: 0px; -webkit-text-stroke-width: 0px; \
text-decoration-style: initial; text-decoration-color: initial;">1</span><span \
class="pln" style="display: inline; font-family: Menlo,"Bitstream Vera Sans \
Mono",Consolas,"Lucida Console","Courier \
New",Courier,monospace; font-size: 14px; font-style: normal; \
font-variant-ligatures: normal; font-variant-caps: normal; font-weight: 400; \
letter-spacing: normal; text-align: left; text-indent: 0px; text-transform: none; \
white-space: pre-wrap; word-spacing: 0px; -webkit-text-stroke-width: 0px; \
text-decoration-style: initial; text-decoration-color: initial;"> </span><span \
class="pun" style="display: inline; font-family: Menlo,"Bitstream Vera Sans \
Mono",Consolas,"Lucida Console","Courier \
New",Courier,monospace; font-size: 14px; font-style: normal; \
font-variant-ligatures: normal; font-variant-caps: normal; font-weight: 400; \
letter-spacing: normal; text-align: left; text-indent: 0px; text-transform: none; \
white-space: pre-wrap; word-spacing: 0px; -webkit-text-stroke-width: 0px; \
text-decoration-style: initial; text-decoration-color: initial;">||</span><br> <span \
class="pln" style="display: inline; font-family: Menlo,"Bitstream Vera Sans \
Mono",Consolas,"Lucida Console","Courier \
New",Courier,monospace; font-size: 14px; font-style: normal; \
font-variant-ligatures: normal; font-variant-caps: normal; font-weight: 400; \
letter-spacing: normal; text-align: left; text-indent: 0px; text-transform: none; \
white-space: pre-wrap; word-spacing: 0px; -webkit-text-stroke-width: 0px; \
text-decoration-style: initial; text-decoration-color: initial;"> \
versionInfo</span><span class="pun" style="display: inline; font-family: \
Menlo,"Bitstream Vera Sans Mono",Consolas,"Lucida \
Console","Courier New",Courier,monospace; font-size: 14px; font-style: \
normal; font-variant-ligatures: normal; font-variant-caps: normal; font-weight: 400; \
letter-spacing: normal; text-align: left; text-indent: 0px; text-transform: none; \
white-space: pre-wrap; word-spacing: 0px; -webkit-text-stroke-width: 0px; \
text-decoration-style: initial; text-decoration-color: initial;">().</span><span \
class="pln" style="display: inline; font-family: Menlo,"Bitstream Vera Sans \
Mono",Consolas,"Lucida Console","Courier \
New",Courier,monospace; font-size: 14px; font-style: normal; \
font-variant-ligatures: normal; font-variant-caps: normal; font-weight: 400; \
letter-spacing: normal; text-align: left; text-indent: 0px; text-transform: none; \
white-space: pre-wrap; word-spacing: 0px; -webkit-text-stroke-width: 0px; \
text-decoration-style: initial; text-decoration-color: initial;">jdwpMinor \
</span><span class="pun" style="display: inline; font-family: Menlo,"Bitstream \
Vera Sans Mono",Consolas,"Lucida Console","Courier \
New",Courier,monospace; font-size: 14px; font-style: normal; \
font-variant-ligatures: normal; font-variant-caps: normal; font-weight: 400; \
letter-spacing: normal; text-align: left; text-indent: 0px; text-transform: none; \
white-space: pre-wrap; word-spacing: 0px; -webkit-text-stroke-width: 0px; \
text-decoration-style: initial; text-decoration-color: initial;"><</span><span \
class="pln" style="display: inline; font-family: Menlo,"Bitstream Vera Sans \
Mono",Consolas,"Lucida Console","Courier \
New",Courier,monospace; font-size: 14px; font-style: normal; \
font-variant-ligatures: normal; font-variant-caps: normal; font-weight: 400; \
letter-spacing: normal; text-align: left; text-indent: 0px; text-transform: none; \
white-space: pre-wrap; word-spacing: 0px; -webkit-text-stroke-width: 0px; \
text-decoration-style: initial; text-decoration-color: initial;"> </span><span \
class="lit" style="display: inline; font-family: Menlo,"Bitstream Vera Sans \
Mono",Consolas,"Lucida Console","Courier \
New",Courier,monospace; font-size: 14px; font-style: normal; \
font-variant-ligatures: normal; font-variant-caps: normal; font-weight: 400; \
letter-spacing: normal; text-align: left; text-indent: 0px; text-transform: none; \
white-space: pre-wrap; word-spacing: 0px; -webkit-text-stroke-width: 0px; \
text-decoration-style: initial; text-decoration-color: initial;">6</span><span \
class="pun" style="display: inline; font-family: Menlo,"Bitstream Vera Sans \
Mono",Consolas,"Lucida Console","Courier \
New",Courier,monospace; font-size: 14px; font-style: normal; \
font-variant-ligatures: normal; font-variant-caps: normal; font-weight: 400; \
letter-spacing: normal; text-align: left; text-indent: 0px; text-transform: none; \
white-space: pre-wrap; word-spacing: 0px; -webkit-text-stroke-width: 0px; \
text-decoration-style: initial; text-decoration-color: initial;">)</span><span \
class="pln" style="display: inline; font-family: Menlo,"Bitstream Vera Sans \
Mono",Consolas,"Lucida Console","Courier \
New",Courier,monospace; font-size: 14px; font-style: normal; \
font-variant-ligatures: normal; font-variant-caps: normal; font-weight: 400; \
letter-spacing: normal; text-align: left; text-indent: 0px; text-transform: none; \
white-space: pre-wrap; word-spacing: 0px; -webkit-text-stroke-width: 0px; \
text-decoration-style: initial; text-decoration-color: initial;"> </span><span \
class="pun" style="display: inline; font-family: Menlo,"Bitstream Vera Sans \
Mono",Consolas,"Lucida Console","Courier \
New",Courier,monospace; font-size: 14px; font-style: normal; \
font-variant-ligatures: normal; font-variant-caps: normal; font-weight: 400; \
letter-spacing: normal; text-align: left; text-indent: 0px; text-transform: none; \
white-space: pre-wrap; word-spacing: 0px; -webkit-text-stroke-width: 0px; \
text-decoration-style: initial; text-decoration-color: initial;">{</span><br> <span \
class="pln" style="display: inline; font-family: Menlo,"Bitstream Vera Sans \
Mono",Consolas,"Lucida Console","Courier \
New",Courier,monospace; font-size: 14px; font-style: normal; \
font-variant-ligatures: normal; font-variant-caps: normal; font-weight: 400; \
letter-spacing: normal; text-align: left; text-indent: 0px; text-transform: none; \
white-space: pre-wrap; word-spacing: 0px; -webkit-text-stroke-width: 0px; \
text-decoration-style: initial; text-decoration-color: initial;"> </span><span \
class="kwd" style="display: inline; font-family: Menlo,"Bitstream Vera Sans \
Mono",Consolas,"Lucida Console","Courier \
New",Courier,monospace; font-size: 14px; font-style: normal; \
font-variant-ligatures: normal; font-variant-caps: normal; font-weight: 400; \
letter-spacing: normal; text-align: left; text-indent: 0px; text-transform: none; \
white-space: pre-wrap; word-spacing: 0px; -webkit-text-stroke-width: 0px; \
text-decoration-style: initial; text-decoration-color: initial;">return</span><span \
class="pln" style="display: inline; font-family: Menlo,"Bitstream Vera Sans \
Mono",Consolas,"Lucida Console","Courier \
New",Courier,monospace; font-size: 14px; font-style: normal; \
font-variant-ligatures: normal; font-variant-caps: normal; font-weight: 400; \
letter-spacing: normal; text-align: left; text-indent: 0px; text-transform: none; \
white-space: pre-wrap; word-spacing: 0px; -webkit-text-stroke-width: 0px; \
text-decoration-style: initial; text-decoration-color: initial;"> </span><span \
class="kwd" style="display: inline; font-family: Menlo,"Bitstream Vera Sans \
Mono",Consolas,"Lucida Console","Courier \
New",Courier,monospace; font-size: 14px; font-style: normal; \
font-variant-ligatures: normal; font-variant-caps: normal; font-weight: 400; \
letter-spacing: normal; text-align: left; text-indent: 0px; text-transform: none; \
white-space: pre-wrap; word-spacing: 0px; -webkit-text-stroke-width: 0px; \
text-decoration-style: initial; text-decoration-color: initial;">false</span><span \
class="pun" style="display: inline; font-family: Menlo,"Bitstream Vera Sans \
Mono",Consolas,"Lucida Console","Courier \
New",Courier,monospace; font-size: 14px; font-style: normal; \
font-variant-ligatures: normal; font-variant-caps: normal; font-weight: 400; \
letter-spacing: normal; text-align: left; text-indent: 0px; text-transform: none; \
white-space: pre-wrap; word-spacing: 0px; -webkit-text-stroke-width: 0px; \
text-decoration-style: initial; text-decoration-color: initial;">;</span><br> <span \
class="pun" style="display: inline; font-family: Menlo,"Bitstream Vera Sans \
Mono",Consolas,"Lucida Console","Courier \
New",Courier,monospace; font-size: 14px; font-style: normal; \
font-variant-ligatures: normal; font-variant-caps: normal; font-weight: 400; \
letter-spacing: normal; text-align: left; text-indent: 0px; text-transform: none; \
white-space: pre-wrap; word-spacing: 0px; -webkit-text-stroke-width: 0px; \
text-decoration-style: initial; text-decoration-color: initial;">}</span><br> <span \
class="pun" style="display: inline; font-family: Menlo,"Bitstream Vera Sans \
Mono",Consolas,"Lucida Console","Courier \
New",Courier,monospace; font-size: 14px; font-style: normal; \
font-variant-ligatures: normal; font-variant-caps: normal; font-weight: 400; \
letter-spacing: normal; text-align: left; text-indent: 0px; text-transform: none; \
white-space: pre-wrap; word-spacing: 0px; -webkit-text-stroke-width: 0px; \
text-decoration-style: initial; text-decoration-color: initial;"></span><span \
class="pun" style="display: inline; font-family: Menlo,"Bitstream Vera Sans \
Mono",Consolas,"Lucida Console","Courier \
New",Courier,monospace; font-size: 14px; font-style: normal; \
font-variant-ligatures: normal; font-variant-caps: normal; font-weight: 400; \
letter-spacing: normal; text-align: left; text-indent: 0px; text-transform: none; \
white-space: pre-wrap; word-spacing: 0px; -webkit-text-stroke-width: 0px; \
text-decoration-style: initial; text-decoration-color: initial;"> </span>I've found \
this fixed in jdk 9 inside the fix:<br> <a class="moz-txt-link-freetext"
href="http://hg.openjdk.java.net/jdk9/hs/rev/f900d5afd9c8"
moz-do-not-send="true">http://hg.openjdk.java.net/jdk9/hs/rev/f900d5afd9c8</a><br>
8142968: Module System implementation Summary: Initial
integration of JEP 200, JEP 260, JEP 261, and JEP 282 alanb
17-Mar-16 22:04 <br>
<br>
We've applied the part of the fix into our jdk 8 fork:<br>
<a class="moz-txt-link-freetext"
href="https://github.com/JetBrains/jdk8u_jdk/commit/6424e2786e8adc4e012e0b7bd0cfc78ba1ab34dd"
moz-do-not-send="true">https://github.com/JetBrains/jdk8u_jdk/commit/6424e2786e8adc4e012e0b7bd0cfc78ba1ab34dd</a><br>
<br>
It seems reasonable to backport at least this part into openjdk
8? What do you think?<br>
Maybe some other parts deserve backporting as well.<br>
I've attached the patch just in case.<br>
<pre class="moz-signature" cols="72">--
Egor Ushakov
Software Developer
JetBrains
<a class="moz-txt-link-freetext" href="http://www.jetbrains.com" \
moz-do-not-send="true">http://www.jetbrains.com</a> The Drive to Develop</pre>
</blockquote>
<p><br>
</p>
</blockquote>
<br>
<pre class="moz-signature" cols="72">--
Egor Ushakov
Software Developer
JetBrains
<a class="moz-txt-link-freetext" \
href="http://www.jetbrains.com">http://www.jetbrains.com</a> The Drive to \
Develop</pre> </body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic